Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp216933rdd; Tue, 9 Jan 2024 01:40:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IEn4nP3V/SzefQndjOs+3WmAs5dEsQZhyVIWlCQdDYiuE7E/+5JD+mw/YRqpneQWJh+59mz X-Received: by 2002:a05:6a00:816:b0:6d9:b6db:3412 with SMTP id m22-20020a056a00081600b006d9b6db3412mr2611750pfk.54.1704793201122; Tue, 09 Jan 2024 01:40:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704793201; cv=none; d=google.com; s=arc-20160816; b=fOyfk6BxlPsYA0UFS2uAncjN4snZA3LCAGN+/3Gsdsxl+3UsgDctGgpJx60kp0NK3v eDK8kTTaASLoEEJG5rbGsAGsDaD78qjVLt59JsZbwglSZY6lGWPQj0HdhwWpjMsq5Tqz kDDxnPK9U0TwAEYkMhzcCXE22hiUvhmjXvxvCs0w89gl+ft7vWI6gtzNVJi2cc46qVo0 nW0+/YLKvZ7iWIX9Wkqh5D7hQuUKmLqEOraTmi9Uy2/oIVbCd61NW0Y0l0bMsK/g2gSB VKbGENYWEwlXMXBqc3fa+XXE/h3BLWqMjYyMS+V4EAyZqVyaXw7WELvzNK5aiSJOgCKm HDNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=OdqzZjfPihD8+HAjcrPs6VxIF0BP9O0oEYSSObMVmwM=; fh=HYQI73m6iIQGTQx432eKL9WZk0kWIbNcg04rW3j6i78=; b=MoJME9uu1yjifoxXgPi7/C06bmtxA9mWHHF/Le8wCQLq3LBXxtviWHVEMK7wgH2OJQ sbWBGw6hMifMh0+ai/ed+8yDKPYft7pTPvxZWzr/O0eK7hK0E7XPmn5TwXAiwmHB/1l6 KI1zP/pVjpKOCam6UqxFWDTv14VEXMpvTTWb3oZ1Af5LZEb2E5BgdCnAfZVXCOzf1IND SKOAy4m9exhANSbQLY5pT+6aBtGNExcRfaaa0MNnS61yYNTyunquCcaAArkf1JmiBIMU 0F2yrTk4Z+9cz3hME6eNJ1B1kA58LsmWrMiO/6DSm37qJconeFHr0OJMPnpxm+vcUPVN JCzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=kY4Q7ANt; spf=pass (google.com: domain of linux-kernel+bounces-20671-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20671-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id t25-20020aa78f99000000b006d9b8feeee4si1188253pfs.249.2024.01.09.01.40.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 01:40:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-20671-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=kY4Q7ANt; spf=pass (google.com: domain of linux-kernel+bounces-20671-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20671-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id DEF7EB23C43 for ; Tue, 9 Jan 2024 09:36:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8C0963588D; Tue, 9 Jan 2024 09:36:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="kY4Q7ANt" Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AB1B2E650; Tue, 9 Jan 2024 09:36:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=OdqzZjfPihD8+HAjcrPs6VxIF0BP9O0oEYSSObMVmwM=; b=kY4Q7ANtAKQyWVEnwcsX8lvWjn RqXPViI3icGXcSBHCKEJV/DfpqSZV5LK3wTekFKqLNq2sEXp7AuifzqEvAnrlHx38e92b5KMSzMYO NM2uzOklo5iF+XPpcxy5pt8djMw57C5LxD1ih+v9P6zyc267spyPHzKDVBXlcg5D/OmADrlZex+yj nYsSyGjPIHC55rwONu/9cY6H3zt+bljipIoaGb8A8daCC+mSZCjPQeUoyVmdjb8piYtrXW/qSGTrF nlJpBLHmefxBdvjs0dD8/M7pxMS8z4/7qKq7kEZyN/R/WEbrseMI3G4SAjvFoLrpeMZvuAIxkIuoE VuDkr/Bw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:37974) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rN8WV-0003wa-24; Tue, 09 Jan 2024 09:35:51 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rN8WU-00049r-MQ; Tue, 09 Jan 2024 09:35:50 +0000 Date: Tue, 9 Jan 2024 09:35:50 +0000 From: "Russell King (Oracle)" To: Arnd Bergmann Cc: Jiawen Wu , Mengyuan Lou , Jakub Kicinski , Arnd Bergmann , "David S. Miller" , Eric Dumazet , Paolo Abeni , Andrew Lunn , Maciej Fijalkowski , Andy Shevchenko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] wangxunx: select CONFIG_PHYLINK where needed Message-ID: References: <20240109075656.2656359-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240109075656.2656359-1-arnd@kernel.org> Sender: Russell King (Oracle) On Tue, Jan 09, 2024 at 08:56:21AM +0100, Arnd Bergmann wrote: > diff --git a/drivers/net/ethernet/wangxun/Kconfig b/drivers/net/ethernet/wangxun/Kconfig > index 23cd610bd376..46630f05d8dd 100644 > --- a/drivers/net/ethernet/wangxun/Kconfig > +++ b/drivers/net/ethernet/wangxun/Kconfig > @@ -26,6 +26,7 @@ config NGBE > tristate "Wangxun(R) GbE PCI Express adapters support" > depends on PCI > select LIBWX > + select PHYLINK > select PHYLIB You can drop PHYLIB when adding PHYLINK. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!