Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp229298rdd; Tue, 9 Jan 2024 02:11:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IF4GIlG+NceD7rilJKchK0Isaw5XmiLkglZBEQxTzZhJTwhy7MpI1EGshYuBLsVYVOBpbar X-Received: by 2002:a17:907:767b:b0:a28:fa54:ff4a with SMTP id kk27-20020a170907767b00b00a28fa54ff4amr360533ejc.22.1704795097153; Tue, 09 Jan 2024 02:11:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704795097; cv=none; d=google.com; s=arc-20160816; b=SSMAm69fW0izHfKeKLGF8aavOxLFLVd3ZySotem/etdlVn1bsegyRfwp/fmOLE9WZG Mb4P3U26P0B2cAwbRcXgckKqk5p4Y87sB+Ji1KUXYE6uJNNzDmW0GliwgBfUrTzkE82G REdjnmMaCZ6WRlJAvf6JYBYAxKEU4Iptil5NhT1AjsedfAoPY3pBMfwofm6fZi7qIY2F KD9dzdkuu4GdyhlcWjP0wDUhOKsmPh9+d7iZ5WsKYQ1AnCzdmsISHUXeC4vfkUgnU4kx Q8QmP1pMTMPgb5BAGNTyOWSJuzLYoa6dffHHtEDKBO8jwW64Yhpkc9a3VkHYRCcqUk9Z Uxgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=InBsjfcPbD0c+q8fnXL3fWO3CABrbmsq65TbZt2PlTY=; fh=9H0u7RHRFW2ckxDIqq8mdrCCPfm8522c/+fFn5BMUag=; b=ZrPlgR78+W6Uot0W+9pfriBXc/CQy+QR9filkEI0vaVJG6eE8zr4z2dW3xWVzIt6r0 v2vH9V53v2DLraYH3quxkrFXsk7wDirbSe5oJSYl1l6ktvK8C59JsjJtNwHVq7bl6DH3 jUpDTeHRFXlKVBGOXLB4oBTG5UopXvklcdHwFIjDY1Q2m1x27huFTR9PIZMcn49z2lTe KWsrgBVol3XWbFZrm6jC//w1BcWbFUC00pveLPe3YYaNJ+rmNVX6ZCJIsFwVlN1didUA yENaRMbSuKuSg9cFEjz7hDk+Z5vhrbeyvCEirODYZfAKEmjMoLFcdqnpohx2ECwaRZJD ihHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WcXXsHyc; spf=pass (google.com: domain of linux-kernel+bounces-20689-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20689-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id g16-20020a170906395000b00a282c6cc0cbsi683552eje.94.2024.01.09.02.11.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 02:11:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-20689-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WcXXsHyc; spf=pass (google.com: domain of linux-kernel+bounces-20689-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20689-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6C1AD1F280E9 for ; Tue, 9 Jan 2024 09:53:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A6E2C358A4; Tue, 9 Jan 2024 09:53:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WcXXsHyc" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC0E4612E; Tue, 9 Jan 2024 09:53:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED03BC433C7; Tue, 9 Jan 2024 09:53:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704794020; bh=ZzK6Vp42TEIsfIyJQNP28NhtlMFkU94Dmq0D+Z7QDdY=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=WcXXsHycg7s8ZD808aEB0IuRC/Bag1Sc2v1jQ1iPEZTISo/tm2USeZdeUBa8t5M2T KR0d4J4uyeFP46pmE8UD79VBJoFRzYRScKZ/BAgt+0ukv1CPzT+2ZtirRFupNTafW9 3xg0RMGDRU0b8/Ni3Ftj6CXsGn/jlyG+x6z3pVtf/V5lUC0Sfd0I1qi1vfTmuJyjPB d+UKsA0AYpYGPUmpYC30JvsItCj+vccj4sFO7bTVWw/RdrRWAPpRlvXTHUte7IRFmq wJBvfO2EfGZIkIt8AdooIFeMvU4GM3YFBmdw/XCwuirYcdqr+/NfCoFVeKhnPZkiFG EtXgf/VEpHetg== From: Mark Brown To: =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado?= Cc: AngeloGioacchino Del Regno , kernel@collabora.com, Jaroslav Kysela , Kuninori Morimoto , Liam Girdwood , Matthias Brugger , =?utf-8?q?N=C3=ADcolas_F=2E_R=2E_A=2E_Prado_via_Alsa-devel?= , Rob Herring , Takashi Iwai , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-sound@vger.kernel.org In-Reply-To: <20240108204508.691739-1-nfraprado@collabora.com> References: <20240108204508.691739-1-nfraprado@collabora.com> Subject: Re: [PATCH] ASoC: mediatek: mt8192: Check existence of dai_name before dereferencing Message-Id: <170479401767.23951.13089659929333674161.b4-ty@kernel.org> Date: Tue, 09 Jan 2024 09:53:37 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.13-dev-5c066 On Mon, 08 Jan 2024 17:44:58 -0300, NĂ­colas F. R. A. Prado wrote: > Following commit 13f58267cda3 ("ASoC: soc.h: don't create dummy > Component via COMP_DUMMY()"), the dai_name field is only populated for > dummy components after the card is registered. This causes a null > pointer dereference in the mt8192-mt6359 sound card driver's probe > function when searching for a dai_name among all the card's dai links. > > Verify that the dai_name is non-null before passing it to strcmp. While > at it, also check that there's at least one codec. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: mediatek: mt8192: Check existence of dai_name before dereferencing commit: 4d4e1b6319e5c4425ea3faeaf9a10b8b4c16c1e1 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark