Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp235282rdd; Tue, 9 Jan 2024 02:25:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IHfbn6yWz06F4ORuXdF5l1VyZM1SExyTeQbUSOB7GYhVTFmZtbNYHRS7ELlkIbT3zMFbudG X-Received: by 2002:a05:6358:3421:b0:174:c858:cd3d with SMTP id h33-20020a056358342100b00174c858cd3dmr5670436rwd.63.1704795936311; Tue, 09 Jan 2024 02:25:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704795936; cv=none; d=google.com; s=arc-20160816; b=Y982lvmHPXE3BRknT4O1l2ndj/ss4Ta+cvJe/nncV+TsDnE/cqWveObi/rwwZpZJ9I ZlEPfaMhkn6rOOs20FgKEXcGAZ3C/yU3UQ2ndQwBhpDy6ji4WZxQhiWW9UennFJ4m91u h9dEh/7/UxyIGmzFGDcPdhXMV4jqfxW/445wRXb56qxaLiEqKQACaUz2wkVivbWFxD5g yJVX+ZUdSxZHtHywFfR3uFtGwv93s+uBn4dck9d2gSp8JhthwLvWqpWiUYeI9+Fbl8Fz Kh2tqbIRlI9JNvAv7oj/SYmNcZg5A2bn8IAhIgaC+MLBWHuARa7kZ6SxuErCDvqpX0KR gPkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Sk/+6/4aZ2g5FOpdLVk/vefrE9ZW3KuMjbQNbUz8JOg=; fh=TSkeCpDdY0uvfjc97GyUdqyKpSSV5gl2hl3h+1d+qWs=; b=XflahOGec7kh5Nq7uBhd0GEre8mCkkEijI91pdpfApCBl3nOQxbdr9rui0Iqp1yod/ RWgJE2Xl7Jm8OLKMz4FzFy3CKnmnZeJAqeM4VRO01VgyXijmlmgUO+FN2wrwSD4zWUvC UdbaS2at7ONCbktCAZ6u3ISRKbq2GJGvYDysypgxvMS43oa1D3IkMdTpgEX5Hl3bbdBT UogTRkdWzRvacvU4VTSEzu9fE4S72JOjLXrNKpo9mrG+5o6MMo0ew2ao43iKDdxRXBS+ FYS0GochDoykV/kv3wvZZC7I2qRF48GeX0SeCzuFgIyLLcEc3aZLVrdIzTFeHEwcN0i7 D0SA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=dhZ+LEgq; spf=pass (google.com: domain of linux-kernel+bounces-20713-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20713-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id l6-20020a633e06000000b005cec9fd8061si1182671pga.511.2024.01.09.02.25.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 02:25:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-20713-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=dhZ+LEgq; spf=pass (google.com: domain of linux-kernel+bounces-20713-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-20713-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 920872857AB for ; Tue, 9 Jan 2024 10:25:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D5DB7360BA; Tue, 9 Jan 2024 10:25:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="dhZ+LEgq" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BE9C36084; Tue, 9 Jan 2024 10:25:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704795916; x=1736331916; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=qybVg1yF1U6mARID1UkppiGKiT8bQ1f8SyBzaQJjJGQ=; b=dhZ+LEgqwvh/4f41E1YdCJQYzL+Wc3d2NQuvmfErICY+ck4kyIbIuvQr 5T9nu7H3lmC1yP7h/VuhTrBiG90A9xDSM3HjKQOT7DwZ8+vjMbEaEGdGy ZawRH8mOPdHr61VhbwkavAxkG7UHl6N1lgEssw+i79rROTkqxkQVtcX2d w3F2kbn3Za+TQaXCuwx9jua4t04NiXci95l0+9hU7PplJjheZiOzhq01i a3lANB7I7m9fzsp1rL6RZVSxhP1UIW/H4vAzrkAaqoUPBON8sW6HfhTIZ 7bWeoLB1EgpVnnuFPT4aTIFHSGvGxNAgY5k4jVbrs7O/y4UE6oBVs56yq g==; X-IronPort-AV: E=McAfee;i="6600,9927,10947"; a="5238297" X-IronPort-AV: E=Sophos;i="6.04,182,1695711600"; d="scan'208";a="5238297" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2024 02:25:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,182,1695711600"; d="scan'208";a="30134895" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.165]) by orviesa001.jf.intel.com with ESMTP; 09 Jan 2024 02:25:11 -0800 Date: Tue, 9 Jan 2024 18:22:13 +0800 From: Xu Yilun To: Krzysztof Kozlowski Cc: Michal Simek , linux-kernel@vger.kernel.org, monstr@monstr.eu, michal.simek@xilinx.com, git@xilinx.com, Conor Dooley , Krzysztof Kozlowski , Moritz Fischer , Rob Herring , Tom Rix , Wu Hao , Xu Yilun , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , kishore Manne , "open list:FPGA MANAGER FRAMEWORK" Subject: Re: [PATCH 1/2] dt-bindings: fpga: Convert bridge binding to yaml Message-ID: References: <3100bbc4723643ec1ec7d4548e9ab353c856b564.1704470663.git.michal.simek@amd.com> <4bcac34b-72a0-464e-91cd-d9e924073619@amd.com> <3bfaab38-6831-41f8-8a7b-9f1f434e0f9c@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jan 09, 2024 at 09:16:33AM +0100, Krzysztof Kozlowski wrote: > On 09/01/2024 09:15, Krzysztof Kozlowski wrote: > >>>>>>> +properties: > >>>>>>> + $nodename: > >>>>>>> + pattern: "^fpga-bridge(@.*)?$" > >>>>>> > >>>>>> Not sure, but maybe we need to allow fpga-bridge-1? Could we have more > >>>>>> than one bridge on given system? > >>>>> > >>>>> Yilun: Any comment on this? > >>>> > >>>> We can have more bridges, but IIUC people use fpga-bridge@0, fpga-bridge@0 > >>>> to identify them. So the expression is OK to me. > >>> > >>> So you claim unit address thus reg with some sort of bus address is a > >>> requirement? Then "?" is not correct in that pattern. > >> > >> I expect it is about that people are using fpga-bridge@0 but bridge is not on > >> the bus. Yilun said that reg property in altr,socfpga-fpga2sdram-bridge.yaml is > >> optional which means no reg property no @XXX in node name. > >> That's why I think that expression is correct. If there are more bridges without > >> reg property then I expect we need to get more examples to align expression. > > > > If we allow node name without unit address, thus not being part of any This is valid usecase. > > bus, then the only question is whether it is possible to have system > > with more than two FPGA bridges. If the answer is "yes", which I think The answer is yes. > > is the case, then the pattern should already allow it: > > > > (@[0-9a-f]+|-[0-9]+)? > > Or better go with what I used recently for narrowed choices: > > (@.*|-([0-9]|[1-9][0-9]+))? It is good to me. I actually didn't know much about DTS & its Schema, thanks for all your input. > > Best regards, > Krzysztof > >