Received-SPF: pass (google.com: domain of linux-kernel+bounces-20741-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
	Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
	Kingdom.
	Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <ZZyCTPz+uuvgjPIL@casper.infradead.org>
References: <ZZyCTPz+uuvgjPIL@casper.infradead.org> <CAKXUXMzXN=+hKDPP-RdHKELA_fGA6PcdCj5fXM32qh4Px0Hprg@mail.gmail.com> <1542013.1704750095@warthog.procyon.org.uk>
To: Matthew Wilcox <willy@infradead.org>
Cc: dhowells@redhat.com, Lukas Bulwahn <lukas.bulwahn@gmail.com>,
    linux-cachefs@redhat.com,
    linux-fsdevel <linux-fsdevel@vger.kernel.org>,
    Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Reference to non-existing CONFIG_NETFS_FSCACHE
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1571879.1704798511.1@warthog.procyon.org.uk>
Date: Tue, 09 Jan 2024 11:08:31 +0000
Message-ID: <1571880.1704798511@warthog.procyon.org.uk>

Matthew Wilcox <willy@infradead.org> wrote:

> > netfs_writepages_begin() has the wait on the fscache folio conditional on
> > CONFIG_NETFS_FSCACHE - which doesn't exist.
> > 
> > Fix it to be conditional on CONFIG_FSCACHE instead.
> 
> Why is it conditional at all?  Why don't we have a stub function if
> CONFIG_FSCACHE is not defined?

At this point, I'd rather just change the #ifdef and then (hopefully) next
cycle get rid of PG_fscache entirely, rendering this unnecessary.

David