Received-SPF: pass (google.com: domain of linux-kernel+bounces-20771-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240108181610.2697017-1-leitao@debian.org> <20240108181610.2697017-2-leitao@debian.org>
In-Reply-To: <20240108181610.2697017-2-leitao@debian.org>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 9 Jan 2024 12:25:14 +0100
Message-ID: <CAMuHMdWqnTjHa6KW5g0F8xH50As4Ce+O3a2HaifJtnY1cGrFcQ@mail.gmail.com>
Subject: Re: [PATCH net-next 01/10] net: fill in MODULE_DESCRIPTION()s for 8390
To: Breno Leitao <leitao@debian.org>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, 
	pabeni@redhat.com, netdev@vger.kernel.org, Greg Ungerer <gerg@linux-m68k.org>, 
	Bagas Sanjaya <bagasdotme@gmail.com>, open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Breno,

On Mon, Jan 8, 2024 at 7:17=E2=80=AFPM Breno Leitao <leitao@debian.org> wro=
te:
> W=3D1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to all the good old 8390 modules and drivers.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>

Thanks for your patch!

> --- a/drivers/net/ethernet/8390/apne.c
> +++ b/drivers/net/ethernet/8390/apne.c
> @@ -610,4 +610,5 @@ static int init_pcmcia(void)
>         return 1;
>  }
>
> +MODULE_DESCRIPTION("National Semiconductor 8390 PCMCIA ethernet driver")=
;

I would write:

    National Semiconductor 8390 Amiga PCMCIA ethernet driver

as this driver does not work on generic platforms with a PCMCIA slot.

>  MODULE_LICENSE("GPL");

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds