Received-SPF: pass (google.com: domain of linux-kernel+bounces-20799-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 9 Jan 2024 12:44:55 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 4.19 4/7] Input: amimouse - convert to platform
 remove callback returning void
Message-ID: <ZZ0xt75z/qSf5f8V@duo.ucw.cz>
References: <20231226002649.7290-1-sashal@kernel.org>
 <20231226002649.7290-4-sashal@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="ICWHDsvhgHsBMFXU"
Content-Disposition: inline
In-Reply-To: <20231226002649.7290-4-sashal@kernel.org>


--ICWHDsvhgHsBMFXU
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> From: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
>=20
> [ Upstream commit 42b8ff47720258d1f6a4412e780a480c139773a0 ]
>=20
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>=20
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>=20
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.

We don't really need this for -stable.

Best regards,
								Pavel

> Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> Link: https://lore.kernel.org/r/20231201133747.1099286-2-u.kleine-koenig@=
pengutronix.de
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>

--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--ICWHDsvhgHsBMFXU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZZ0xtwAKCRAw5/Bqldv6
8lApAJ90gRzFv2cb+l/AmyogaG/yFFDLbQCeJVtEREvzO6XZuPRBE3RLj4L+nJ4=
=Nhy4
-----END PGP SIGNATURE-----

--ICWHDsvhgHsBMFXU--