Received-SPF: pass (google.com: domain of linux-kernel+bounces-20795-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 9 Jan 2024 12:43:27 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Mario Limonciello <mario.limonciello@amd.com>,
	Marcus Aram <marcus+oss@oxar.nl>,
	Mark Herbert <mark.herbert42@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>, Basavaraj.Natikar@amd.com,
	Shyam-sundar.S-k@amd.com, linux-gpio@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 4.14 3/6] pinctrl: amd: Mask non-wake source pins
 with interrupt enabled at suspend
Message-ID: <ZZ0xX2Mqx0ezfoWG@duo.ucw.cz>
References: <20231226002725.7471-1-sashal@kernel.org>
 <20231226002725.7471-3-sashal@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="KeQek5G0zUyG7eGC"
Content-Disposition: inline
In-Reply-To: <20231226002725.7471-3-sashal@kernel.org>


--KeQek5G0zUyG7eGC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> From: Mario Limonciello <mario.limonciello@amd.com>
>=20
> [ Upstream commit 2fff0b5e1a6b9c577b4dd4958902c877159c856b ]
>=20
> If a pin isn't marked as a wake source processing any interrupts is
> just going to destroy battery life.  The APU may wake up from a hardware
> sleep state to process the interrupt but not return control to the OS.
>=20
> Mask interrupt for all non-wake source pins at suspend. They'll be
> re-enabled at resume.

Not sure what is going on here, but it is queued for 6.6 and 4.14, but
not for the kernels between them.

Best regards,
								Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--KeQek5G0zUyG7eGC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZZ0xXwAKCRAw5/Bqldv6
8o46AJ47UWWyL/XjOcQ6g0+vVK2rsBFLLwCghMnwCem9B2AE6FtzLmho8/oPrUk=
=IPT6
-----END PGP SIGNATURE-----

--KeQek5G0zUyG7eGC--