Received-SPF: pass (google.com: domain of linux-kernel+bounces-20836-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 9 Jan 2024 13:15:20 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, bvanassche@acm.org,
	hch@lst.de, hare@suse.de, martin.petersen@oracle.com
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	torvalds@linux-foundation.org, stable@vger.kernel.org, lwn@lwn.net,
	jslaby@suse.cz
Subject: scsi_get_lba breakage in 5.10 -- Re: Linux 5.10.206
Message-ID: <ZZ042FejzwMM5vDW@duo.ucw.cz>
References: <2024010527-revision-ended-aea2@gregkh>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="MXcu7+91PUeNfjQF"
Content-Disposition: inline
In-Reply-To: <2024010527-revision-ended-aea2@gregkh>


--MXcu7+91PUeNfjQF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> I'm announcing the release of the 5.10.206 kernel.


> Martin K. Petersen (2):
>       scsi: core: Make scsi_get_lba() return the LBA

This is bad idea. This changes return value, but without fixing
callers; there will be subtle bugs somewhere.

At minimum, we need this:

87662a472a9d8980b26ba5803447df2c4981d467 scsi: iser: Use scsi_get_sector() =
instead of scsi_get_lba()

That will fix iser, but there's also:

drivers/s390/scsi/zfcp_fsf.c:           io->ref_tag_value =3D scsi_get_lba(=
scsi_cmnd) & 0xFFFFFFFF;
drivers/scsi/isci/request.c:            tc->ref_tag_seed_gen =3D scsi_get_l=
ba(scmd) & 0xffffffff;
drivers/scsi/isci/request.c:            tc->ref_tag_seed_verify =3D scsi_ge=
t_lba(scmd) & 0xffffffff;
drivers/scsi/lpfc/lpfc_scsi.c:  lba =3D scsi_get_lba(sc);
drivers/scsi/lpfc/lpfc_scsi.c:  reftag =3D (uint32_t)scsi_get_lba(sc); /* T=
runcate LBA */
drivers/scsi/lpfc/lpfc_scsi.c:  reftag =3D (uint32_t)scsi_get_lba(sc); /* T=
runcate LBA */
drivers/scsi/lpfc/lpfc_scsi.c:  reftag =3D (uint32_t)scsi_get_lba(sc); /* T=
runcate LBA */
drivers/scsi/lpfc/lpfc_scsi.c:  reftag =3D (uint32_t)scsi_get_lba(sc); /* T=
runcate LBA */
drivers/scsi/lpfc/lpfc_scsi.c:          start_ref_tag =3D (uint32_t)scsi_ge=
t_lba(cmd); /* Truncate LBA */
drivers/scsi/lpfc/lpfc_scsi.c:                          (unsigned long)scsi=
_get_lba(cmd),
drivers/scsi/lpfc/lpfc_scsi.c:                          (unsigned long)scsi=
_get_lba(cmd),
drivers/scsi/lpfc/lpfc_scsi.c:                          (unsigned long)scsi=
_get_lba(cmd),
drivers/scsi/lpfc/lpfc_scsi.c:                          (unsigned long long=
)scsi_get_lba(cmd),
drivers/scsi/lpfc/lpfc_scsi.c:                          (unsigned long long=
)scsi_get_lba(cmd),
drivers/scsi/lpfc/lpfc_scsi.c:                          (unsigned long long=
)scsi_get_lba(cmd),
drivers/scsi/lpfc/lpfc_scsi.c:                          (unsigned long long=
)scsi_get_lba(cmd),
drivers/scsi/lpfc/lpfc_scsi.c:                          (unsigned long long=
)scsi_get_lba(cmd),
drivers/scsi/lpfc/lpfc_scsi.c:          failing_sector =3D scsi_get_lba(cmd=
);
drivers/scsi/lpfc/lpfc_scsi.c:                          (unsigned long long=
)scsi_get_lba(cmd),
drivers/scsi/lpfc/lpfc_scsi.c:                                   (unsigned =
long long)scsi_get_lba(cmnd),
drivers/scsi/lpfc/lpfc_scsi.c:                                   (unsigned =
long long)scsi_get_lba(cmnd),
drivers/scsi/qla2xxx/qla_iocb.c:                    (0xffffffff & scsi_get_=
lba(cmd)));
drivers/scsi/qla2xxx/qla_iocb.c:                    (0xffffffff & scsi_get_=
lba(cmd)));
drivers/scsi/qla2xxx/qla_iocb.c:                    (0xffffffff & scsi_get_=
lba(cmd)));
drivers/scsi/qla2xxx/qla_isr.c:     cmd->cmnd[0], (u64)scsi_get_lba(cmd), a=
_ref_tag, e_ref_tag,
drivers/scsi/qla2xxx/qla_isr.c:         sector_t lba_s =3D scsi_get_lba(cmd=
);
include/scsi/scsi_cmnd.h:static inline sector_t scsi_get_lba(struct scsi_cm=
nd *scmd)

That needs to be fixed somehow. This may be quite critical due to data
corruption...?

Best regards,
										Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--MXcu7+91PUeNfjQF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZZ042AAKCRAw5/Bqldv6
8nutAJ9XN12LGj1gtySQhYo49aL6ZI3woACgtuWNLK74oIxA2iwhTXYN3Rgud5U=
=IrAN
-----END PGP SIGNATURE-----

--MXcu7+91PUeNfjQF--