Received-SPF: pass (google.com: domain of linux-kernel+bounces-20924-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: Frank Li <Frank.li@nxp.com>
CC: "imx@lists.linux.dev" <imx@lists.linux.dev>, Jingoo Han
	<jingoohan1@gmail.com>, Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	Manivannan Sadhasivam <mani@kernel.org>, Lorenzo Pieralisi
	<lpieralisi@kernel.org>, =?iso-8859-2?Q?Krzysztof_Wilczy=F1ski?=
	<kw@linux.com>, Rob Herring <robh@kernel.org>, Bjorn Helgaas
	<bhelgaas@google.com>, Jon Mason <jdmason@kudzu.us>, "open list:PCI DRIVER
 FOR SYNOPSYS DESIGNWARE" <linux-pci@vger.kernel.org>, open list
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] PCI: dwc: Fix BAR0 wrong map to iATU6 after root
 complex reinit endpoint
Thread-Topic: [PATCH 1/1] PCI: dwc: Fix BAR0 wrong map to iATU6 after root
 complex reinit endpoint
Thread-Index: AQHaMja1NResTHTkFE6//FhBs62b57CwYdiAgABGuYCAAAUWgIAg9AaA
Date: Tue, 9 Jan 2024 13:52:15 +0000
Message-ID: <ZZ1Pj3MvhQNMnP8M@x1-carbon>
References: <20231219044844.1195294-1-Frank.Li@nxp.com>
 <ZYFrUWM7JXdv7rtb@x1-carbon> <ZYGmpaf18pJgM/qj@lizhi-Precision-Tower-5810>
 <ZYGq6RdCfdhXFF/9@x1-carbon>
In-Reply-To: <ZYGq6RdCfdhXFF/9@x1-carbon>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?iso-8859-2?Q?QBHlkld7oW8MS8LovCvzmulxmtfhtvWqPib14t+Fwzm3er/T39FMsp7KGS?=
 =?iso-8859-2?Q?h4zUDZoKiaNYP4wSgwxginNZuLOOTtUTGiJAL4AlDA65LLtnM4N/9gv0VZ?=
 =?iso-8859-2?Q?dFBMPErV+wOoCkmPHTI2/toqx5C7n2/CFAfbChRPlel4UZ/U5B/wi6fqpv?=
 =?iso-8859-2?Q?aDFTpjIw+klsnRR4Nyx1etmcvyJFb8Nk5Ki6zBtb6iJ1TlwsFMEdktUkWx?=
 =?iso-8859-2?Q?4Tyn+un4N30KIKrHa9oFL0QrefarUGNA0F7PEm2U/h6w21Je0Tog4lgait?=
 =?iso-8859-2?Q?7myZTLfE/peHErkv5eaZymwjz3erHWVgNq3VLEEP+kpO7NWIo/ocMzQeWB?=
 =?iso-8859-2?Q?7i16iiVHZ6o1Or8XXct/4Ao5VbIe35Y832jvQnTiblMzX2fnjMQmG5xR9K?=
 =?iso-8859-2?Q?owfThT4gH8+HoEcqpNkXglUa1YeNFoO8UKu+IKb4m6qx46IXBMaTRO5eh5?=
 =?iso-8859-2?Q?O8QlAr4h7zfmHbILnIh9KxxNGjgzMs9hc6UBGSC1utvYTUzKSkUpkAxQJo?=
 =?iso-8859-2?Q?Dy+XyWcLwZ8bxRfUdu9dojgjg7A7Ap5nUW81hcYxA0R6oDlAjLDjb7N6K7?=
 =?iso-8859-2?Q?mjvP9LTqZdTelfdamN9Q78yaOtiKIev2AdwxzXZu+2afPQ27N6qLWLaCE3?=
 =?iso-8859-2?Q?DTBVvRxqs/hkAz/LyN3wjU3ijvN+Gvy2aFuUgEj1UCYvDdNLS16C+N+amZ?=
 =?iso-8859-2?Q?bjS9Z3037TkEX0iefkkBeTE41apTnzX5z/Ye2e4whdAOhh6Spe3VMkS8Mq?=
 =?iso-8859-2?Q?/pQE2XvWqUtRlbqXcAYnWt5YzEzDDoOCHxj1kyJO3P+dzsKzPzPClKkJ3i?=
 =?iso-8859-2?Q?eKlXuSBmKKOtS/73UA8M6xDZWixWV0TIThOfgfA7qxXxJSt5p4N+rHyUXC?=
 =?iso-8859-2?Q?OLEQv4DvEJBVzcJ4VeDBhophcv6QLnmmad6tT1NW5vXQSi+qL1xpX6iPlq?=
 =?iso-8859-2?Q?P5Q4x7aT5+BSjfsq3U0UhH2YeWfFZB/ljtQQh6Mc/Wpzazsiv37zRVhSR+?=
 =?iso-8859-2?Q?hqRuKYZb6G51oWhRLNNyu7VKtmv1cInUdamN08x679b28DiaoqssFIJoIU?=
 =?iso-8859-2?Q?WivoUEqyvlo7cymkYO5+bKVutKzbKBMHHj5vX+7LrMtJiOKq5ka8dNDw3o?=
 =?iso-8859-2?Q?YN9nNlM8Ulvu/umo1dd9hDseJsoGA2PZUzZpiryoHqVYQ38kwmz/y9DnxV?=
 =?iso-8859-2?Q?6ynZIhL60gl+rfGCfx0Th2c0qscIf0Lmn8r77V2z/7uiWlM9gR4eJcHfez?=
 =?iso-8859-2?Q?FIAn9fNc9EfrbMC6d1gC5cb6iY1Zss/ILskLfvTD271YDr0VNs+GTIcFba?=
 =?iso-8859-2?Q?0ODilIDnaChgceW8lXBU5UObB5m/Z/vM09+f8GbE3lepPqgsTq1c7NyoVU?=
 =?iso-8859-2?Q?PSChNm7HVnGtY9Yl2iAv0dYnUxNzNzslywOJ9G3jP2ZPwLQggcKmS60M7i?=
 =?iso-8859-2?Q?+dJhlNAWOiqj7OT+GYx6k6jHu+HJFrXcYopC4l3LIhE6El3pe53/d9gjel?=
 =?iso-8859-2?Q?H4gM3BRMQCXdIN8CDoDDLchOs0dsq7IbWVD/Uam0y5OqayKOI6xt6G4HSM?=
 =?iso-8859-2?Q?e6M+mjuKYnO3sfq83uXyfxSpVbtMp9MCRsFqwXulFMX9herHWSfqHIYnAM?=
 =?iso-8859-2?Q?NMfvZlw5604G1cMXXEcGkwoeec1ft+dWcu/DiVFXMXzFwzc6WIDzrkfw?=
 =?iso-8859-2?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-2"
Content-ID: <B924B9DB8537DB4FA7ECCB6C7A492DC0@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	/EJSEnrmtCSdSOip64UxF+5+m8RWFLlObs0gqjOAlngrDOGNFXYoBHWvKB042xiIdE7Teaiy/fw8Q/GsFUB8PW4ZFr+vfrK+Nz9jhIMFw8ibluJtcxL20KzBal0wrzksm7QxH/wNxL7QrS59t2p8Pu0QOc0+5MBliUWPStKziUodwauWa3VCbVfa6GPmyWTt3u7N3ZCtoNLNGdvFusCcj5KeDJn/vb2cWZgNMwSdHDfM/ridxbUJTnv9Uys+YKkvvp4EyUVDNeBex0/n4ef+Uq9P1Fst0KtDcTiMMFO1UVN6Z8psBl64u2QNNnLKeduYwY+4Qnk+jrFjcTh5yfcTbkRFDNrLDtoo3nizz9+Jf9t/jvKBvYnD/mrmVhe6EmM6LAgA2yaG/7NTr5GRGH2pWqlgkDaah7gKzigh+DwBZp067x5lWCqyY9wjEXVspRsl3lE52FVBne9auLqpXrcHriPKs+hGyjRVL0w423map4ml/NfSynHDlrBIcjJf+Z0JIvrbj7pjmbw45bb2N+MMdalHlDj/DX6TvP05GUNrjB/AoRH1wAuPjwrUPLC2FmTrSJb7k7iIaYy+7/QdALKwhMt5yaRCAZwBY3PSrX1Mdh45xggv9XZCXir+E7/JxcJ4
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR04MB4850.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d4b3a9d8-f187-40a0-d19e-08dc111a3069
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2024 13:52:15.8462
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FBOPT2WJX56KB8wS0tG4Rl7sK79pSR9ByKxUufDe174sArhD3n5r+BOfvylNBmUMa3MLhJmEXTK9XBbAqqBEwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR04MB8925

Hello Frank,

On Tue, Dec 19, 2023 at 03:38:33PM +0100, Niklas Cassel wrote:
> On Tue, Dec 19, 2023 at 09:20:21AM -0500, Frank Li wrote:
> > On Tue, Dec 19, 2023 at 10:07:14AM +0000, Niklas Cassel wrote:
> > > On Mon, Dec 18, 2023 at 11:48:43PM -0500, Frank Li wrote:
> > > > dw_pcie_ep_inbound_atu()
> > > > {
> > > > 	...
> > > > 	if (!ep->bar_to_atu[bar])
> > > > 		free_win =3D find_first_zero_bit(ep->ib_window_map, pci->num_ib_w=
indows);
> > > > 	else
> > > > 		free_win =3D ep->bar_to_atu[bar];
> > > > 	...
> > > > }
> > > >=20
> > > > The atu index 0 is valid case for atu number. The find_first_zero_b=
it()
> > > > will return 6 when second time call into this function if atu is 0.=
 Suppose
> > > > it should use branch 'free_win =3D ep->bar_to_atu[bar]'.
> > > >=20
> > > > Change 'bar_to_atu' to s8. Initialize bar_to_atu as -1 to indicate =
it have
> > > > not allocate atu to the bar.
> > > >=20
> > > > Reported-by: Niklas Cassel <Niklas.Cassel@wdc.com>
> > > > Close: https://lore.kernel.org/linux-pci/ZXt2A+Fusfz3luQV@x1-carbon=
/T/#u
> > > > Fixes: 4284c88fff0e ("PCI: designware-ep: Allow pci_epc_set_bar() u=
pdate inbound map address")
> > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > ---
> > > >=20
> > > > Notes:
> > > >     @Niklas:
> > > >     	I have not test your case. I should be equal to previous's fix=
 in
> > > >     mail list.
> > >=20
> > > Hello Frank,
> > >=20
> > > Thank you for sending a proper fix for this!
> > >=20
> > > Personally, I slightly prefer your fix that saves the iatu index + 1,=
 and
> > > keeps 0 to mean unused. That way, you don't need the memset, and you =
don't
> > > need to change the type to signed, but either way is fine by me, so:
> >=20
> > index + 1 don't match hardware iATU index. It will be confused because
> > other parts is 0 based.
> >=20
> > So I choose "-1" as free iATU.
>=20
> A s8 can hold a max value of 127.
> CX_ATU_NUM_OUTBOUND_REGIONS seems to be 0-255.
>=20
> Since the DWC code can be synthesized with 256 iATUs,
> your code will not work on systems with 128 or more iATUs.
>=20
> If we continue to use a u8, and offset the saved value by one,
> we will at least be able to support 255-1 =3D=3D 254 iATUs.

Do you plan to send out a v2?


Kind regards,
Niklas=