Received-SPF: pass (google.com: domain of linux-kernel+bounces-20926-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240105181118.116292-1-erick.archer@gmx.com> <b12b56a9-2d20-4802-bbc8-43f4831b3113@embeddedor.com>
In-Reply-To: <b12b56a9-2d20-4802-bbc8-43f4831b3113@embeddedor.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Tue, 9 Jan 2024 14:57:29 +0100
Message-ID: <CAJZ5v0iXindsbwBJsiknXxLrq=94rq3p=H_ux2pGpqzmjyRWkA@mail.gmail.com>
Subject: Re: [PATCH] PM / QOS: Use kcalloc() instead of kzalloc()
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>, Erick Archer <erick.archer@gmx.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Gustavo A. R. Silva" <gustavoars@kernel.org>, 
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, 
	linux-hardening@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 5, 2024 at 7:17=E2=80=AFPM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
>
>
>
> On 1/5/24 12:11, Erick Archer wrote:
> > Use 2-factor multiplication argument form kcalloc() instead
> > of kzalloc().
> >
> > Link: https://github.com/KSPP/linux/issues/162
> > Signed-off-by: Erick Archer <erick.archer@gmx.com>
>
> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>

Applied as 6.8-rc1 material, thanks!

> > ---
> >   drivers/base/power/qos.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/base/power/qos.c b/drivers/base/power/qos.c
> > index 8e93167f1783..bd77f6734f14 100644
> > --- a/drivers/base/power/qos.c
> > +++ b/drivers/base/power/qos.c
> > @@ -201,7 +201,7 @@ static int dev_pm_qos_constraints_allocate(struct d=
evice *dev)
> >       if (!qos)
> >               return -ENOMEM;
> >
> > -     n =3D kzalloc(3 * sizeof(*n), GFP_KERNEL);
> > +     n =3D kcalloc(3, sizeof(*n), GFP_KERNEL);
> >       if (!n) {
> >               kfree(qos);
> >               return -ENOMEM;
> > --
> > 2.42.0
> >
> >