Received-SPF: pass (google.com: domain of linux-kernel+bounces-20951-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <d927b0b761eb7105d2193d9dca48f2c6df8868b7.camel@gmail.com>
Subject: Re: [PATCH] iio: core: use INDIO_ALL_BUFFER_MODES in
 iio_buffer_enabled()
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: David Lechner <dlechner@baylibre.com>, Jonathan Cameron
 <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Tue, 09 Jan 2024 15:07:57 +0100
In-Reply-To: <20240108200647.3916681-1-dlechner@baylibre.com>
References: <20240108200647.3916681-1-dlechner@baylibre.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-01-08 at 14:06 -0600, David Lechner wrote:
> This replaces use of individual buffer mode flags with
> INDIO_ALL_BUFFER_MODES in the iio_buffer_enabled() function.
>=20
> This simplifies the code and makes it robust in case of the addition of
> new buffer modes.
>=20
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---

LGTM,
Reviewed-by: Nuno Sa <nuno.sa@analog.com>

> =C2=A0drivers/iio/industrialio-core.c | 4 +---
> =C2=A01 file changed, 1 insertion(+), 3 deletions(-)
>=20
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-c=
ore.c
> index c77745b594bd..8855d377d710 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -210,9 +210,7 @@ bool iio_buffer_enabled(struct iio_dev *indio_dev)
> =C2=A0{
> =C2=A0	struct iio_dev_opaque *iio_dev_opaque =3D to_iio_dev_opaque(indio_=
dev);
> =C2=A0
> -	return iio_dev_opaque->currentmode &
> -	=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (INDIO_BUFFER_HARDWARE | INDIO_BUF=
FER_SOFTWARE |
> -		INDIO_BUFFER_TRIGGERED);
> +	return iio_dev_opaque->currentmode & INDIO_ALL_BUFFER_MODES;
> =C2=A0}
> =C2=A0EXPORT_SYMBOL_GPL(iio_buffer_enabled);
> =C2=A0