Received-SPF: pass (google.com: domain of linux-kernel+bounces-20990-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <5cdd1385-e2cf-4280-a31a-27e15a927b10@prevas.dk>
Date: Tue, 9 Jan 2024 15:33:55 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v9 2/2] arm64: boot: Support Flat Image Tree
Content-Language: en-US, da
To: Masahiro Yamada <masahiroy@kernel.org>, Chen-Yu Tsai <wenst@chromium.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Simon Glass <sjg@chromium.org>, linux-arm-kernel@lists.infradead.org,
 Ahmad Fatoum <a.fatoum@pengutronix.de>,
 U-Boot Mailing List <u-boot@lists.denx.de>,
 Nicolas Schier <nicolas@fjasle.eu>, Tom Rini <trini@konsulko.com>,
 Catalin Marinas <catalin.marinas@arm.com>, Jonathan Corbet <corbet@lwn.net>,
 Nathan Chancellor <nathan@kernel.org>, Nick Terrell <terrelln@fb.com>,
 Will Deacon <will@kernel.org>, linux-doc@vger.kernel.org,
 linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
 workflows@vger.kernel.org
References: <20231202035511.487946-1-sjg@chromium.org>
 <20231202035511.487946-3-sjg@chromium.org>
 <20231203153401.GV8402@pendragon.ideasonboard.com>
 <20231207142723.GA3187877@google.com>
 <20231207143814.GD15521@pendragon.ideasonboard.com>
 <CAGXv+5Go_0pEVAOLQmRCc_a9-YUtZEmBfXtMuBupX_nb9iqwbw@mail.gmail.com>
 <20231209152946.GC13421@pendragon.ideasonboard.com>
 <CAMuHMdVMZs6mnwWBgFwktO=8o=QzROv60cfZe085MhD6HxQjpQ@mail.gmail.com>
 <CAGXv+5Est3FL-XcEL-vB-6zVNas0mqb2cNYa==Yb7W2SQU9xVQ@mail.gmail.com>
 <CAK7LNATyD-PeNbaLTjJmU9=koqqE+V6QvFe09c2VrXopWvjpcw@mail.gmail.com>
 <CAK7LNAR7Fm-1yaZmyH78vG5yNbbW2Avjj5F63u+aST6JQoMd5A@mail.gmail.com>
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
In-Reply-To: <CAK7LNAR7Fm-1yaZmyH78vG5yNbbW2Avjj5F63u+aST6JQoMd5A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VytqUkp2UWRZV0ltVkhUSVJBaFRhOXNIODZFNENDU3MxS3ZNSzcvMXBhVUFM?=
 =?utf-8?B?K1czVGdqbkFETEtCSk95bDlvb1cwQTdxcFA5NDhlaEpLVUZZNFhubGpvZWov?=
 =?utf-8?B?cWY1bG9xMzYxQkl1MS92Rytmb3VYajhIeDg5NzN6OXBHS0xMeS9PZXUydExu?=
 =?utf-8?B?QjJpdWJHT0M0TEhYeHFYTXhDV24venhGUlFTWTN0QVkwRE8rWFdaOUF1RXlV?=
 =?utf-8?B?OHVKbDN1OGJHUU83RTY3aE5xVVh2MDRPMW43MXJ0VHBrQXAyNU9lNWhoVFJv?=
 =?utf-8?B?Y1JBam9qYm5NUW95U1p3SWIzOHY0SU9CVzhYMnBsMlVKWjhjQVJBS0xwVlBp?=
 =?utf-8?B?U0ZKeEhXZEVFSjQrWmg4S25nM1JETlVFUHFHU0JOZjJyMUZaT3pBK1pxbXFj?=
 =?utf-8?B?RzNTS2N2MFk3VUVpeldJamJkZzZrM1NxY20wUFI2K0ZZd2FtSXdFdHgydnpH?=
 =?utf-8?B?ajIvY1k3dHlVL0t0Y2ZGc2NOeGIwRk5DSG55c1JJY0xVUmNGUlRVWnlZeGt2?=
 =?utf-8?B?RFhPcTRKU1QzRUZzKy9UcS8wRE9LT0QyZDJIbXZlN29TeFJjSWlUa1lpYnYw?=
 =?utf-8?B?cWE0ancwM2FiUmIvY1dzNit3U3ZZNGV2WTlvaTN3Q2VnUjlUTFdwWVpHU1BV?=
 =?utf-8?B?clVnTGpESzBpRFlBZVBPMkJtMjJzVyt5dHBnZTh0R1AySTBuZ1A5WDNzUW9s?=
 =?utf-8?B?RXNaZTNjWENocEovc21BWTR1alpydFAvcGREaDQ4bVk1aG12eTVMU3FjL1F6?=
 =?utf-8?B?bGlkdGNxT251QVZXMFY3bEdxS1U4b1d1cVp1MEhMSHV5SWVqNnV5aHhuNEg1?=
 =?utf-8?B?UENjaDVGLzIyQ2hHN0JIc2VsTHNRMUpSejQ5ME1vSmRuL2JxUXJCdlhERzZx?=
 =?utf-8?B?bk1KcFRQLy95WVEvVGhIQ3p6blFRbVV3QjQ3c0lpSWxWRUU1dlhvUWpLN2xu?=
 =?utf-8?B?c1pyaFp2RG84OGl1ZmR1SWRTMnN2T1VockJaNlJ4blFqcXQ1U0NCQlFIOUg3?=
 =?utf-8?B?aXFxN0U0SjZ0dFpSNkRaK0ZsVSs4a2xpNy9VUzBQa1ZoeFNFbCt0U2gycnoy?=
 =?utf-8?B?WkxjNW5VOU5EYVZZY2FIZkJQblpQaThYTU53NSthWnR2NVcxV0NDT29XeEhI?=
 =?utf-8?B?MlhYaUw4c2FnWXVBY0t5ZTBQUXJqZXVjRWRFNGV5MHN2Q0tuY3BkMnZYeVZG?=
 =?utf-8?B?TkZUVEMxQWdrelIyQzZOeExxQ05PelFRMFdPQ1h3Z1RDUlArTmZVZ01Zc2NS?=
 =?utf-8?B?anZHN3J5bWxLVUZJRi9QdnVKR2pyeGVJZStXb09QRG5JcHRaSjR3ZXJzZkU1?=
 =?utf-8?B?RnNhS3N1SmZqREV5djdUSTQxQmk1ekl1ZGpKOXEweXNjRzM0TkNRMUdScXVt?=
 =?utf-8?B?UDUyeXY1cFBWeStQZWQ2eksxWHE0M1dsdlg1dGJBWEJESnRGUUZoWkFVbS9V?=
 =?utf-8?B?UWN4K0pIVFhZS05KZ1B4amNRZ0d5ckJRN3I0aUJtL1NEMnJtdktXaEVrOHpB?=
 =?utf-8?B?c2pmVm9Td0tTS2pRQ3ZyQ0ZyeVgycUxEU2JoRDE4dDdiZ09uT0N3bTdMNzJF?=
 =?utf-8?B?clkzaEMwSVhkMmNCWHowQjZFVzBvY0VrZDdaQXR1UVVHYndXTEw3dVFMM0hq?=
 =?utf-8?B?L3dTVVUvSDhVbEd1UUxNVkpHanhhVy9PV3o1UVlZNWdtNEs1RTQxTjdZZDcz?=
 =?utf-8?B?ejVjMzJJZXE3ZG5Jb1ZkZkxNc1VHTFgrZVgzRWtkMkxhNXN1eE0rOXF2VzRv?=
 =?utf-8?B?bE1henExT3YxbVdGaGt1UHVZMy9CaytGZmpObWxCUmxEdWNvUTJNb3FWTXlS?=
 =?utf-8?B?U1JCbWJFR3FJNVZzN0l2aExGdlZQR2hYbVBYdlA4MWh1Umw4Q21mZjR6R0xt?=
 =?utf-8?B?Vkpxby9ROUYvVzBUbFdIWUFBMG1JTm5hdW5McWV6a2lESUZ0OGxVc1ZuR1lu?=
 =?utf-8?B?WkIzUmRnb0FiWk5KUFU3VXBzWlE3VVYvNWhJWEg3anJvcnc2cnhrYUpLZ2g4?=
 =?utf-8?B?dDMxbDVuWW5PTEVWNzQwdGtWcjVnQkpaZzh0MjE3dzU0a0RWZWEwclZraDVR?=
 =?utf-8?B?eGpPa21hMUlkZSsxb0dmVWN2QVltSi8xNG9yWlBpUklXZk1naGtBTmFZcVJV?=
 =?utf-8?B?bzZSWWhobURTaWRJeTF5ZHkybnV3S3kxbUY0V3ZkQjNKSVdsSlBoU043UGpz?=
 =?utf-8?B?NXc9PQ==?=
X-OriginatorOrg: prevas.dk
X-MS-Exchange-CrossTenant-Network-Message-Id: a0977f1e-bf57-422e-1f40-08dc1120042b
X-MS-Exchange-CrossTenant-AuthSource: DB9PR10MB7100.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2024 14:33:58.7841
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TAnCxOSV/2sBlF5VzTkCZukbNauO/eIB5WsdTFKoQlpZq2FjjvziEKoYxaecGWnQBJhgyc7+CU+dWru2yH1T+Ls4IDFPwca/KCQKZKZmS/U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR10MB3901

On 14/12/2023 08.33, Masahiro Yamada wrote:
> On Thu, Dec 14, 2023 at 3:12 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>>

> One more question to confirm if I can use this
> for my practical use-cases.
> 
> Is U-Boot able to handle FIT (includes kernel + DTs)
> and a separate initrd?
> 
>   # bootm  <fit-address>:<conf-name>  <ramdisk-address>
> 
> 
> Presumably, it would be difficult to inject initramdisk
> into image.fit later, so I am hoping bootm would work like that,
> but I did not delve into U-Boot code.

I recently had occasion to use this, and it actually already works
out-of-the-box, but perhaps it could be better documented. Though you
need not only the ramdisk address but also the size, as in
<addr>:<size>, and of course CONFIG_SUPPORT_RAW_INITRD.

My use case is bootstrapping: I have one FIT image (consisting of
kernel, dtbs and an initramfs) which is the one that will be written to
the target. But for bootstrapping, I (obviously) need to boot with a
different initramfs that contains the bootstrap logic. Since this
project uses fastboot, what I do is: upload the alternative initramfs,
move it out of the way ('cause fastboot only supports one single target
buffer), upload the FIT image, and "bootm $fitaddr $initrdaddr:$initrdsize".

> If it works, is it possible to verify the integrity of initrd?

No, I don't think so. In my case the FIT image is signed, and the kernel
and chosen dtb does get verified, but not the contents of the initrd.
I'm not sure how that should happen - in any case, in the fastboot case,
the host can run arbitrary shell commands so not much U-Boot can do.

Rasmus