Received-SPF: pass (google.com: domain of linux-kernel+bounces-21082-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <960ea567-eed5-4908-a3ad-82add0c6f26c@quicinc.com>
Date: Tue, 9 Jan 2024 21:22:17 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: "Maulik Shah (mkshah)" <quic_mkshah@quicinc.com>
Subject: Re: [PATCH] arm64: dts: qcom: qcm6490: Update PSCI suspend param for
 cluster sleep
To: Konrad Dybcio <konrad.dybcio@linaro.org>, <agross@kernel.org>,
        <andersson@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <luca.weiss@fairphone.com>, <cros-qcom-dts-watchers@chromium.org>
CC: <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <quic_lsrao@quicinc.com>
References: <20240105070223.11415-1-quic_mkshah@quicinc.com>
 <9e79a460-9a1d-493c-a430-63c416e3d992@linaro.org>
Content-Language: en-US
In-Reply-To: <9e79a460-9a1d-493c-a430-63c416e3d992@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

On 1/5/2024 3:35 PM, Konrad Dybcio wrote:
> On 5.01.2024 08:02, Maulik Shah wrote:
>> QCM6490 uses Trustzone as firmware whereas SC7280 uses arm trusted
>> firmware. The PSCI suspend param is different in Trustzone for cluster
>> sleep. Update the same for qcm6490 based idp and fairphone fp5 boards.
>>
>> Signed-off-by: Maulik Shah <quic_mkshah@quicinc.com>
>> ---
> 
> Nice spot!
> 
> For things that are chrome-specific, I'd prefer them to be moved to
> -chrome.dtsi and then the "normal" (LA+LE+WP+friends) values to
> stay as default.

Thanks for the review.
Moved the chrome specific changes to sc7280-chrome-common.dtsi in v2.

> 
>>   arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 4 ++++
>>   arch/arm64/boot/dts/qcom/qcm6490-idp.dts           | 4 ++++
>>   2 files changed, 8 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
>> index 176898c9dbbd..b56f6f26d96f 100644
>> --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
>> @@ -446,6 +446,10 @@
>>   	};
>>   };
>>   
>> +&CLUSTER_SLEEP_0 {
>> +	arm,psci-suspend-param = <0x4100b344>;
>>
> 
> I think the residency times should also be updated here.
> 
> Moreover, I'm seeing additional sleep states here (APSS PC, CX RET
> and this one being AOSS SLEEP), with values 0x4<<4, 0x134<<4,
> 0xb34<<4 (the one you added here) respectively.
> 
> Could you please add them as well, similar to [1]?
> 
> Konrad
> 
> [1] https://lore.kernel.org/linux-arm-msm/20230619-topic-sc8280xp-idle-v2-1-cde50bf02f3c@linaro.org/

Sure, added additional sleep stats with updated residency time in v2.

Thanks,
Maulik