Received-SPF: pass (google.com: domain of linux-kernel+bounces-21099-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <65b4168f-f9cd-45dc-a712-d5daabc9dbda@linaro.org>
Date: Tue, 9 Jan 2024 16:16:41 +0000
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] arm64: irq: include <linux/cpumask.h>
Content-Language: en-US
To: Mark Rutland <mark.rutland@arm.com>
Cc: catalin.marinas@arm.com, will@kernel.org, sumit.garg@linaro.org,
 dianders@chromium.org, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org, kernel-team@android.com,
 andre.draszik@linaro.org, willmcvicker@google.com, peter.griffin@linaro.org
References: <20240109140437.3703330-1-tudor.ambarus@linaro.org>
 <ZZ1cRnjNlryrqAL0@FVFF77S0Q05N.cambridge.arm.com>
From: Tudor Ambarus <tudor.ambarus@linaro.org>
In-Reply-To: <ZZ1cRnjNlryrqAL0@FVFF77S0Q05N.cambridge.arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 1/9/24 14:46, Mark Rutland wrote:
> On Tue, Jan 09, 2024 at 02:04:37PM +0000, Tudor Ambarus wrote:
>> Sorting include files in alphabetic order in
>> drivers/tty/serial/samsung.c revealed the following error:
>>
>> In file included from drivers/tty/serial/samsung_tty.c:24:
>> ./arch/arm64/include/asm/irq.h:9:43: error: unknown type name 'cpumask_t'
>>     9 | void arch_trigger_cpumask_backtrace(const cpumask_t *mask, int exclude_cpu);
>>       |                                           ^~~~~~~~~
>>
>> Include cpumask.h to avod unknown type errors for parents of irq.h that
>> don't include cpumask.h.
> 
> s/avod/avoid/

ah, will fix, thanks.

> 
>> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
>> ---
>>  arch/arm64/include/asm/irq.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/include/asm/irq.h b/arch/arm64/include/asm/irq.h
>> index 50ce8b697ff3..d5612bc770da 100644
>> --- a/arch/arm64/include/asm/irq.h
>> +++ b/arch/arm64/include/asm/irq.h
>> @@ -5,6 +5,7 @@
>>  #ifndef __ASSEMBLER__
>>  
>>  #include <asm-generic/irq.h>
>> +#include <linux/cpumask.h>
> 
> Minor nit: we usually have the <linux/*.h> headers first, then a line space,
> then the <asm/*.h> headers, e.g.

I wasn't aware of this habit. Will update accordingly in v2.

Thanks!
ta