Received-SPF: pass (google.com: domain of linux-kernel+bounces-21142-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <24039c50-9079-4ca5-b7b0-867c64d70630@linux.ibm.com>
Date: Tue, 9 Jan 2024 12:02:23 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] s390/vfio-ap: handle response code 01 on queue reset
Content-Language: en-US
To: Halil Pasic <pasic@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, jjherne@linux.ibm.com, alex.williamson@redhat.com,
        borntraeger@linux.ibm.com, kwankhede@nvidia.com, frankja@linux.ibm.com,
        imbrenda@linux.ibm.com, david@redhat.com
References: <20231129143529.260264-1-akrowiak@linux.ibm.com>
 <20231204131045.217586a3.pasic@linux.ibm.com>
 <7c0d0ad2-b814-47b1-80e9-28ad62af6476@linux.ibm.com>
 <20231204230529.07bf7b79.pasic@linux.ibm.com>
From: Anthony Krowiak <akrowiak@linux.ibm.com>
In-Reply-To: <20231204230529.07bf7b79.pasic@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 12/4/23 5:05 PM, Halil Pasic wrote:
> On Mon, 4 Dec 2023 12:51:49 -0500
> Tony Krowiak <akrowiak@linux.ibm.com> wrote:
>
>>> s/if\/when/at latest before/
>>>
>>> I would argue that some of the cleanups need to happen before even 01 is
>>> reflected...
>> To what cleanups are you referring?
> Event notification and interruption disablement for starters. Otherwise
> OS has no way to figure out when is GISA and NIB safe to deallocate.
> Those actions are part of the reset process. I.e. some of the reset stuff
> can be deferred at most until the queue is made accessible again, some
> not so much.


How do you propose we disable interrupts if the PQAP(AQIC) will likely 
fail with response code 01 which is the subject of this patch? Do you 
think we should not free up the AQIC resources as we do in this patch?


>   
>
> Regards,
> Halil