Received-SPF: pass (google.com: domain of linux-kernel+bounces-21147-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 9 Jan 2024 17:11:41 +0000
From: Conor Dooley <conor@kernel.org>
To: Ninad Palsule <ninad@linux.ibm.com>
Cc: peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca,
	Joel Stanley <joel@jms.id.au>, linux-integrity@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] tpm: tis-i2c: Add more compatible strings
Message-ID: <20240109-saddling-nintendo-c7fbb46bb0dd@spud>
References: <20231214144954.3833998-1-ninad@linux.ibm.com>
 <20231214144954.3833998-2-ninad@linux.ibm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="ZxiYjKSulZMuNBQt"
Content-Disposition: inline
In-Reply-To: <20231214144954.3833998-2-ninad@linux.ibm.com>


--ZxiYjKSulZMuNBQt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 14, 2023 at 08:49:53AM -0600, Ninad Palsule wrote:
> From: Joel Stanley <joel@jms.id.au>
>=20
> The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface.
>=20
> https://www.nuvoton.com/products/cloud-computing/security/trusted-platfor=
m-module-tpm/
>=20
> Add a compatible string for it, and the generic compatible.
>=20
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
> Link: https://lore.kernel.org/r/20220928043957.2636877-4-joel@jms.id.au
> Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>

I don't understand why you broke this series up and dropped patches.
NAK, these compatibles are not documented.

Cheers,
Conor.

> ---
>  drivers/char/tpm/tpm_tis_i2c.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2=
c.c
> index a897402cc36a..9511c0d50185 100644
> --- a/drivers/char/tpm/tpm_tis_i2c.c
> +++ b/drivers/char/tpm/tpm_tis_i2c.c
> @@ -383,6 +383,8 @@ MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_id);
>  #ifdef CONFIG_OF
>  static const struct of_device_id of_tis_i2c_match[] =3D {
>  	{ .compatible =3D "infineon,slb9673", },
> +	{ .compatible =3D "nuvoton,npct75x", },
> +	{ .compatible =3D "tcg,tpm-tis-i2c", },
>  	{}
>  };
>  MODULE_DEVICE_TABLE(of, of_tis_i2c_match);
> --=20
> 2.39.2
>=20

--ZxiYjKSulZMuNBQt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZZ1+TAAKCRB4tDGHoIJi
0m0QAPoD8jO8sBqNJ8Yjtkt0nD8c8slMnCPmNUOEQCd+wj5foAD/Rm9ZJAaubHBn
0nZRgQCZxzJ4E/TTJamUTHT07B5MXgg=
=YR2U
-----END PGP SIGNATURE-----

--ZxiYjKSulZMuNBQt--