Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp463226rdd; Tue, 9 Jan 2024 09:17:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IHuarOWSt01bXzVr+7MQcRxK5EjRqR9SHYnYv5kAp71yuEaVccI/hLCSD4Q9YuJ2fc6NaJ0 X-Received: by 2002:a17:907:ea2:b0:a28:46fe:77f1 with SMTP id ho34-20020a1709070ea200b00a2846fe77f1mr574251ejc.179.1704820677518; Tue, 09 Jan 2024 09:17:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704820677; cv=none; d=google.com; s=arc-20160816; b=NTa8GF//LBAIK93dQj6xN8yKSoUI2GzFWShRuBxUSacq0d0rJAnlQ6qhynwnDiDEeF vHIcAF4u0L9SnrLDPumMixtd+QTHaKr62I7YLYfmFr9kCRIrLZgUwG0BCxhbXxl6966e TOw2DSCXSYgL2EbvkLKV26L9Dasov4IByWf54Hgpg14UFCx/Rwk9a6rMNg1PEc/yxc0v /lqLIT2mcpWI5W3athgfnGM7HrsvMIjM83tOus0ypy1jcBE/pvLwTtLz1jRe70IeV7ef pAs4rYC5P84QfFTZj1CXFGbGwA6N74O1gubNRIQpjbdhDRdKn8J2zTHQxo8pPiLCXq8R W4jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=jV5sBgRDNu0jqlEKxdKAuzLgXQn6pQLf1bpsyvz2xDc=; fh=HYECKfrZhWXyv2Spj7+uldD5Fwsjk/aMT8fV4R75D1Y=; b=iGfsndFtUexbAzbwPvqMqPq7k6E++auItEDhi3Hzub3KW3OBh9UP5yk8jnGLFo2Mgx 8VEbRhrHMsZ9dRWCa8ntGBMqkjyhmk2NUZq5kQ4wgGlA7sgqOtceL8VTqJ3pQEG3PrN3 j+blOj/ltk5jfQR9GZEMhLxW9VsO/G9g7+mn7FlEX1StrZA5zH9375mIYepv1HRuWYu1 6bXskr9M4rgt+3JZyM020jOo9ygt3an1AF9aJ/XpoTUTzk9A6gnVQEHJC9GjJrEM0e78 VqQMdf5bYL6H/8wPEEkNsydZWme8rVUJDwGJAsXag05ZwTX6SMkkVlmKpfqVfm4fNziT Gm+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=azLjjcxU; spf=pass (google.com: domain of linux-kernel+bounces-21154-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-21154-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id h3-20020a1709066d8300b00a29f3587869si991166ejt.1016.2024.01.09.09.17.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 09:17:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-21154-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=azLjjcxU; spf=pass (google.com: domain of linux-kernel+bounces-21154-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-21154-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3DEE51F2478E for ; Tue, 9 Jan 2024 17:17:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A78E83A8F7; Tue, 9 Jan 2024 17:17:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="azLjjcxU" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFADD3A8C7 for ; Tue, 9 Jan 2024 17:17:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75D01C433F1; Tue, 9 Jan 2024 17:17:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704820668; bh=D7KV1IGnrkXqUutExUdjibJpcr5iZJVE7kOMwjqDBjE=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=azLjjcxUBJVJs7dVbTFf3s2B/YPVpZUMPF1PMrVOIKcwVqKJe7cgvbGjceH/bEGlA /J6c6wUifbb5lI4ZysV8Q1FuSKZwhVzo12gYZZJGNd22juu+sPubMRu22n4FPmQ5SQ KqLMmX730gSn4lkOXB8KXSAOolWrywFMlpDuN3rNvWuRcNwZMQn9NViWf3NzazXdL+ +sM/MCqVH03g6D3Yi6pVLIyCCuSAo+uotxLD0HWuh0CcGqgZ/iipTnhxzUPCpb/aR1 B5E3Hde7t3CeIa/CdRy5l2udRn8IRTKk/OFTG+Jo4pCU0T2bOFZ2sa7FdXolXA6c+6 MGZDeCmhSZOHw== From: Robert Foss To: linux-kernel@vger.kernel.org, xiazhengqiao , dri-devel@lists.freedesktop.org Cc: allen.chen@ite.corp-partner.google.com, dianders@google.com, neil.armstrong@linaro.org, sam@ravnborg.org, hsinyi@google.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, andrzej.hajda@intel.com, Laurent.pinchart@ideasonboard.com In-Reply-To: <20231221093057.7073-1-xiazhengqiao@huaqin.corp-partner.google.com> References: <20231221093057.7073-1-xiazhengqiao@huaqin.corp-partner.google.com> Subject: Re: [PATCH RESEND] drm/bridge: Fixed a DP link training bug Message-Id: <170482066511.1300150.1577752604987496736.b4-ty@kernel.org> Date: Tue, 09 Jan 2024 18:17:45 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.10.1 On Thu, 21 Dec 2023 17:30:57 +0800, xiazhengqiao wrote: > To have better compatibility for DP sink, there is a retry mechanism > for the link training process to switch between different training process. > The original driver code doesn't reset the retry counter when training > state is pass. If the system triggers link training over 3 times, > there will be a chance to causes the driver to use the wrong training > method and return a training fail result. > > [...] Applied, thanks! [1/1] drm/bridge: Fixed a DP link training bug https://cgit.freedesktop.org/drm/drm-misc/commit/?id=ca077ff8cac5 Rob