Received-SPF: pass (google.com: domain of linux-kernel+bounces-21255-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 9 Jan 2024 12:24:42 -0600
From: Rob Herring <robh@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de, bhelgaas@google.com, imx@lists.linux.dev, manivannan.sadhasivam@linaro.org, s.hauer@pengutronix.de, krzysztof.kozlowski@linaro.org, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, l.stach@pengutronix.de, conor+dt@kernel.org, linux-pci@vger.kernel.org, shawnguo@kernel.org, linux-imx@nxp.com, helgaas@kernel.org, linux-arm-kernel@lists.infradead.org, kw@linux.com, festevam@gmail.com, lpieralisi@kernel.org, hongxing.zhu@nxp.com
Subject: Re: [PATCH v8 04/16] dt-bindings: imx6q-pcie: Add linux,pci-domain
 as required for iMX8MQ
Message-ID: <170482466895.2901163.17160878800155555620.robh@kernel.org>
References: <20240108232145.2116455-1-Frank.Li@nxp.com>
 <20240108232145.2116455-5-Frank.Li@nxp.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240108232145.2116455-5-Frank.Li@nxp.com>


On Mon, 08 Jan 2024 18:21:33 -0500, Frank Li wrote:
> iMX8MQ have two pci controllers. Adds "linux,pci-domain" as required
> property for iMX8MQ to indicate pci controller index.
> 
> This adjustment paves the way for eliminating the hardcoded check on the
> base register for acquiring the controller_id.
> 
> 	...
> 	if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR)
> 		imx6_pcie->controller_id = 1;
> 	...
> 
> The controller_id is crucial and utilized for certain register bit
> positions. It must align precisely with the controller index in the SoC.
> An auto-incremented ID don't fit this case. The DTS or fuse configurations
> may deactivate specific PCI controllers.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> 
> Notes:
>     Keep current to avoid DTB_CHECK warning. After these patch merged. Will add
>     linux,pci-domain in all dts file. So dt-binding can remove condition check
>     by soc.
> 
>     Change from v5 to v6
>     - rework commit message to explain why need required and why auto increase
>     id not work
> 
>     Change from v4 to v5
>     - new patch at v5
> 
>  .../bindings/pci/fsl,imx6q-pcie-common.yaml           | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>