Received-SPF: pass (google.com: domain of linux-kernel+bounces-21290-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240105000632.2484182-1-aahila@google.com> <11317.1704418732@famine>
 <ZZtwKFu4GQLQ5AXM@Laptop-X1>
In-Reply-To: <ZZtwKFu4GQLQ5AXM@Laptop-X1>
From: Aahil Awatramani <aahila@google.com>
Date: Tue, 9 Jan 2024 11:06:56 -0800
Message-ID: <CAGfWUPyHJ-R98jvqEyJ5KMkv=NyxvOFYLN+wxCoshu7mKXpuVQ@mail.gmail.com>
Subject: Re: [PATCH 1/2 net-next v2] bonding: Extending LACP MUX State Machine
 to include a Collecting State.
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: Jay Vosburgh <jay.vosburgh@canonical.com>, David Dillow <dave@thedillows.org>, 
	Mahesh Bandewar <maheshb@google.com>, Andy Gospodarek <andy@greyhouse.net>, 
	"David S . Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, 
	Martin KaFai Lau <martin.lau@kernel.org>, Herbert Xu <herbert@gondor.apana.org.au>, 
	Daniel Borkmann <daniel@iogearbox.net>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thank you folk for your feedback.

Currently due to travelling reasons there will be a slight delay in my upda=
tes
but this should be resolved soon and I should be able to provide quicker
iterative feedback.

Thank you again for your reviews,
Aahil

On Sun, Jan 7, 2024 at 7:46=E2=80=AFPM Hangbin Liu <liuhangbin@gmail.com> w=
rote:
>
> On Thu, Jan 04, 2024 at 05:38:52PM -0800, Jay Vosburgh wrote:
> > >+coupled_control
> > >+
> > >+    Specifies whether the LACP state machine's MUX in the 802.3ad mod=
e
> > >+    should have separate Collecting and Distributing states.
> > >+
> > >+    The default value is 1. This setting does not separate the Collec=
ting
> > >+    and Distributing states, maintaining the bond in coupled control.
> > >+
> >
> >       Please reference the standard in the description; this is
> > implementing the independent control state machine per IEEE 802.1AX-200=
8
> > 5.4.15 in addition to the existing coupled control state machine.
>
> The status of IEEE 802.1AX-2008[1] is "Superseded Standard". Maybe we sho=
uld
> use IEEE 802.1AX-2020[2].
>
> [1] https://standards.ieee.org/ieee/802.1AX/4176/
> [2] https://standards.ieee.org/ieee/802.1AX/6768/
>
> Thanks
> Hangbin