Received-SPF: pass (google.com: domain of linux-kernel+bounces-21295-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240109133957.2975272-1-yukuai1@huaweicloud.com>
In-Reply-To: <20240109133957.2975272-1-yukuai1@huaweicloud.com>
From: Song Liu <song@kernel.org>
Date: Tue, 9 Jan 2024 11:14:59 -0800
Message-ID: <CAPhsuW6zxf-5NOJHbpBVhXLM+MzKn4upgHqU+=Z+Owp9yocdKQ@mail.gmail.com>
Subject: Re: [PATCH] md: fix md_seq_ops() regressions
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, 
	yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 9, 2024 at 5:43=E2=80=AFAM Yu Kuai <yukuai1@huaweicloud.com> wr=
ote:
>
> From: Yu Kuai <yukuai3@huawei.com>
>
> Commit cf1b6d4441ff ("md: simplify md_seq_ops") introduce following
> regressions:
>
> 1) If list all_mddevs is emptly, personalities and unused devices won't
>    be showed to user anymore.
> 2) If seq_file buffer overflowed from md_seq_show(), then md_seq_start()
>    will be called again, hence personalities will be showed to user
>    again.
> 3) If seq_file buffer overflowed from md_seq_stop(), seq_read_iter()
>    doesn't handle this, hence unused devices won't be showed to user.
>
> Fix above problems by print personalities and unused devices in
> md_seq_show(), as it used to be.
>
> Fixes: cf1b6d4441ff ("md: simplify md_seq_ops")
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>

Applied to md-6.8 branch. (Yes, I am trying to make some changes to the
branches we use. )

Thanks,
Song