Received-SPF: pass (google.com: domain of linux-kernel+bounces-21382-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Jernej =?utf-8?B?xaBrcmFiZWM=?= <jernej.skrabec@gmail.com>
To: fuyao <fuyao@sjterm.com>, Jakub Kicinski <kuba@kernel.org>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
 Jose Abreu <joabreu@synopsys.com>, "David S. Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>,
 Chen-Yu Tsai <wens@csie.org>, Samuel Holland <samuel@sholland.org>,
 Maxime Coquelin <mcoquelin.stm32@gmail.com>, netdev@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
 linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org,
 =?utf-8?B?6bqm5YGl5bu6?= <maijianzhang@allwinnertech.com>
Subject: Re: [PATCH] gmac: sun8i: r40: add gmac tx_delay support
Date: Tue, 09 Jan 2024 21:15:07 +0100
Message-ID: <22143664.EfDdHjke4D@jernej-laptop>
In-Reply-To: <20240102075807.1a4cac92@kernel.org>
References:
 <ZYKvCQBD-SY9uVLF@debian.cyg> <ZYPmZj8l01eQsDS5@debian.cyg>
 <20240102075807.1a4cac92@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

Dne torek, 02. januar 2024 ob 16:58:07 CET je Jakub Kicinski napisal(a):
> On Thu, 21 Dec 2023 15:16:54 +0800 fuyao wrote:
> > I don't see it in the user manual also.
> > 
> > it works fine in 100M, but it doesn't work good in 1G without tx_delay
> > in my board.
> > 
> > Read the sdk from allwinner I found in:
> > 
> > https://sourcegraph.com/github.com/tinalinux/linux-3.10/-/blob/arch/arm/boot/dts/sun8iw11p1.dtsi?L1826
> > https://sourcegraph.com/github.com/tinalinux/linux-3.10@r40-v1.y/-/blob/drivers/net/ethernet/allwinner/sunxi-gmac.c?L877
> > 
> > And I add it to my board, it works fine.
> > 
> > So, I think it may be exist register but not documented.
> 
> Unless Allwinner can chime in we should at least document the situation
> clearly in the commit message (incl. what HW+config was tested, exactly)
> and add a comment in the code?
> 

I agree. Fuyao, please do that.

Best regards,
Jernej