Received-SPF: pass (google.com: domain of linux-kernel+bounces-21467-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <63d9d1b9-6c2a-4d8a-9bf6-9973d76ae97d@infradead.org>
Date: Tue, 9 Jan 2024 14:18:00 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 06/12] soc: qcom: Add Qualcomm APSS minidump kernel
 driver
Content-Language: en-US
To: Mukesh Ojha <quic_mojha@quicinc.com>, corbet@lwn.net,
 andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org,
 krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
 keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com,
 mathieu.poirier@linaro.org, vigneshr@ti.com, nm@ti.com,
 matthias.bgg@gmail.com, kgene@kernel.org, alim.akhtar@samsung.com,
 bmasney@redhat.com
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240109153200.12848-1-quic_mojha@quicinc.com>
 <20240109153200.12848-7-quic_mojha@quicinc.com>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20240109153200.12848-7-quic_mojha@quicinc.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi--

On 1/9/24 07:31, Mukesh Ojha wrote:
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index 1f81746131fc..56bc0c8a19f9 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -278,4 +278,17 @@ config QCOM_RPROC_MINIDUMP
>  	  query predefined minidump segments associated with the remote processor
>  	  and check its validity and end up collecting the dump on remote processor
>  	  crash during its recovery.
> +
> +config QCOM_MINIDUMP
> +	tristate "QCOM APSS Minidump driver"
> +	depends on ARCH_QCOM || COMPILE_TEST
> +	depends on QCOM_SMEM
> +	help
> +	  This config enables linux core infrastructure for Application

	                      Linux
same as 2 lines below.

> +	  processor subsystem (APSS) minidump collection i.e, it enables

	                                      collection, i.e., it enables

> +	  Linux clients drivers to register their internal data structures

	        client drivers

> +	  and debug messages as part of the apss minidump table and when

	                                    APSS
as above and in Subject.

> +	  the SoC is crashed, these selective regions will be dumped

	          has

> +	  instead of the entire DDR dump. This saves significant amount

	                                  This saves a significant amount

Does it have to be DDR?


> +	  of time and/or storage space.
>  endmenu

-- 
#Randy