Received-SPF: pass (google.com: domain of linux-kernel+bounces-21563-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <a4364632-3ab0-477e-96dc-d276479d4e19@linux.dev>
Date: Wed, 10 Jan 2024 08:15:12 +0800
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH for-next v4 2/2] RDMA/rxe: Remove rxe_info from
 rxe_set_mtu
To: Li Zhijian <lizhijian@fujitsu.com>, linux-rdma@vger.kernel.org
Cc: zyjzyj2000@gmail.com, jgg@ziepe.ca, leon@kernel.org,
 linux-kernel@vger.kernel.org, rpearsonhpe@gmail.com
References: <20240109083253.3629967-1-lizhijian@fujitsu.com>
 <20240109083253.3629967-2-lizhijian@fujitsu.com>
From: Zhu Yanjun <yanjun.zhu@linux.dev>
In-Reply-To: <20240109083253.3629967-2-lizhijian@fujitsu.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

在 2024/1/9 16:32, Li Zhijian 写道:
> commit 9ac01f434a1e ("RDMA/rxe: Extend dbg log messages to err and info")

Thanks. Maybe move this "commit 9ac01f434a1e ("RDMA/rxe: Extend dbg log 
messages to err and info")" to Fixes tag, is it better?

Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev>

Zhu Yanjun

> newly added this info. But it did only show null device when
> the rdma_rxe is being loaded because dev_name(rxe->ib_dev->dev)
> has not yet been assigned at the moment:
> 
> "(null): rxe_set_mtu: Set mtu to 1024"
> 
> Remove it to silent this message, check the mtu from it backend link
> instead if needed.
> 
> CC: Bob Pearson <rpearsonhpe@gmail.com>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
> V4: Remove it rather than re-order rxe_set_mtu() and rxe_register_device()
> ---
>   drivers/infiniband/sw/rxe/rxe.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/infiniband/sw/rxe/rxe.c b/drivers/infiniband/sw/rxe/rxe.c
> index a086d588e159..ae466e72fc43 100644
> --- a/drivers/infiniband/sw/rxe/rxe.c
> +++ b/drivers/infiniband/sw/rxe/rxe.c
> @@ -160,8 +160,6 @@ void rxe_set_mtu(struct rxe_dev *rxe, unsigned int ndev_mtu)
>   
>   	port->attr.active_mtu = mtu;
>   	port->mtu_cap = ib_mtu_enum_to_int(mtu);
> -
> -	rxe_info_dev(rxe, "Set mtu to %d\n", port->mtu_cap);
>   }
>   
>   /* called by ifc layer to create new rxe device.