Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755831AbXLMCUT (ORCPT ); Wed, 12 Dec 2007 21:20:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752018AbXLMCUG (ORCPT ); Wed, 12 Dec 2007 21:20:06 -0500 Received: from main.gmane.org ([80.91.229.2]:52785 "EHLO ciao.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751568AbXLMCUE (ORCPT ); Wed, 12 Dec 2007 21:20:04 -0500 X-Injected-Via-Gmane: http://gmane.org/ To: linux-kernel@vger.kernel.org From: "Holger Hoffstaette" Subject: Re: Reproducible data corruption with sendfile+vsftp - splice regression? Date: Thu, 13 Dec 2007 03:19:43 +0100 Organization: The Fists of the White Lotus Message-ID: References: <474FC4D9.3020506@cosmosbay.com> <475055EE.9060105@hp.com> <20071205225429.GA10186@electric-eye.fr.zoreil.com> <20071206184426.GA32599@electric-eye.fr.zoreil.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: port-87-234-135-174.dynamic.qsc.de User-Agent: Pan/0.13.91 (Before we let euphoria convince us we are free) Cc: netdev@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1819 Lines: 39 On Thu, 06 Dec 2007 19:44:26 +0100, Francois Romieu wrote: > Holger Hoffstaette : [...] >> Maybe turning off sendfile or NAPI just lead to random success - so far >> it really looks like tso on the r8169 is the common cause. > > TSO on the r8169 is the magic switch but the regression makes imvho more > sense from a VM pov: > > - the corrupted file has the same size as the expected file - the > corrupted file exhibits holes which come as a multiple of 4096 bytes > (8*4k, 2 places, there may be more) > - the r8169 driver does not know what a page is - the 8169 hardware has a > small 8192 bytes Tx buffer > > It would be nice if someone could do a sendfile + vsftp test with TSO on a > different hardware. While I could not reproduce the corruption when simply > downloading a file that I had copied on the server with scp, it triggered > almost immediately after I copied it locally and tried to download the > copy. Here's an update - sorry for the delay but I need that machine for everyday work. I have now gone back to enable TSO since vsftp with sendfile really seems to be the only app that causes this. I have simply set it to use_sendfile=NO and no corruption occurs at all; the machine is stable and fast. FWIW the corruption can still be reproduced with 2.6.24-rc5. For kicks I have also tried -rc5 with SLAB instead of SLUB, but that didn't help either. The directory with the tcpdump & test data now also contains a few more corrupted files; maybe comparing the corruption offsets gives someone a better idea. thanks Holger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/