Received-SPF: pass (google.com: domain of linux-kernel+bounces-21574-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20240109141445.6808-1-pchelkin@ispras.ru>
References: <CAKYAXd-ULRwKdDLs2XPwf6n9_HTHUJv1+aLmbWN5SqjUxw_xNQ@mail.gmail.com>
 <20240109141445.6808-1-pchelkin@ispras.ru>
From: Namjae Jeon <linkinjeon@kernel.org>
Date: Wed, 10 Jan 2024 09:28:16 +0900
Message-ID: <CAKYAXd8g4k8kF+GyOv-jX5mw+PtKb9HxLrcWy5c4qpFwXFPTAQ@mail.gmail.com>
Subject: Re: [PATCH v2] ksmbd: free ppace array on error in parse_dacl
To: Fedor Pchelkin <pchelkin@ispras.ru>
Cc: Steve French <sfrench@samba.org>, Sergey Senozhatsky <senozhatsky@chromium.org>, 
	Tom Talpey <tom@talpey.com>, Hyunchul Lee <hyc.lee@gmail.com>, linux-cifs@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Alexey Khoroshilov <khoroshilov@ispras.ru>, 
	lvc-project@linuxtesting.org
Content-Type: text/plain; charset="UTF-8"

2024-01-09 23:14 GMT+09:00, Fedor Pchelkin <pchelkin@ispras.ru>:
> The ppace array is not freed if one of the init_acl_state() calls inside
> parse_dacl() fails. At the moment the function may fail only due to the
> memory allocation errors so it's highly unlikely in this case but
> nevertheless a fix is needed.
>
> Move ppace allocation after the init_acl_state() calls with proper error
> handling.
>
> Found by Linux Verification Center (linuxtesting.org).
>
> Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3")
> Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Applied it to #ksmbd-for-next-next.

Thanks for your patch!