Received-SPF: pass (google.com: domain of linux-kernel+bounces-21642-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <7433e325-9af7-4b8c-888e-07a0debf8e46@intel.com>
Date: Wed, 10 Jan 2024 09:36:20 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] mm: mmap: map MAP_STACK to VM_NOHUGEPAGE
Content-Language: en-US
To: Yang Shi <shy828301@gmail.com>, <oliver.sang@intel.com>,
	<riel@surriel.com>, <willy@infradead.org>, <cl@linux.com>,
	<ying.huang@intel.com>, <akpm@linux-foundation.org>
CC: <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
References: <20231221065943.2803551-1-shy828301@gmail.com>
 <20231221065943.2803551-2-shy828301@gmail.com>
From: Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <20231221065943.2803551-2-shy828301@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dU9XdVlNamRHOWV0MVZMUVF1bGtlWTMzN0g4UTZDQS82ZjFrZUJVRHR3T2VS?=
 =?utf-8?B?S1phNW5OZ2pqZGdxT296aFBva0RKUVFuOU9naVA4L0VtaEg0bXRPMFhyYUFh?=
 =?utf-8?B?RVVtUWIzcktsRkUzUWsxamJNQlNNRjIydjZmZ0htN1h0cW5ZVU1XTHF4a0sx?=
 =?utf-8?B?ZjRQSzJqWnZhdHBjRmgxaUdEdmVINXU5dWZHMExQOUhxcFErMHplOTd1TFNX?=
 =?utf-8?B?TzkwUXBHbk44ay9xdXRIcVllMnhBeXlyb1B5V01LUVJjQlFiYUFEanM4K29F?=
 =?utf-8?B?TjZSbS8wNm9ESVY5R3hCM05XL1FKYlFPZ1VweGE0eHBVVWN1UEpDNytmNDRU?=
 =?utf-8?B?YmxNanRlaFNUb1AxTm5ML01BQUVJZ1RHTkZrT3NwSFEvRW9La1MyNXBYTDYw?=
 =?utf-8?B?RGZQdEtlL0tWS3Nidk56WHA5NURkZm43OU1mMHB2VFR0anEzOG5zOTMxZVE1?=
 =?utf-8?B?aE5qU3daOENqNXY0RFRGRlJRYmVabzlNZlhIcTNqZnB1SC9vclJ0UU9WaE5j?=
 =?utf-8?B?NkFIc3ROUXpJRk1ucExVTWIwWFBjdjN5QXRMV3d3RmNiM3F3SFQyUTFBei9r?=
 =?utf-8?B?QTVzR3BBWWJqTjZUMzBrZ1VoWDRHbGt5SFlhejFQcVcxUzJSZXRKWldmWnNC?=
 =?utf-8?B?VDFVMjFSd2FqRlRoVDh3WjRpSEZ1dllmVG1uU0U0a2pydWFzSmpqK21LYWZH?=
 =?utf-8?B?M3NSaXJSZ05Pdi9iVE1MZDVFTHJqckpXcjhycFhEdTlDaE9sYTB1ZXordmtW?=
 =?utf-8?B?QWhyVEJTcGhNN0RuNU10c3U1N0R5bGZjanplOEFybnlDN0k3TGh0blR5bksv?=
 =?utf-8?B?MDdySWd5N2U1UWc4dTNkODloTDlIR01KQWhjenVzRjBXS1hDdEl1WllpM2hC?=
 =?utf-8?B?dm5URUgzd294Sjc5NTMzNkoyOG1uN3RSblJESTRkcW11WFE5WGFUOS9qNzBG?=
 =?utf-8?B?ZkoyaXVWNE9kTEpBTHVYbHRFV1M5eU9CWUYxeDhhdDBuajl1SFNrK1YzbXJv?=
 =?utf-8?B?R3U0VlVUamhuVUViV0dlRXdWWjZHNmhsU0hkbllPV0llc1BtWWs5bkowUmhx?=
 =?utf-8?B?Y2UwYk4vN012SW9wb0hLYUp6dmJRUmQwRDNSSHNkK1NxZ0I0eGFpcU5MRC91?=
 =?utf-8?B?ZUdCWHdlOGc5NWpDNC9oQW82N3dMa2JPL1BVV3krVWhNQ1dhQ2ppQ0FTVTZQ?=
 =?utf-8?B?cHVtNkd3RlhpUUVoVCtCYWZRb2tIM3BOK1VDWVU2aDVQRGwwVnYzMmljUnJk?=
 =?utf-8?B?alQ1Z0hBZnNKb01DWTliVzBOQmswaCtqV1RtemYyWVlMSTFIcWhUZ2xWQXJi?=
 =?utf-8?B?K210am5oelFHbjZTaHdpQzBxS1RCTlJMdnJ2VFc0bWFsU2ZjaGJHUmdzZDJq?=
 =?utf-8?B?RlpkUTZSNDI2Rjd3T0JHeXNZTWRNcFhweHhRZFJyRWFxVnNKQjAxUnFPNU5u?=
 =?utf-8?B?Slg2MVkvcE1KL2ZHN3k0YlFuNEpTVlF1dXBHckI3c21zc3NXMFM3ZmdQSkM4?=
 =?utf-8?B?R0MxSkJyVEZ6VC9UcjAxMHJTMThNa0lnMnMwMzE0Z3lyOXQ0eXhud1NlWEd5?=
 =?utf-8?B?SVk1RnNvdjBlZkZuaVphUmRaZzhEK004dXI0c2tIczJKejd0TVd0d1hDWEFv?=
 =?utf-8?B?cTJOcU9GWkNoSzBCWUF0ODZXU1JIVDVXYUxwZFBNc1RyTjFBcHlraTlZM1Vz?=
 =?utf-8?B?dzAyYVNsUGJuNHJKeXRQbGlFSGtMV2xCMnpyQUdNdEE4MnU2bFVMeVMyQ0xQ?=
 =?utf-8?B?SXY2ZnM3bWpETGpnN2V2QU02TDFveWR3NGpSdHEzNDE5dGV2MFNURmd5S25x?=
 =?utf-8?B?Nmp0cldJK3lXY2JQbG9qeHdGaktZamdURkZlN3NpNmdIV3FERjRYN3VOTzZN?=
 =?utf-8?B?dHFacE00Nzc2S003cVdJclJUWEE4ZDcwY0I2MHJYTEl2eWhRb3hXK3FiSUVD?=
 =?utf-8?B?cDdyWFVzNUxvL0tDUDZQbHJ0KyttcGlhMmtNaTFqZVNHNFZUYzJ5cUNCdDZk?=
 =?utf-8?B?TUxRbHNsL0JUT2RjS2M5V3pkK0hHZTFaM1plVU5POWpYcVlQODJucG41Z1ds?=
 =?utf-8?B?UUJRdW1SMUVYNXR5S001bUlpS1VwYlI3MU9iaXEvOEpIUUVlaWk1T1pmNEVV?=
 =?utf-8?B?ejZHckpkeWRKL0VkclZxYlhXMTJHOU5xWFJCSzB4bjFPclhiWDByYkJTZXRH?=
 =?utf-8?B?c3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a3422fb-2f7d-42cb-65f9-08dc117c933c
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2024 01:36:32.4654
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 76eBJtv0+BYUH/2XwhMWH0YWJXV7J5PPDGelpyI2ILAR8QtsziJ9CuJZUaURGHGDKLhySUt1hfgXPq5bSVROjQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8471
X-OriginatorOrg: intel.com


On 2023/12/21 14:59, Yang Shi wrote:
> From: Yang Shi <yang@os.amperecomputing.com>
> 
> The commit efa7df3e3bb5 ("mm: align larger anonymous mappings on THP
> boundaries") incured regression for stress-ng pthread benchmark [1].
> It is because THP get allocated to pthread's stack area much more possible
> than before.  Pthread's stack area is allocated by mmap without VM_GROWSDOWN
> or VM_GROWSUP flag, so kernel can't tell whether it is a stack area or not.
> 
> The MAP_STACK flag is used to mark the stack area, but it is a no-op on
> Linux.  Mapping MAP_STACK to VM_NOHUGEPAGE to prevent from allocating
> THP for such stack area.
> 
> With this change the stack area looks like:
> 
> fffd18e10000-fffd19610000 rw-p 00000000 00:00 0
> Size:               8192 kB
> KernelPageSize:        4 kB
> MMUPageSize:           4 kB
> Rss:                  12 kB
> Pss:                  12 kB
> Pss_Dirty:            12 kB
> Shared_Clean:          0 kB
> Shared_Dirty:          0 kB
> Private_Clean:         0 kB
> Private_Dirty:        12 kB
> Referenced:           12 kB
> Anonymous:            12 kB
> KSM:                   0 kB
> LazyFree:              0 kB
> AnonHugePages:         0 kB
> ShmemPmdMapped:        0 kB
> FilePmdMapped:         0 kB
> Shared_Hugetlb:        0 kB
> Private_Hugetlb:       0 kB
> Swap:                  0 kB
> SwapPss:               0 kB
> Locked:                0 kB
> THPeligible:           0
> VmFlags: rd wr mr mw me ac nh
> 
> The "nh" flag is set.
> 
> [1] https://lore.kernel.org/linux-mm/202312192310.56367035-oliver.sang@intel.com/
> 
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Tested-by: Oliver Sang <oliver.sang@intel.com>
> Cc: Yin Fengwei <fengwei.yin@intel.com>
> Cc: Rik van Riel <riel@surriel.com>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Christopher Lameter <cl@linux.com>
> Cc: Huang, Ying <ying.huang@intel.com>
> Signed-off-by: Yang Shi <yang@os.amperecomputing.com>

Reviewed-by: Yin Fengwei <fengwei.yin@intel.com>

> ---
>   include/linux/mman.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/mman.h b/include/linux/mman.h
> index 40d94411d492..dc7048824be8 100644
> --- a/include/linux/mman.h
> +++ b/include/linux/mman.h
> @@ -156,6 +156,7 @@ calc_vm_flag_bits(unsigned long flags)
>   	return _calc_vm_trans(flags, MAP_GROWSDOWN,  VM_GROWSDOWN ) |
>   	       _calc_vm_trans(flags, MAP_LOCKED,     VM_LOCKED    ) |
>   	       _calc_vm_trans(flags, MAP_SYNC,	     VM_SYNC      ) |
> +	       _calc_vm_trans(flags, MAP_STACK,	     VM_NOHUGEPAGE) |
>   	       arch_calc_vm_flag_bits(flags);
>   }
>