Received-SPF: pass (google.com: domain of linux-kernel+bounces-21656-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 9 Jan 2024 21:24:38 -0500
From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        maple-tree@lists.infradead.org, akpm@linux-foundation.org,
        zhangpeng.00@bytedance.com
Subject: Re: [PATCH] maple_tree: fix comment describing mas_node_count_gfp()
Message-ID: <20240110022438.5htfrewpgtn6gaoa@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
	Sidhartha Kumar <sidhartha.kumar@oracle.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	maple-tree@lists.infradead.org, akpm@linux-foundation.org,
	zhangpeng.00@bytedance.com
References: <20240109223119.162357-1-sidhartha.kumar@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240109223119.162357-1-sidhartha.kumar@oracle.com>
User-Agent: NeoMutt/20220429
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?TpbPwFhPrs6lpHbKWhYtZs9xS7DaF+kR0jmuVS1xuW3T44klES7MWwSW0+Ee?=
 =?us-ascii?Q?Db6P0/FAB+RUhS+DIFSVAzfWZTyCbfOa2Pi6HmcqfS/x3JbKuXa3SGww/iWo?=
 =?us-ascii?Q?r4m1dCGyCd4lS6kykonnL+PM7YG1GqCWue11a7DK+EVWxEJZ4XDD8qErHsh0?=
 =?us-ascii?Q?6S5GhldqJC1Vd/uuXF3Pw4hDhrXU4xUdk0f4kgt4s8YOOokhrE865cK/rT7p?=
 =?us-ascii?Q?i641ngvQwKPnk3A7NtIymt9nTn0JpFK51bU3oL6Ix8YiI+p6iETyVW3+p5wy?=
 =?us-ascii?Q?E79GjfWkZlQRZJZOU+Tj16zEvXyfYGoFCQxoHpwWiuIsxk/rouS5TW5VD9Nq?=
 =?us-ascii?Q?4/uUYTTSOkX+x+mnyfZe8UXQmmMuxKlKTlXmBZZ/C1RENQNDgYcUAMLyz9Cu?=
 =?us-ascii?Q?7LMeL0c2yB8jIOFwhCbbiXtNXZlsk//ftrBsv2SP+vh5AX/MRQzVYx2p2hNI?=
 =?us-ascii?Q?tA2axXW6pQJmnrqiMg6JGskR1/KyK6ZCOSZPVkFvA7pVEO51YY39xfuY1eR3?=
 =?us-ascii?Q?lurEP8yirdqsd3prcSwdqWnC6VlGOp20G2/yolL3/eq5qtDUSIP0ovCOFb2h?=
 =?us-ascii?Q?RmBu82Mtq1VoZEqk85lvpe3QN6ovyWP6OUxNpDondFmtVVLCr20SpVwtMVIS?=
 =?us-ascii?Q?A6oPkJYsX1yJVf5yljFk2buL4g29C+OB3IMDUbibyNfw44NGLChPaCeObArB?=
 =?us-ascii?Q?p0XK/+nwbMfK93QU31o6DW1epTXSgPTuoTiv1D7JoUKTiY7JMpqceYwi6YKI?=
 =?us-ascii?Q?Ei9vq4FITWRzE81y0Awdc7dlvRtSzhj1PUlcfSNnIrvtna80F/rm2rZzzqNr?=
 =?us-ascii?Q?w1ItXHOUk2a5kLebGGtEuXJ0aIP/XJeDCxs0Iy+a8pXWOzzTqWM4qpXj/htz?=
 =?us-ascii?Q?qhawKD3qEfXMOlmlLcwveeTufgI3lwovk4Q7G/6/QMqYife41QoT/0ffesil?=
 =?us-ascii?Q?QwRHBvGq1ikmwmhpV+fjytr9B92VocpeAbkv3qYKlw1xN8HTGYKsaYX7wGpQ?=
 =?us-ascii?Q?LHoMyqxXFmu9yWH+TChvLNiYIqWdzbvXfUtAIka3ve2FileEFH8kQwiPkBr9?=
 =?us-ascii?Q?3fRNk2tXa23YLlNM7++FTKGFtT/2NBolz7M80uamqN/k7UZB9hNUn9i84THv?=
 =?us-ascii?Q?qATCulPPnOQQSGrlmJu07mkUAaUDsgg4Mol5DqlBAeY0zQYy2nkCN+4Jz3BX?=
 =?us-ascii?Q?MApm8uw89j1K0deurDGNKCUiFk7s01lESUyot31nMGG422Fv0vuVtPDz0KJ2?=
 =?us-ascii?Q?O/n8f9bqWT6bi+/JenPgZ2ZhvA9nWzOzvKUmLZpKGgcLNfCU5dhJ7DTAPRLP?=
 =?us-ascii?Q?SHTzV+1EQY6Msa2wC+RmCYFxbFMkbVMfPZ+D9Vkm9uT3KMIKVXy4JD+sPCjF?=
 =?us-ascii?Q?avxjlwxMOnjyXApSSdGk5C6lGYqa8q7/yDCHaethqNCaEbTEy+cddyUH1+FT?=
 =?us-ascii?Q?2aUm2EaCuep04eh58x8CVRNeKLCovXghbMvcqoVIgnbLaz2IMM2lUQqZRJ7i?=
 =?us-ascii?Q?JGFa6W8LsgWptRdWljCanm/wNUoD5lEA0jI7vVUIlEUUU4SsP1J1/krSzu50?=
 =?us-ascii?Q?+lloIYOL2ASv9xPkXR9wW7SdB6ebKrnrgX+olxH6Z/RyecZ3Fl2Lvnn/7ReS?=
 =?us-ascii?Q?mA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	DJHKFpvYrbZardFwawTkTrRRRWAHiY6zBdfCB8pfgv/x+UUl1zlNgPrS36BrcNbCC8V5RxuoaotmC1NgJ7BW9uNsUJr9C5e93WBtAvgi6SUBWKmafxevN52PSuAbbEbbYCHxqZYDJACYlJ8W4FBcoB21X+1knjBr8YXkgY5k+b/a/SmPDxrsyQONWdpNn3gDwK+DFfr3xNVn3erbIzSJDQD72pnRR14CHiU/T8v5RPQF3N3h3UMpJDMrXfYFUSdgTPjcMAIAXNjP9+pIohN1NvQSU+LaUC8d3UzB82ewTqNQFXBqwM+YzQodwjjpwoDIFSZNItQVsmB5TCQk+2vDxLH3N4w/Var1WJ14NtMv2sUZgvPlAHn/qetrtpYWvkK+6Aw8Ct8y+YnZGx9KUmW4WjpKpC5dw592rOC4UmHhl4TNq+MRnEtLDc8tYXXh9twYQGrdQCfpMO/u3zGGaP4UT6OaWW4xw6f6zQQgN40Jln8WYHuOVgUheVHZuP81n+q8L5ScEpZdKU73bBJJPVSmrMhlcEO8OSbAI/TEWjlGNY29F1veG4Y8ryVzdUmWxBcFwbp0mWoZ0iyRyYI01wf44hgRMSe9xl/B7WTbVMmY1nE=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5d05f31-f432-44e9-2dfb-08dc11834c38
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2024 02:24:39.8094
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6bRWyKr5NTeHlNkkLe9oPfc47RK9Y/yeRgFDIvL6JVieZwY1ZXg7fCkQW7cOHfrAnXiCHajVtytlh++c7MWYQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6821
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-09_13,2024-01-09_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 adultscore=0
 phishscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2401100018
X-Proofpoint-ORIG-GUID: NED6I2vY9FvoL4OyTZcfTFbRdV315Wqd
X-Proofpoint-GUID: NED6I2vY9FvoL4OyTZcfTFbRdV315Wqd

* Sidhartha Kumar <sidhartha.kumar@oracle.com> [240109 17:31]:
> The function description comment for mas_node_count_gfp() mistakingly
> refers to the function as mas_node_count(). Change it to refer to the
> correct function.

Looks good, thanks!

> 
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>

Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>

> ---
>  lib/maple_tree.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 6f241bb387992..7b161802860bd 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -1307,8 +1307,8 @@ static inline void mas_free(struct ma_state *mas, struct maple_enode *used)
>  }
>  
>  /*
> - * mas_node_count() - Check if enough nodes are allocated and request more if
> - * there is not enough nodes.
> + * mas_node_count_gfp() - Check if enough nodes are allocated and request more
> + * if there is not enough nodes.
>   * @mas: The maple state
>   * @count: The number of nodes needed
>   * @gfp: the gfp flags
> -- 
> 2.42.0
>