Received-SPF: pass (google.com: domain of linux-kernel+bounces-21665-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Arnd Bergmann <arnd@kernel.org>, Yishai Hadas <yishaih@nvidia.com>, "Alex
 Williamson" <alex.williamson@redhat.com>, "Michael S. Tsirkin"
	<mst@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>
CC: Arnd Bergmann <arnd@arndb.de>, Shameer Kolothum
	<shameerali.kolothum.thodi@huawei.com>, "kvm@vger.kernel.org"
	<kvm@vger.kernel.org>, "virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] vfio: fix virtio-pci dependency
Thread-Topic: [PATCH] vfio: fix virtio-pci dependency
Thread-Index: AQHaQtGTD8akChfpEkaQDR2fxszp8bDSW+CA
Date: Wed, 10 Jan 2024 02:57:55 +0000
Message-ID: <BN9PR11MB527624BE8A9A0ACC3E97F1C28C692@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240109075731.2726731-1-arnd@kernel.org>
In-Reply-To: <20240109075731.2726731-1-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?i8+vrEyF8ddJWJ4+QxRA491wthrb/N8XkIMmlO1mbtn8mWJQEbbRJBUv2TPo?=
 =?us-ascii?Q?tOCmuIaUAurLjPqU+ecHAIQsmNQBO/ww6UfajxUgdeu02l7o3k2dOFco2uGT?=
 =?us-ascii?Q?cpiaYvBrQXeYLvUar5NQF1os7ZdKpm14XLkKVce4b+uWKHkvpDT0ShLSQg0E?=
 =?us-ascii?Q?keHvLKLFBhAwk3+YFZYbJXbGLJ2/EfW07ESGSdlOvy5xmkcL4MYSHe5Wd4fX?=
 =?us-ascii?Q?V1M/442JO2iFAsWx5BuAg3dsNAQtfSX/vVJsm9rIGB3XiAZMAu5sg3hnpG18?=
 =?us-ascii?Q?EIqSXMo98gdpPMj5IbVgbr7wlogpJtN+M6oIYZBc9+kb0i8EPBJetDL2pZKh?=
 =?us-ascii?Q?9VCnlcgwhWRM6gKAQtQKcQm1yKRO94uEB5fgAtoKf4+NRJRX9XAcWLxWudl1?=
 =?us-ascii?Q?9m1p1XpJFr9JV+lQksgeawbAdB7sk5SywhOa38z1937PSYe+zc1LIciOgWh2?=
 =?us-ascii?Q?MLMD2QgXSPz/3bxZSqysdVj/+VG/dcMMApiZUDm96GysKNPrlJryZMpRqa0r?=
 =?us-ascii?Q?t+udtg4fYI9fk/0eKribZH8eel05P+Lssme4PvOdicjzScmr+BVwU0mhH28F?=
 =?us-ascii?Q?gPGtKCrtOgBNg73bQMuinvkY64TSEmPm/Y2zYrdvy/KQXc5NbasEFrsLy3KX?=
 =?us-ascii?Q?ncKB6u/EuFe5tMZTrLpnfzfp9XTvLyRdTKZ9aKbbWskjmi/SQ+cnLEp2iYKE?=
 =?us-ascii?Q?Wpj2ummUKjeQzMzE6BwCCdjoCqWiBAkxseC7Dqms1aSQEIWxXF9w/3vOiw40?=
 =?us-ascii?Q?YrSFR4vUTStICyLPojm0mrItzt9PYWBvzcFdNeDkUNgAPdjBJP39scgvHAHH?=
 =?us-ascii?Q?L2YOuW0ZJmbwFg6Mz/dZz1ImOJO+n+rSh/Q+RleFLJwkTPEmIK8W0eE7XIoW?=
 =?us-ascii?Q?bOUIqz9Syvs8mNM4gcAOLxXqz5aoTaOSoH91fAJF9JZ0UbNpZQNCLUhSkpIE?=
 =?us-ascii?Q?lfEi6nwGdF6VVglLraQNWD0DhUgdsdppJcMHGB43/rD8xe/ek3u78SW8atHe?=
 =?us-ascii?Q?/8NgYWYt4Nt5IzF+n6UU6iagh6r0DjgPDk1gAPSp9PHi+m0cE3CvQE+TYKAV?=
 =?us-ascii?Q?S21Ywv3jtoFTPXDJnqWtFD79LB4m0tOi8WlNsgw8z/+kAeKhHdVAu9+KDFX8?=
 =?us-ascii?Q?mkugxb1GX9YvUfCNXEgiMgPIi3LeO49s+u7r+OL7IeRKh4xCFehLzVEq0hF3?=
 =?us-ascii?Q?4FiXK4Zy633gnPPGMbWNfaQpg4s+F98m+RaqSUxcxeUlnHO7ndzkLgPlCJBp?=
 =?us-ascii?Q?Buit1WiLe1qEI3bJO9bkHM0hhn0z3365Oq1kjD2J1nEo2c4riGpoXEzYsZES?=
 =?us-ascii?Q?9likR0uHVqERSnAFYmwa40g8hC5FfOtLt/N9o2k+Y55VgHZzeIDT90LZweQn?=
 =?us-ascii?Q?xz0Dg5vK6QRm1jgoWihaz6zm/maWPgjU+O5fiDB6SNmVhPF4aTnzceRwGDW/?=
 =?us-ascii?Q?c4gOiDQfa6ZV8hwKR5dHEeKxNe2S/LcHVAsyUFGZicBtJ9YJ5gvzfEp26eEi?=
 =?us-ascii?Q?23X5goBuYmFWLc8NGKgzSTGOxJsOmbqy+22WctQgMKg68w3tEbUI8c1lu+EH?=
 =?us-ascii?Q?haoi47pOMgwuYciGlQx8qK8lS/hsNrsYAsZ+uId/?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 10966890-20c8-4115-46e5-08dc1187f1c2
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2024 02:57:55.3732
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: roi4SFYlu+6cquDHbTXmMCJgU2H9NCyosPxGzeMv707Vihj4gLSlUHgRRzI2iDLHPQ+MvtH8ZpoORtj0kX2uPA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB8262
X-OriginatorOrg: intel.com

> From: Arnd Bergmann <arnd@kernel.org>
> Sent: Tuesday, January 9, 2024 3:57 PM
>=20
> From: Arnd Bergmann <arnd@arndb.de>
>=20
> The new vfio-virtio driver already has a dependency on
> VIRTIO_PCI_ADMIN_LEGACY,
> but that is a bool symbol and allows vfio-virtio to be built-in even if
> virtio-pci itself is a loadable module. This leads to a link failure:
>=20
> aarch64-linux-ld: drivers/vfio/pci/virtio/main.o: in function
> `virtiovf_pci_probe':
> main.c:(.text+0xec): undefined reference to `virtio_pci_admin_has_legacy_=
io'
> aarch64-linux-ld: drivers/vfio/pci/virtio/main.o: in function
> `virtiovf_pci_init_device':
> main.c:(.text+0x260): undefined reference to
> `virtio_pci_admin_legacy_io_notify_info'
> aarch64-linux-ld: drivers/vfio/pci/virtio/main.o: in function
> `virtiovf_pci_bar0_rw':
> main.c:(.text+0x6ec): undefined reference to
> `virtio_pci_admin_legacy_common_io_read'
> aarch64-linux-ld: main.c:(.text+0x6f4): undefined reference to
> `virtio_pci_admin_legacy_device_io_read'
> aarch64-linux-ld: main.c:(.text+0x7f0): undefined reference to
> `virtio_pci_admin_legacy_common_io_write'
> aarch64-linux-ld: main.c:(.text+0x7f8): undefined reference to
> `virtio_pci_admin_legacy_device_io_write'
>=20
> Add another explicit dependency on the tristate symbol.
>=20
> Fixes: eb61eca0e8c3 ("vfio/virtio: Introduce a vfio driver over virtio de=
vices")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>