Received-SPF: pass (google.com: domain of linux-kernel+bounces-21683-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <16efa89e-6a9d-4e9a-9020-239b9750119d@quicinc.com>
Date: Wed, 10 Jan 2024 08:46:40 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 07/12] usb: dwc3: qcom: Instantiate dwc3 core directly
Content-Language: en-US
To: Bjorn Andersson <quic_bjorande@quicinc.com>,
        Wesley Cheng
	<quic_wcheng@quicinc.com>,
        Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        "Johan
 Hovold" <johan@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>
CC: <linux-arm-msm@vger.kernel.org>, <linux-usb@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Conor Dooley
	<conor+dt@kernel.org>, Felipe Balbi <balbi@kernel.org>,
        Rob Herring
	<robh+dt@kernel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>,
        Greg Kroah-Hartman
	<gregkh@linuxfoundation.org>,
        Bjorn Andersson <andersson@kernel.org>,
        "Philipp Zabel" <p.zabel@pengutronix.de>
References: <20231016-dwc3-refactor-v1-0-ab4a84165470@quicinc.com>
 <20231016-dwc3-refactor-v1-7-ab4a84165470@quicinc.com>
From: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
In-Reply-To: <20231016-dwc3-refactor-v1-7-ab4a84165470@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 10/17/2023 8:41 AM, Bjorn Andersson wrote:
> The Qualcomm DWC3 glue builds up a platform_device programmatically in
> order to probe the DWC3 core when running off ACPI data. But with the
> newly introduced support for instantiating the core directly from the
> glue, this code can be replaced with a single function call.
> 


> @@ -942,7 +889,7 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
>   	if (np)
>   		ret = dwc3_qcom_of_register_core(pdev);
>   	else
> -		ret = dwc3_qcom_acpi_register_core(pdev);
> +		ret = dwc3_qcom_probe_core(pdev, qcom);
>   
>   	if (ret) {
>   		dev_err(dev, "failed to register DWC3 Core, err=%d\n", ret);
> @@ -986,10 +933,10 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
>   interconnect_exit:
>   	dwc3_qcom_interconnect_exit(qcom);
>   depopulate:
> -	if (np)
> +	if (qcom->dwc_dev)
>   		of_platform_depopulate(&pdev->dev);
>   	else
> -		platform_device_put(pdev);
> +		dwc3_remove(qcom->dwc);

Hi Bjorn

  I was testing this patch and I suspect there is one issue.

  In the event dwc3_qcom_probe_core fails because dwc3_probe failed, 
then the variable (qcom->dwc) is NULL. We then exercise the depopulate 
path and we call dwc_remove(NULL) causing a crash.

Regards,
Krishna,