Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp747520rdd; Tue, 9 Jan 2024 20:24:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IE6JPqUAeBCa0SZXf2duhJflYG/99eWGQnbKoBCFw3fWx92PyKzF8obBMp3MxSkuLj17Q1m X-Received: by 2002:a05:6214:1d2a:b0:67f:1d04:920e with SMTP id f10-20020a0562141d2a00b0067f1d04920emr613356qvd.82.1704860661123; Tue, 09 Jan 2024 20:24:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704860661; cv=none; d=google.com; s=arc-20160816; b=wga+glzVpKHrClpyyVKhu7uPj+nPH3urnA5y1XWybIY0JmSw/AMQb/nTaVaz/ihEmO 9PFUv9Lw4/5WhHNdAHGNtp4V6+Y7mP+z7GHujRkCpoPmt/sRXoesYEmSKLkJhPCRZCqg mAind6XMc1fTHUsbURz0se5yVn8lFmJ34PeifMPtlvOpYOK3N1XaXQoUmGZusBOACEg4 xWQGX1yy5iki+iLU0tc8xzjbzsrmbmuWfszeHe6LJaurNIRqj+PbRWKCDlSlJLITjT5o BBcafGLgaHYhschiXOF1Ik1X6/0A/dlPjujb57v4hfexpX1zpS8nYEm8K7Vo9dtyJhV+ dhuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=hFP2duQPjTkTHqDHgPqzfrs6xOa0hGVl5VTV84sXBS4=; fh=s7xoQ+atXiw6lFoYQT8QTA2jl04+lEW4h9OAEMewyVE=; b=m2phrsnBnGb5RtNt3t2BmRTCzz0K2Ev4MFff9dAp6ssDrBL7ZB2doMacXvNgcMPgg0 26b2+Mu8APE/IukguNWTThAfCNdft93XJCKMqWAi0mz6z63cLLyRFK5fAZSLWkwJL1tU T67w3uwiQBY/GN3GkJoCZ3qI7Onl4t453N23RBuAOHvzTP2fHkFqp61UGejQKufa3aGh UGsYkIVoFkYux0FjlXwhOTAORmuY6niThoCBbLIhEPjwW1sfM02G6vXiI/CXR6kVhn78 PL/KpX7Dri/VnYaoC5x0e5zIT/QlfQrbJdbYkjkhtUP7B9oZxYoplvmVvWfT1cCG3Ww5 5jOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=LuEeyAuV; spf=pass (google.com: domain of linux-kernel+bounces-21704-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-21704-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id i19-20020a05620a249300b00783245e9362si3640598qkn.622.2024.01.09.20.24.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 20:24:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-21704-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=LuEeyAuV; spf=pass (google.com: domain of linux-kernel+bounces-21704-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-21704-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id DE76F1C250DD for ; Wed, 10 Jan 2024 04:24:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3A32663C1; Wed, 10 Jan 2024 04:24:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="LuEeyAuV" Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABBBE6117 for ; Wed, 10 Jan 2024 04:24:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704860651; x=1736396651; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=cDti/wCs6rkD3xX+F00Cv6MwqIm3ji7E9FlSEIu2f3A=; b=LuEeyAuVBrI90Xmt4Y6QP/+E6YEUG4MQ2FqDQawTBPm4yAjpTEZQk/Ur /i0cNsHBMIA2x89oaiG/q3r2gHz0foTD+moxN0acl3tWiOvtC1tycSKMa poFkgnkiNCPc3gWnRlfoizuPhaQIMc3R8/kwSXoguKKEZHPpGjgHbHzgy ZrIEXQEsY3r1ZXD7mfkuBIcCihmtde0DlISmsZuXnocvdJ6t/1MYaOnKF Lu8hQhKUq2iz2ulnsW9URWanoKx/WZxZGuMjIIekX9ZI/adglZ3iTUfxo mAAkdQDMcWhevuggKmgwMPbaJIW13E9y88/L4geOWcmZX7LdoZUtmEGa/ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10947"; a="395562661" X-IronPort-AV: E=Sophos;i="6.04,184,1695711600"; d="scan'208";a="395562661" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2024 20:24:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,184,1695711600"; d="scan'208";a="16503453" Received: from tassilo.jf.intel.com (HELO tassilo) ([10.54.38.190]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2024 20:24:11 -0800 Date: Tue, 9 Jan 2024 20:24:09 -0800 From: Andi Kleen To: Thomas Gleixner Cc: x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/mtrr: Check if fixed MTRRs exist before saving them Message-ID: References: <20240105163711.9278-1-ak@linux.intel.com> <87plyajphp.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87plyajphp.ffs@tglx> On Tue, Jan 09, 2024 at 08:06:26PM +0100, Thomas Gleixner wrote: > On Fri, Jan 05 2024 at 08:37, Andi Kleen wrote: > > This one place forgot to check the fixed capability. > > What's the consequence of that missing chec You get a WARN_ON for a WRMSR failing if you don't have the MSR. > and shouldn't this have a Fixes tag? It's more an ancient bug back dating back to my tenure in 2007, but here it is: Fixes: 2b1f6278d77c ("[PATCH] x86: Save the MTRRs of the BSP before") -Andi