Received-SPF: pass (google.com: domain of linux-kernel+bounces-21729-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: "Swee, Leong Ching" <leong.ching.swee@intel.com>
To: Serge Semin <fancer.lancer@gmail.com>
CC: Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue
	<alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com>, "David S .
 Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, "Jakub
 Kicinski" <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Rob Herring
	<robh+dt@kernel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	"linux-stm32@st-md-mailman.stormreply.com"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, Teoh Ji Sheng <ji.sheng.teoh@intel.com>
Subject: RE: [PATCH net-next v2 4/4] net: stmmac: Use interrupt mode INTM=1
 for per channel irq
Thread-Topic: [PATCH net-next v2 4/4] net: stmmac: Use interrupt mode INTM=1
 for per channel irq
Thread-Index: AQHaP6ZCdgIftjDRek6/+MvG5uqIGLDO13iAgAO41fA=
Date: Wed, 10 Jan 2024 05:43:26 +0000
Message-ID: <CH0PR11MB5490793807F66E011A31D1A3CF692@CH0PR11MB5490.namprd11.prod.outlook.com>
References: <20240105070925.2948871-1-leong.ching.swee@intel.com>
 <20240105070925.2948871-5-leong.ching.swee@intel.com>
 <jvnoq2jo3dzsw3vuqzathjuyox3xipaullzeaur3ppzlmtux5k@v64tckj7pvo2>
In-Reply-To: <jvnoq2jo3dzsw3vuqzathjuyox3xipaullzeaur3ppzlmtux5k@v64tckj7pvo2>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?E2VT61W9+Z9rB8VXbHM5dkWDvexNKV1zhsqOwt4q8tD3KwcRJ6OaBbrsnN2q?=
 =?us-ascii?Q?nrTrQ6iDeOw1vx8kVxAYlg4gk3DPBaC6F4lPb4INF9wjbD2Sra4s8n8XNTZJ?=
 =?us-ascii?Q?kjWkaSflOw4tJoAxuuWIlwz2bBBHmHwwUSHVoTNaKC4mukQVqN+FZw9/D0oC?=
 =?us-ascii?Q?lewua/zFVKZWQUCGuHYfwxjBOcGdemkV0q6dU6UIzS82Oj0g4cqhUZ+VXO6r?=
 =?us-ascii?Q?FiIemqDyr2H73La3sv//G4oStsYoi0e1K/TAKp9JjmdBh9Lzkm3qdPijb+Ud?=
 =?us-ascii?Q?NBurocIeiYg55ZDYXz68jMcoTh0UXzKZxLNvtgBGycZYG0V6pEcy4zf92LOa?=
 =?us-ascii?Q?iBTlAqyZKyW2XSvG4bZarHkSpQVzHemx2CLmlqTTZgHMMbCJmwQ5hV/Mso3V?=
 =?us-ascii?Q?732kH59mpGT/3m27DtY/GmILvDgPU45J2Wimsh/NuBwcBz5Xo/BLH4/Z9QnY?=
 =?us-ascii?Q?tpxCvsUwoQVwgzAstQZb0Vx3dHzy6mluykxMmiqPbnrTszBB4dyE9jTgdNkz?=
 =?us-ascii?Q?2Cv/t/1bxF+6ywGhzGw+vnZfDiGHTnBKGtUYSuOjhfBdHSma/SogMQNJRZ5w?=
 =?us-ascii?Q?kCpLxBkirC69PwdjGyUS5ewZpZKr+/BCvUhqwma5DAQRHYUG4FAmUfd77JN0?=
 =?us-ascii?Q?Dkx8adM0wAwyD2f8Zy8N6vE9fvnECel8TXOG5+X8VnfHklqz8rGJjsZJqDJ+?=
 =?us-ascii?Q?MTnfYViSdugIKOA/UuTsAmE5Qwi+1qcclAZX+n+P1i5AOwdvvag05xGqps8N?=
 =?us-ascii?Q?CsNbgqYQrZqzTU3nuopeBjTRmbFUTjRm7WLMx4m+EmhTYmeqJxhqWxIYeUWm?=
 =?us-ascii?Q?lafBNPqRYLcUPAx9jVHnajS2pQalfTBc4yTJji+jwkyhyL7mNXG1O619To2H?=
 =?us-ascii?Q?DJeISgHTki5CwteDZFaRfNpvK718LC9o43bmCYI6o5wjakgS7ZkdIHUH5h8c?=
 =?us-ascii?Q?jg04o38kHFFOuuXXlviwmPv3Q+rhUxmqX7D4Pco/1MY/0GdxFJTWbxLxa3r+?=
 =?us-ascii?Q?AsVMK8CZ2l9R/Fgv+EM3AJzSghLSmds4OGAWhlMCZ+ucNyQ0IncocJbLemXM?=
 =?us-ascii?Q?T8fJgzI0cSDfcrQfWhX2Gpbjln31nzzMW1J5rxqiawe1HjnlckieccqAuSRR?=
 =?us-ascii?Q?beACYUkJx+N4y3IEWmg7t+dsKGfsU6rxmZf9vc95nSJ4J2epMQo5SN+k4rEr?=
 =?us-ascii?Q?WyXjWht/DbcFWNz7CRIdr9a/N8ZVYabOclT/lyoiN6MXkNfXtDJN2cvGj+aa?=
 =?us-ascii?Q?4jwZ3sKYgZXsFYwRkPQCwLW1di040TLqC6FGn8vAQzUtca2JuzPbrSyBoo0g?=
 =?us-ascii?Q?OKXBPbiQlf5GVk939T+qHekyUwuXmeYrGhMw/rXwunWCDUHEsoghMgzOoLs3?=
 =?us-ascii?Q?Kfykh78KqeDgyr0uqLYe1SbdRryIQcjU0/x4RVwnraDGLncAucxP9CwDXRSt?=
 =?us-ascii?Q?/wpddueSdnTyNmnT5KzjeaeRo67A4+/or1Uqd3L8vnT2WNaqL+dpyvXBNVIN?=
 =?us-ascii?Q?Ii1UQCWPH1jCIv5rFJrRpIKxORPPxd/R4c7BP5i9BoiZDvfZ+LtWNhMd44Gp?=
 =?us-ascii?Q?EGA03iZY2EI5cdn9epyC2BayybY4vvvDDp5WIQG8N63Kg5snk4piHztHMHoK?=
 =?us-ascii?Q?uQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5490.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d2996251-adc3-49c4-7754-08dc119f115c
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2024 05:43:26.7994
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YeyWWLfRAPrYwnIFoM8p8rJqh2dr+Q6Nsy1j34x/IuBF4IctSAXBnYsIac3ZzttHeFgL08YcJlyA7GHd/NWXQLDUtRNnBNuHHTPTFfRqpYI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7406
X-OriginatorOrg: intel.com

> -----Original Message-----
> From: Serge Semin <fancer.lancer@gmail.com>
> Sent: Monday, January 8, 2024 4:52 AM
> To: Swee, Leong Ching <leong.ching.swee@intel.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>; Alexandre Torgue
> <alexandre.torgue@foss.st.com>; Jose Abreu <joabreu@synopsys.com>;
> David S . Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> <pabeni@redhat.com>; Rob Herring <robh+dt@kernel.org>; Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley
> <conor+dt@kernel.org>; Giuseppe Cavallaro <peppe.cavallaro@st.com>;
> linux-stm32@st-md-mailman.stormreply.com; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org; devicetree@vger.kernel.org; Teoh Ji Sheng
> <ji.sheng.teoh@intel.com>
> Subject: Re: [PATCH net-next v2 4/4] net: stmmac: Use interrupt mode
> INTM=3D1 for per channel irq
>=20
> On Fri, Jan 05, 2024 at 03:09:25PM +0800, Leong Ching Swee wrote:
> > From: Swee Leong Ching <leong.ching.swee@intel.com>
> >
> > Enable per DMA channel interrupt that uses shared peripheral interrupt
> > (SPI), so only per channel TX and RX intr (TI/RI) are handled by TX/RX
> > ISR without calling common interrupt ISR.
> >
> > Signed-off-by: Teoh Ji Sheng <ji.sheng.teoh@intel.com>
> > Signed-off-by: Swee Leong Ching <leong.ching.swee@intel.com>
> > ---
> >  .../net/ethernet/stmicro/stmmac/dwxgmac2.h    |  3 ++
> >  .../ethernet/stmicro/stmmac/dwxgmac2_dma.c    | 32 +++++++++++-------
> -
> >  2 files changed, 22 insertions(+), 13 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h
> > b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h
> > index 207ff1799f2c..04bf731cb7ea 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h
> > +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h
> > @@ -346,6 +346,9 @@
> >  /* DMA Registers */
> >  #define XGMAC_DMA_MODE			0x00003000
> >  #define XGMAC_SWR			BIT(0)
>=20
> > +#define XGMAC_DMA_MODE_INTM_MASK	GENMASK(13, 12)
> > +#define XGMAC_DMA_MODE_INTM_SHIFT	12
> > +#define XGMAC_DMA_MODE_INTM_MODE1	0x1
>=20
> AFAICS the DW XGMAC module doesn't maintain a convention of having the
> CSR fields macro names prefixed with the CSR name. Let's drop the
> DMA_MODE suffix from the macro name then:
> +#define XGMAC_INTM_MASK		GENMASK(13, 12)
> +#define XGMAC_INTM_SHIFT		12
> +#define XGMAC_INTM_MODE1		0x1
> to have it unified with the rest of the macros in dwxgmac2.h.
>=20
> Other than that the change looks good. Thanks.
>=20
> -Serge(y)
>=20
Thanks. Will rename the macros in v3.
> >  #define XGMAC_DMA_SYSBUS_MODE		0x00003004
> >  #define XGMAC_WR_OSR_LMT		GENMASK(29, 24)
> >  #define XGMAC_WR_OSR_LMT_SHIFT		24
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
> > b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
> > index 3cde695fec91..dcb9f094415d 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
> > @@ -31,6 +31,13 @@ static void dwxgmac2_dma_init(void __iomem
> *ioaddr,
> >  		value |=3D XGMAC_EAME;
> >
> >  	writel(value, ioaddr + XGMAC_DMA_SYSBUS_MODE);
> > +
> > +	if (dma_cfg->multi_irq_en) {
> > +		value =3D readl(ioaddr + XGMAC_DMA_MODE);
> > +		value &=3D ~XGMAC_DMA_MODE_INTM_MASK;
> > +		value |=3D (XGMAC_DMA_MODE_INTM_MODE1 <<
> XGMAC_DMA_MODE_INTM_SHIFT);
> > +		writel(value, ioaddr + XGMAC_DMA_MODE);
> > +	}
> >  }
> >
> >  static void dwxgmac2_dma_init_chan(struct stmmac_priv *priv, @@
> > -365,19 +372,18 @@ static int dwxgmac2_dma_interrupt(struct
> stmmac_priv *priv,
> >  	}
> >
> >  	/* TX/RX NORMAL interrupts */
> > -	if (likely(intr_status & XGMAC_NIS)) {
> > -		if (likely(intr_status & XGMAC_RI)) {
> > -			u64_stats_update_begin(&rxq_stats->syncp);
> > -			rxq_stats->rx_normal_irq_n++;
> > -			u64_stats_update_end(&rxq_stats->syncp);
> > -			ret |=3D handle_rx;
> > -		}
> > -		if (likely(intr_status & (XGMAC_TI | XGMAC_TBU))) {
> > -			u64_stats_update_begin(&txq_stats->syncp);
> > -			txq_stats->tx_normal_irq_n++;
> > -			u64_stats_update_end(&txq_stats->syncp);
> > -			ret |=3D handle_tx;
> > -		}
> > +	if (likely(intr_status & XGMAC_RI)) {
> > +		u64_stats_update_begin(&rxq_stats->syncp);
> > +		rxq_stats->rx_normal_irq_n++;
> > +		u64_stats_update_end(&rxq_stats->syncp);
> > +		ret |=3D handle_rx;
> > +	}
> > +
> > +	if (likely(intr_status & (XGMAC_TI | XGMAC_TBU))) {
> > +		u64_stats_update_begin(&txq_stats->syncp);
> > +		txq_stats->tx_normal_irq_n++;
> > +		u64_stats_update_end(&txq_stats->syncp);
> > +		ret |=3D handle_tx;
> >  	}
> >
> >  	/* Clear interrupts */
> > --
> > 2.34.1
> >
> >