Received-SPF: pass (google.com: domain of linux-kernel+bounces-21741-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 9 Jan 2024 22:14:47 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Kuan-Wei Chiu <visitorckw@gmail.com>
Cc: irogers@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] lib min_heap: Min heap optimizations
Message-Id: <20240109221447.3d5e8878b0d6424d26666be5@linux-foundation.org>
In-Reply-To: <20240103205259.2108410-1-visitorckw@gmail.com>
References: <20240103205259.2108410-1-visitorckw@gmail.com>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu,  4 Jan 2024 04:52:57 +0800 Kuan-Wei Chiu <visitorckw@gmail.com> wrote:

> Hello,
> 
> The purpose of this patch series is to enhance the existing min heap
> implementation. The optimization focuses on both the heap construction
> process and the number of comparisons made during the heapify
> operation.
> 

The patches look nice, but the only user of this code is
kernel/events/core.c and the developers of that code aren't cc'ed, so
please rectify that.

Has Ian commented on these changes?

The amount of inlining in min_heap.h is amazing.  Was there some
special reason for this?  It makes min_heap somewhat unsuitable for
more general use.