Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp811051rdd; Tue, 9 Jan 2024 23:24:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IFE4yTZTkrtlhQXTRNoJijk6sUIFai8G/XrupRGPee8kIykL9oQF7nYMRgS/vlB1xwBd03Z X-Received: by 2002:ac8:5842:0:b0:429:92de:bd06 with SMTP id h2-20020ac85842000000b0042992debd06mr798769qth.19.1704871472135; Tue, 09 Jan 2024 23:24:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704871472; cv=none; d=google.com; s=arc-20160816; b=cEdxwqLTyOqU40QywbKFWIaiyObGLyKBFgJoJgCL1YiA4IccLW0Pn5g76N+yHPxe4m ujsEhLURJYsXG7eKsLNwdWZpObN6g2RxUrbKndBpHTeihkHvxky1I5qF7tjlQLRol0iL f1D1o+CBmBsphTJAfpbzr0LN8x/l+x4AlzUgoUf7YQ/pDWp+hLfU1ZL8Z3dCwkNe/gmj E7XZ3DhbSszMcdyA3ZWym0OveiVyO/02cOSphPHzBRBiy2JAkbIbaD/e2Xa1dcOA6W+a rV68B/XF6ZzW7VfZEtMXgYCfRoovImrrcOycBEmJxrIkxAFJ1BSVb0/DN9kYGLKQ+9lZ xduQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=Azmp4KYfdL3dOyr5tehq9G4ZZFHnH/CcRj4pQ5xag0A=; fh=rGSg19jQQ7YAGk1hdJ9Uu09akFimk01UAl5Z/6SQ3MU=; b=Jk5wadBL32UIIcwWuIodbVVxw4yDjz+1ZL1lCqzqSe/yr2etd6D/K/QlSwtqws/QTV 0XG0/UNV8RXwGSdz7sMX4uZpj+PA7jgCKYOlkK8D/YCGjWwgvIwJGvwUr2GNjBXeyfPe NfSlEstYnxFXr/o8CrmXoiuWyBwmxcUOcN6wwzFS2d9WZ6DB5kInCepan3HorisG6j5d qpGbvcJGiaPc0/WQQMJ73HTh6cGwKfhDiwRjljL7C4RK+2wahGETnXpytAjJB6uUUH20 S0ZPojO6apXlqhVwx5ltpS6TEl4LD3EStHWTK3zcTXe8hJ+PdVLI8vpDZ+MQl3Wgz/ft OHyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NhPCxOn4; spf=pass (google.com: domain of linux-kernel+bounces-21783-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-21783-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id c18-20020a05622a059200b00429a50c4264si2986416qtb.619.2024.01.09.23.24.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 23:24:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-21783-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NhPCxOn4; spf=pass (google.com: domain of linux-kernel+bounces-21783-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-21783-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D1F7B1C24011 for ; Wed, 10 Jan 2024 07:24:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7891A39AF5; Wed, 10 Jan 2024 07:24:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NhPCxOn4" Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F6743D98C for ; Wed, 10 Jan 2024 07:24:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a28ee72913aso837968266b.1 for ; Tue, 09 Jan 2024 23:24:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704871460; x=1705476260; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Azmp4KYfdL3dOyr5tehq9G4ZZFHnH/CcRj4pQ5xag0A=; b=NhPCxOn4BS6id78e+bjmeqbUXcjXPsK6QqFPeMp954JI7pFXs6qtfZ6nM5RreyN1xx KUCE/3VsxKdAd9MwZLecl6Lch/Fkp31QncQj3+l7hD6dwp9MuBc+k8VyOmWv3vC0kvcq B3GgoDgfFOhK3Zywp0KStLGpTuvGZ0gKOZUFEeko+eSq/zn5rDiau6e9U3FRlBMsUx74 b3OdBOHc34SE2UoSI131IiGgBl4R4un+IOW8Cq1iSWsPfh4mlim/NUV1sqOOUzUMINWv Vahr7pzkFXpgm8cJmDyHttqnXRWRUHePuHULyfoAPdoYxLjwQwO10fzp4khIUVB0d5zE tKoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704871460; x=1705476260; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Azmp4KYfdL3dOyr5tehq9G4ZZFHnH/CcRj4pQ5xag0A=; b=uEKy5jWtilOE00fIo5LoDY3sNBJqV23MAHXSeZmrCRYmBAYCL2wcXQqj5VtoFu746o ysW8EBR4ucQALLYYH1+CPGpBh1+cHPzNHLO/miARVXYR+biUOfqoSVO/N9Farpq841L0 jX+XByWJtF1S3eEwLO166t4aYEF7w4uVHt8sszuRYshHElJHWpHwBwb0uVOzIld3g40t ai5BsZyNa5pCWYPz7iWpYU/wy26iDwTXT4bZKi37HaxEVZjO2XEbDtScCXFHqSgeyZML XXXqjHMm7bgpXXfcTeqZwtHseoeGuuv8hGVVMSx185Pku/XMVnA3jAbqriq2J0cfv+oU vHhQ== X-Gm-Message-State: AOJu0YzPYNnavCfiRsq4Bichi+nnISWeJYgorRfqxZrkWP9GO/C6+0yC KuXTFpvKOU6FMPpuVShyzEidoMrtqNsCLw== X-Received: by 2002:a17:907:77c1:b0:a2a:19eb:9144 with SMTP id kz1-20020a17090777c100b00a2a19eb9144mr2067875ejc.1.1704871460370; Tue, 09 Jan 2024 23:24:20 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.112]) by smtp.gmail.com with ESMTPSA id p11-20020a170906140b00b00a26b3f29f3dsm1801270ejc.43.2024.01.09.23.24.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jan 2024 23:24:19 -0800 (PST) Message-ID: <36531917-7319-40d5-a5d9-1b5977be7849@linaro.org> Date: Wed, 10 Jan 2024 08:24:17 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/4] dt-bindings: soc: sophgo: Add Sophgo system control module Content-Language: en-US To: Chen Wang , Chen Wang , aou@eecs.berkeley.edu, chao.wei@sophgo.com, conor@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, palmer@dabbelt.com, paul.walmsley@sifive.com, richardcochran@gmail.com, robh+dt@kernel.org, sboyd@kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, haijiao.liu@sophgo.com, xiaoguang.xing@sophgo.com, guoren@kernel.org, jszhang@kernel.org, inochiama@outlook.com, samuel.holland@sifive.com References: <1e1ef0a0-6639-4a4d-9b4e-50bcee3fb3c5@linaro.org> <60abfdcc-3d61-4df1-b77b-23d4a5d26a46@linaro.org> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/01/2024 01:44, Chen Wang wrote: >>> clocks." may cause misunderstanding. I plan to change it to "The Sophgo >>> SG2042 SoC system controller provides register information such as >>> offset, mask and shift to configure related modules such as clock." Is >>> this better? >>> >> Still does not make sense. To provide "offset" means that some other >> hardware reads sophgo module to get the value of offset. That's not the >> case here. > > I'm probably starting to understand what you mean. How about changing it > to the following? > > The Sophgo system controller is a registers block, providing multiple > low level platform functions like chip configuration, clock control, etc. Yes, that sounds good. Best regards, Krzysztof