Received-SPF: pass (google.com: domain of linux-kernel+bounces-21791-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <e3941caa-7546-415f-be7b-b955cf13aa8b@infradead.org>
Date: Tue, 9 Jan 2024 23:30:17 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] staging: vt6655: fix open parentheses alignment
Content-Language: en-US
To: Matthias Yee <mgyee9@gmail.com>, gregkh@linuxfoundation.org
Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev,
 linux-kernel@vger.kernel.org
References: <20240110072304.2226-1-mgyee9@gmail.com>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20240110072304.2226-1-mgyee9@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Greg, Dan,


On 1/9/24 23:23, Matthias Yee wrote:
> Adjusted whitespace to fix checkpatch warning Alignment Should Match
> Open Parenthesis.
> 
> Signed-off-by: Matthias Yee <mgyee9@gmail.com>
> ---
> Changes in v3
> -fixed line wrapping for commit message
> ---
>  drivers/staging/vt6655/card.c | 74 +++++++++++++++++------------------
>  1 file changed, 37 insertions(+), 37 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> index 36183f2a64c1..688c870d89bc 100644
> --- a/drivers/staging/vt6655/card.c
> +++ b/drivers/staging/vt6655/card.c
> @@ -81,9 +81,9 @@ static void vt6655_mac_set_bb_type(void __iomem *iobase, u32 mask)
>   * Return Value: none
>   */
>  static void calculate_ofdmr_parameter(unsigned char rate,
> -				       u8 bb_type,
> -				       unsigned char *tx_rate,
> -				       unsigned char *rsv_time)
> +				      u8 bb_type,
> +				      unsigned char *tx_rate,
> +				      unsigned char *rsv_time)
>  {
>  	switch (rate) {
>  	case RATE_6M:

Is there any chance that checkpatch is wrong about this warning?

I much prefer the alignment as it was before this patch: following lines
are aligned with the first parameter after the '('.


-- 
#Randy