Received-SPF: pass (google.com: domain of linux-kernel+bounces-21802-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 10 Jan 2024 10:51:39 +0300
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Matthias Yee <mgyee9@gmail.com>, gregkh@linuxfoundation.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: vt6655: fix open parentheses alignment
Message-ID: <f22e751e-863a-46a9-8dd6-0ac55f1ad9c8@moroto.mountain>
References: <20240110072304.2226-1-mgyee9@gmail.com>
 <e3941caa-7546-415f-be7b-b955cf13aa8b@infradead.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e3941caa-7546-415f-be7b-b955cf13aa8b@infradead.org>

On Tue, Jan 09, 2024 at 11:30:17PM -0800, Randy Dunlap wrote:
> > diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> > index 36183f2a64c1..688c870d89bc 100644
> > --- a/drivers/staging/vt6655/card.c
> > +++ b/drivers/staging/vt6655/card.c
> > @@ -81,9 +81,9 @@ static void vt6655_mac_set_bb_type(void __iomem *iobase, u32 mask)
> >   * Return Value: none
> >   */
> >  static void calculate_ofdmr_parameter(unsigned char rate,
> > -				       u8 bb_type,
> > -				       unsigned char *tx_rate,
> > -				       unsigned char *rsv_time)
> > +				      u8 bb_type,
> > +				      unsigned char *tx_rate,
> > +				      unsigned char *rsv_time)
> >  {
> >  	switch (rate) {
> >  	case RATE_6M:
> 
> Is there any chance that checkpatch is wrong about this warning?
> 
> I much prefer the alignment as it was before this patch: following lines
> are aligned with the first parameter after the '('.
> 

It just looks weird in the diff because of the + character at the front
and how the tabs work out.  It looks ok in the code.

regards,
dan carpenter