Received-SPF: pass (google.com: domain of linux-kernel+bounces-21806-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <9fdcb306-862f-4ad5-a52f-cd70fd21cf05@infradead.org>
Date: Tue, 9 Jan 2024 23:56:30 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] staging: vt6655: fix open parentheses alignment
Content-Language: en-US
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Matthias Yee <mgyee9@gmail.com>, gregkh@linuxfoundation.org,
 linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20240110072304.2226-1-mgyee9@gmail.com>
 <e3941caa-7546-415f-be7b-b955cf13aa8b@infradead.org>
 <f22e751e-863a-46a9-8dd6-0ac55f1ad9c8@moroto.mountain>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <f22e751e-863a-46a9-8dd6-0ac55f1ad9c8@moroto.mountain>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 1/9/24 23:51, Dan Carpenter wrote:
> On Tue, Jan 09, 2024 at 11:30:17PM -0800, Randy Dunlap wrote:
>>> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
>>> index 36183f2a64c1..688c870d89bc 100644
>>> --- a/drivers/staging/vt6655/card.c
>>> +++ b/drivers/staging/vt6655/card.c
>>> @@ -81,9 +81,9 @@ static void vt6655_mac_set_bb_type(void __iomem *iobase, u32 mask)
>>>   * Return Value: none
>>>   */
>>>  static void calculate_ofdmr_parameter(unsigned char rate,
>>> -				       u8 bb_type,
>>> -				       unsigned char *tx_rate,
>>> -				       unsigned char *rsv_time)
>>> +				      u8 bb_type,
>>> +				      unsigned char *tx_rate,
>>> +				      unsigned char *rsv_time)
>>>  {
>>>  	switch (rate) {
>>>  	case RATE_6M:
>>
>> Is there any chance that checkpatch is wrong about this warning?
>>
>> I much prefer the alignment as it was before this patch: following lines
>> are aligned with the first parameter after the '('.
>>
> 
> It just looks weird in the diff because of the + character at the front
> and how the tabs work out.  It looks ok in the code.

Oops, sorry, you are correct. Thanks!

-- 
#Randy