Received-SPF: pass (google.com: domain of linux-kernel+bounces-21857-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 10 Jan 2024 09:41:54 +0100
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/8] intel_th: Convert to platform remove callback
 returning void
Message-ID: <i3oybmf3axeyk5rcef5kgfdb4cucd63h24gup6idn62nq3vvav@4mfzwzyamq27>
References: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de>
 <20231107202818.4005791-8-u.kleine-koenig@pengutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="udfj5iy5oa67vvel"
Content-Disposition: inline
In-Reply-To: <20231107202818.4005791-8-u.kleine-koenig@pengutronix.de>


--udfj5iy5oa67vvel
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Tue, Nov 07, 2023 at 09:28:26PM +0100, Uwe Kleine-K=F6nig wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>=20
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>=20
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>=20
> Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

I didn't get any feedback to this patch and it didn't make it into next
up to now.

Is this still on someone's radar?

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--udfj5iy5oa67vvel
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmWeWFEACgkQj4D7WH0S
/k7UWgf/RLMfq+wxJ+Cwqxm4qXNH66VIuLfGOSBYDNSfDJpyT2Wf9H7bemLV4LcN
CvsLLgTdjsBNFXZulOfPQ6PQB5y/pInYMkCBdIMHCehuo4t/ukAbngWwmhPgdEsY
HG2RvnS5P+AWmqJpM+VU3yrtq0em0uC4eO1GZEjO/QpNi52k5f9uqlNw8GB9QIdM
icVuI1ou184sbALt5o1BwexrNQuLbqdeGhjBicUtECV7HMKhpWIq+D3ghjNX6UoN
k0uEFfH4pr+TogOqLobsnFY09Ymx9FELzBX0jR+BZGOBx6eO0/v7Zu7O8UVrkxzl
nlDWQAH4Mb+o9LjvsIt8lrz1gWokkg==
=qTc0
-----END PGP SIGNATURE-----

--udfj5iy5oa67vvel--