Received-SPF: pass (google.com: domain of linux-kernel+bounces-21864-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <3794475b-8478-47f0-91e4-ef493876a2e3@gmx.net>
Date: Wed, 10 Jan 2024 09:49:16 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] serial: 8250_bcm2835aux: Restore clock error handling
To: Jeremy Linton <jeremy.linton@arm.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Jiri Slaby <jirislaby@kernel.org>,
 Florian Fainelli <florian.fainelli@broadcom.com>
Cc: Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>,
 Adrien Thierry <athierry@redhat.com>, linux-serial@vger.kernel.org,
 bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org
References: <20231220114334.4712-1-wahrenst@gmx.net>
 <1b0de096-101a-9764-0396-d8b86878badf@arm.com>
Content-Language: en-US
From: Stefan Wahren <wahrenst@gmx.net>
In-Reply-To: <1b0de096-101a-9764-0396-d8b86878badf@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:fP5lHLrN6wU=;n6VAKI+CAS+mBnl+UmFnP5q+9Pr
 FYOxDBcqkWO2Zd9vRJe99JFze4jPTeALRCRMelnc3shgUWDuWHANvNX5R/kxkKp0nxjbZgxPL
 +xXlbJSErbaO0lP+iigXzLtmEeL4x42NLxP9LSqAyEgkxJ2U8UGVfC7EhOjAM7NWSuBCmqNP4
 zLKvSQDZ38hiX75/ESLFfyu+cY1Ax+cdDbJWgizqLr2e/q+dbNpWrRIIEmehO7Ujsojfd1pL2
 MZH8WMdX8EE/4vCNRtgzdGgoLUC9SCpF81OsNLvOE79knc2AyvVSONySYncZd9CgwL74v8Vmr
 qu/6W/UoONuuaa4dbCw16GoEDGbVtxFuYrOsoWoFRe8iVxwzk58b7SNT33vDG1F1LfUmCfBKR
 IxcVUx6najOEpv3ApfNpgII3WABMipXUt35k7VcQAGwkIJSnfhIRYsTtTwNWlXD6khqJjCcQ7
 7dbvm4orATr62nhLBdURyaZ8+9xndPsPipNtxSexSpu2K4qXNN216bJZAgZ8aLrJoAt8/ttdA
 QkeQGgjL71h6EMToL2GR6wm6J/C+7Cr6MOJp3u27jXRj9RfBCNbccTww8bZKKWyw4zZ0qN/E7
 x3FTkc44swB5KrtJAZXHzTAGgI1XPtd0GSDT49f1fka94Fd2i/9dqRRFMXBMj9b3LH7GhPhP9
 5yHU2jboanFOQtF4ub6uu+sn7CmVXbq75rVVJTSW2i8Sijd6Z8iAxn0KPPJM/FEvG7JLVTBlP
 p9//nFC0m4tngInUvElFkE0Mt0+IFQqaYhaekKf+CF46A8Hfku601nKJPGnmaN+x/526v1PCG
 4ajPZmeuOdV+Dp65AhYY5qbxn4IRmjIV5M9JHPmVGlNheRtuYAbN45+9YkZaX4ZumLFxfQgjl
 OtNPsFExI7NRC67ktoukLsw46uj/HEis67TbWsyu3QbnjshG7WL36YRyvR1s5kIvV6n6ZmmXf
 cHROKg0Pb2k6ghSELkNnei+0nwY=

Hi Jeremy,

Am 10.01.24 um 01:01 schrieb Jeremy Linton:
> Hi,
>
>
> On 12/20/23 05:43, Stefan Wahren wrote:
>> The commit fcc446c8aa63 ("serial: 8250_bcm2835aux: Add ACPI support")
>> dropped the error handling for clock acquiring. But even an optional
>> clock needs this.
>
> Right, the call was changed to _optional() during review but the error
> handling didn't get put back.
>
>>
>> Fixes: fcc446c8aa63 ("serial: 8250_bcm2835aux: Add ACPI support")
>> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
>> ---
>> =C2=A0 drivers/tty/serial/8250/8250_bcm2835aux.c | 2 ++
>> =C2=A0 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/tty/serial/8250/8250_bcm2835aux.c
>> b/drivers/tty/serial/8250/8250_bcm2835aux.c
>> index 15a2387a5b25..4f4502fb5454 100644
>> --- a/drivers/tty/serial/8250/8250_bcm2835aux.c
>> +++ b/drivers/tty/serial/8250/8250_bcm2835aux.c
>> @@ -119,6 +119,8 @@ static int bcm2835aux_serial_probe(struct
>> platform_device *pdev)
>>
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* get the clock - this also enables the=
 HW */
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 data->clk =3D devm_clk_get_optional(&pde=
v->dev, NULL);
>> +=C2=A0=C2=A0=C2=A0 if (IS_ERR(data->clk))
>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return dev_err_probe(&pdev-=
>dev, PTR_ERR(data->clk), "could
>> not get clk\n");
>>
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* get the interrupt */
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ret =3D platform_get_irq(pdev, 0);
>> --
>
> And on ACPI machines it returns NULL, which passes the error check
> now, so it works on an ACPI based pi.
>
> Thanks!
>
> Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
> Tested-by: Jeremy Linton <jeremy.linton@arm.com>

thanks for testing. The patch is already in linux-next.

Regards