Received-SPF: pass (google.com: domain of linux-kernel+bounces-21915-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Subject: Re: [PATCH net-next v2] page_pool: Rename frag_users to pagecnt_bias
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>, Jakub Kicinski
	<kuba@kernel.org>
CC: <netdev@vger.kernel.org>, Jesper Dangaard Brouer <hawk@kernel.org>, "David
 S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Paolo
 Abeni <pabeni@redhat.com>, <linux-kernel@vger.kernel.org>
References: <20231220080147.740134-1-ilias.apalodimas@linaro.org>
 <20240102153547.58b23d35@kernel.org>
 <CAC_iWj+VM1vCDygvXkd6snuSO64iQCm48oahYa4wQQeM3QXiFg@mail.gmail.com>
From: Yunsheng Lin <linyunsheng@huawei.com>
Message-ID: <c3e38ed8-e8eb-c079-3f3d-81455cf96db2@huawei.com>
Date: Wed, 10 Jan 2024 17:46:03 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <CAC_iWj+VM1vCDygvXkd6snuSO64iQCm48oahYa4wQQeM3QXiFg@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 2024/1/9 15:02, Ilias Apalodimas wrote:
> Hi Jakub,
> 
> On Wed, 3 Jan 2024 at 01:35, Jakub Kicinski <kuba@kernel.org> wrote:
>>
>> On Wed, 20 Dec 2023 10:01:46 +0200 Ilias Apalodimas wrote:
>>> -     long frag_users;
>>> +     long pagecnt_bias;
>>
>> IDK :(
>>
>> pagecnt to mean suggests this is related to page refcount,
>> not page pool specific refcount.
>>
>> More importantly bias is the large number by which we increment.
>> This counter counts how many of the bias references we actually
>> consumed. So how about bias_consumed? bias_used? bias_issued?
>> frags_alloced?
> 
> I had similar concerns, that's why v1 used 'frag_cnt'.
> I am fine with either frags_alloced or frag_cnt

I would suggest that we stick with the *_bias version, and invert the
logic of draining, so that:
1. Aovid one subtraction operation in the data path.
2. Align with other frag implementation.

I guess I can do the above if that is ok with Ilias.

> 
> Thanks
> /Ilias
> .
>