Received-SPF: pass (google.com: domain of linux-kernel+bounces-21961-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <8ce0d90d-c751-4250-8656-fcab27aec6c2@amd.com>
Date: Wed, 10 Jan 2024 11:19:37 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] drm/virtio: Implement device_attach
Content-Language: en-US
To: Julia Zhang <julia.zhang@amd.com>,
 Gurchetan Singh <gurchetansingh@chromium.org>, Chia-I Wu
 <olvaffe@gmail.com>, David Airlie <airlied@redhat.com>,
 Gerd Hoffmann <kraxel@redhat.com>, linux-kernel@vger.kernel.org,
 dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
 virtualization@lists.linux-foundation.org
Cc: Alex Deucher <alexander.deucher@amd.com>, Daniel Vetter
 <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
 Erik Faye-Lund <kusmabite@gmail.com>, =?UTF-8?B?TWFyZWsgT2zFocOhaw==?=
 <marek.olsak@amd.com>,
 Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,
 Honglei Huang <honglei1.huang@amd.com>, Chen Jiqian <Jiqian.Chen@amd.com>,
 Huang Rui <ray.huang@amd.com>
References: <20240110095627.227454-1-julia.zhang@amd.com>
 <20240110095627.227454-2-julia.zhang@amd.com>
From: =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
In-Reply-To: <20240110095627.227454-2-julia.zhang@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aXcrQ2FuRVVJMTJNRmFzVDdDQWU4WU5Obk9wRkJadkRXWGdocmRONGRyNGJD?=
 =?utf-8?B?RWVhUEFHeFFVVkRLd3BVSkpGc05uZnBhci9vUHM2Y3NETWNtUVpWUVErbG81?=
 =?utf-8?B?Y0piTzlCSVZBTUJTYmQ3OUFlZUkxaUFPOEh3ZUo0eWc4dTFobWM3LzhLSDdR?=
 =?utf-8?B?MHUwWHVveWtPTG5xeXFsRyt6RDd1YkpiWVRaTnI3cHNvTWdaa1lzVDNoZTFq?=
 =?utf-8?B?MGhwbmdwRVNlcHBXQ25sZmdNd056czREOW9pM1RtaThhMURraUNtT3F3b01x?=
 =?utf-8?B?Sm1nZjllM0YwRXd2RTJDRXBoclhSTFRUZ1RGMnRYZHlReWRDVndJaVlYL0o5?=
 =?utf-8?B?SnlEQU9pSlBpeDZ3Wi81UVpacjNXayt6cGNqRTNybDEzRlJ3ODRYRnpBUUhN?=
 =?utf-8?B?dEN1dkw0M3NlajRBRkt6dlVVUnZ4ejhmL0tzNXk4cktNMjdBYS96amVtRlcx?=
 =?utf-8?B?VGVWZUxydGlxRkcvUmdzeGdad0gvZmZlVWhJekFhQlBmeXVXNWl0NlRLYi82?=
 =?utf-8?B?TFAyQ0ZmVTMrVHQzckQzbFR2MTE0Wi9adFMyZzlmbndBbHQ2YlpMYU1YNjg4?=
 =?utf-8?B?WGcwNUVrVjJud096R1h4bWdpaXhoRmpEeEp1VjN5QU4wSFlFU040THNsbzhp?=
 =?utf-8?B?NTEvbDlFUzl4czVBaDRZQVRVNjJpSGxNR3ppcGVpOC9lbnZCRk91Z0VmbkF2?=
 =?utf-8?B?czA1NVB2OG5YQjI1WHRUMGFRMm9FanpJWGM0ZlN6YWwvMnZMdGwwY2ZYOGpq?=
 =?utf-8?B?VW1iWEhJTzBjVUtpVTRjOTQ2a2NnNDc3MlFGUVY5TEM0eVZ5eXZxOWJtWVJh?=
 =?utf-8?B?UUZFU2FqdXdQQzFSYUZMcG5kamIxc2FrZ0JkT2JNVFdkYmRMT3o5cDJnRjhV?=
 =?utf-8?B?bTRtY3RQMWk2M3ZtRm4rRGpsZHRKSEswckkyU1UycGFsbXJJN3dzOUl3dXk1?=
 =?utf-8?B?V1Nvb2dVZ1pwdUpLZ0I5eUdBbDFLc2pQeFhUYVo1N1QydzhIVUgzUFN2UmRn?=
 =?utf-8?B?MTI5MksrTHNWSkg4OXZYanIwQzdzYjlLa0h5bGQwODB3OUxpekVFZFMyRVhM?=
 =?utf-8?B?SklURjV4Z3FhNjlMZ0ZRVml1Ty9pZDBJV1NQV0pRQmdxaElLaFQzL3hiL3Mv?=
 =?utf-8?B?Y3hUa3RGWTVpMXpRdEx0Uk5nbGdpTldGcENnbFc3Y05QQkxROVBkaVlCR0lO?=
 =?utf-8?B?UTJtMWxESW93aFFFa3I2UzdVUU1keWN5MnBYMi92YmtUYURmc0dGOG9XcHB3?=
 =?utf-8?B?bUNnb3F5V0dqSXZIU3BUNFJsZEdkUWpzdUtOdjNGUTBzTXRkZVI5d1FiNVFt?=
 =?utf-8?B?L1JyWldFdUJoZ045ZVc2MmpSVUN1NkNXRCs5NEFDbmc5bnVXZGNiQ3ZGc1VM?=
 =?utf-8?B?RUtkQWk1RjJUWE9EYjZ0Ui85YWZNc3doSy8zMzFZdmRXa2tCTkJMU2UxSVdn?=
 =?utf-8?B?K2VKMkZ2ZHBFZVF3OWE1dWZMY0tRK25nYnpTckdFNldjNmE5SFAxWmc3UVNw?=
 =?utf-8?B?d25VWFdoajk3RktCSFoxSVZEUzFQcCt4RlN6bHdTeGFiY2FyL0l0d2tzS2U2?=
 =?utf-8?B?TzlxU2ltSmwwdUNDVDNKRjhISHZLNm45Nmo5cDVtR2Q5cEFnbmN0YjkwbUJt?=
 =?utf-8?B?QjZOc0dESTdsWUF6TmNwSnZMcTE1eE5GbDIreGdUakk5OGJkUTJIVXQ0Q2pV?=
 =?utf-8?B?dk8xQlE0YjdCTElIcnhlRzZRTUhDNnBSc1ZXSjZLTE5DZ1c5R2F6U000aVdC?=
 =?utf-8?B?eGtNaDZOLyszeFhXdWhwQ09aM2lVWFFGaUprbW9KTER2ZnlyeWZNa3F1OE5i?=
 =?utf-8?B?SElXZDV0ZzE0aHpDY242b05xUDNHdFlNajdLQjl1a21KM1pFTEgyRFhFc3BY?=
 =?utf-8?B?anhUMUQ0Nm9kYk1JNko3c3d3a0lVZVdaekRoMXlpYXE0Y29hNmxmM1k4UU1t?=
 =?utf-8?B?M21Id3FpY0VlNXNOTWlkQWxmaTBRQUZOVmxJa3pUV1pQV1pPZ25xcXowbTZq?=
 =?utf-8?B?NFN4RGJzdHlVemNSSUxMb2xqaHFrTWttWXVoNHNBVjYrQWd6QUdabVVLUk1N?=
 =?utf-8?B?ZDlFVElaZ05mVldOdStZMzcwMEgrWkNkSU1xRnA4WlJwbU4wOEFuaTU0QzlH?=
 =?utf-8?Q?2qe7TfjRAZwErJhjq7aa74ZjU?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 769097ee-2eb6-4e11-559a-08dc11c5aaf8
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5685.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2024 10:19:45.5885
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L/beyhPHjmUj0RRVGCtxaMrq6lEGlJ9Cb1HDUhg5rkqbSQUteIAoVKqeKju1xU26
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8263

Am 10.01.24 um 10:56 schrieb Julia Zhang:
> drm_gem_map_attach() requires drm_gem_object_funcs.get_sg_table to be
> implemented, or else return ENOSYS. Virtio has no get_sg_table
> implemented for vram object. To fix this, add a new device_attach to
> call drm_gem_map_attach() for shmem object and return 0 for vram object
> instead of calling drm_gem_map_attach for both of these two kinds of
> object.

Well as far as I can see this is nonsense from the DMA-buf side of things.

SG tables are always needed as long as you don't re-import the same 
object into your driver and then you shouldn't end up in this function 
in the first place.

So that drm_gem_map_attach() requires get_sg_table to be implemented is 
intentional and should never be overridden like this.

Regards,
Christian.

>
> Signed-off-by: Julia Zhang <julia.zhang@amd.com>
> ---
>   drivers/gpu/drm/virtio/virtgpu_prime.c | 14 +++++++++++++-
>   1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_prime.c b/drivers/gpu/drm/virtio/virtgpu_prime.c
> index 44425f20d91a..f0b0ff6f3813 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_prime.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_prime.c
> @@ -71,6 +71,18 @@ static void virtgpu_gem_unmap_dma_buf(struct dma_buf_attachment *attach,
>   	drm_gem_unmap_dma_buf(attach, sgt, dir);
>   }
>   
> +static int virtgpu_gem_device_attach(struct dma_buf *dma_buf,
> +				     struct dma_buf_attachment *attach)
> +{
> +	struct drm_gem_object *obj = attach->dmabuf->priv;
> +	struct virtio_gpu_object *bo = gem_to_virtio_gpu_obj(obj);
> +
> +	if (virtio_gpu_is_vram(bo))
> +		return 0;
> +
> +	return drm_gem_map_attach(dma_buf, attach);
> +}
> +
>   static const struct virtio_dma_buf_ops virtgpu_dmabuf_ops =  {
>   	.ops = {
>   		.cache_sgt_mapping = true,
> @@ -83,7 +95,7 @@ static const struct virtio_dma_buf_ops virtgpu_dmabuf_ops =  {
>   		.vmap = drm_gem_dmabuf_vmap,
>   		.vunmap = drm_gem_dmabuf_vunmap,
>   	},
> -	.device_attach = drm_gem_map_attach,
> +	.device_attach = virtgpu_gem_device_attach,
>   	.get_uuid = virtgpu_virtio_get_uuid,
>   };
>