Received-SPF: pass (google.com: domain of linux-kernel+bounces-22171-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Shradha Todi'" <shradha.t@samsung.com>, <linux-clk@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <linux-samsung-soc@vger.kernel.org>
Cc: <mturquette@baylibre.com>, <sboyd@kernel.org>, <jingoohan1@gmail.com>,
	<lpieralisi@kernel.org>, <kw@linux.com>, <robh@kernel.org>,
	<bhelgaas@google.com>, <krzysztof.kozlowski@linaro.org>,
	<linux@armlinux.org.uk>, <m.szyprowski@samsung.com>,
	<manivannan.sadhasivam@linaro.org>, <alim.akhtar@samsung.com>
In-Reply-To: <20240110110115.56270-2-shradha.t@samsung.com>
Subject: RE: [PATCH v3 1/2] clk: Provide managed helper to get and enable
 bulk clocks
Date: Wed, 10 Jan 2024 18:01:14 +0530
Message-ID: <001001da43c0$e8e9a8e0$babcfaa0$@samsung.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQK3Yhu837gawrdP2S3E1hwP53Jf7wFhoUR7AWI/r/mvApvyoA==
Content-Language: en-us
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20240110110115.56270-1-shradha.t@samsung.com>
	<CGME20240110110156epcas5p36bac4093be0fa6eaa501d7eaed4d43d3@epcas5p3.samsung.com>
	<20240110110115.56270-2-shradha.t@samsung.com>

Hi Shradha,

> -----Original Message-----
> From: Shradha Todi <shradha.t=40samsung.com>
> Sent: Wednesday, January 10, 2024 4:31 PM
> To: linux-clk=40vger.kernel.org; linux-kernel=40vger.kernel.org; linux-
> pci=40vger.kernel.org; linux-arm-kernel=40lists.infradead.org; linux-sams=
ung-
> soc=40vger.kernel.org
> Cc: mturquette=40baylibre.com; sboyd=40kernel.org; jingoohan1=40gmail.com=
;
> lpieralisi=40kernel.org; kw=40linux.com; robh=40kernel.org;
> bhelgaas=40google.com; krzysztof.kozlowski=40linaro.org;
> alim.akhtar=40samsung.com; linux=40armlinux.org.uk;
> m.szyprowski=40samsung.com; manivannan.sadhasivam=40linaro.org; Shradha
> Todi <shradha.t=40samsung.com>
> Subject: =5BPATCH v3 1/2=5D clk: Provide managed helper to get and enable=
 bulk
> clocks
>=20
> Provide a managed devm_clk_bulk* wrapper to get and enable all bulk clock=
s
> in order to simplify drivers that keeps all clocks enabled for the time o=
f driver
> operation.
>=20
> Suggested-by: Marek Szyprowski <m.szyprowski=40samsung.com>
> Signed-off-by: Shradha Todi <shradha.t=40samsung.com>
> ---
>  drivers/clk/clk-devres.c =7C 41
> ++++++++++++++++++++++++++++++++++++++++
>  include/linux/clk.h      =7C 25 ++++++++++++++++++++++++
>  2 files changed, 66 insertions(+)
>=20
> diff --git a/drivers/clk/clk-devres.c b/drivers/clk/clk-devres.c index
> 4fb4fd4b06bd..05b0ff4bc1d4 100644
> --- a/drivers/clk/clk-devres.c
> +++ b/drivers/clk/clk-devres.c
> =40=40 -102,6 +102,7 =40=40
> EXPORT_SYMBOL_GPL(devm_clk_get_optional_enabled);
>  struct clk_bulk_devres =7B
>  	struct clk_bulk_data *clks;
>  	int num_clks;
> +	void (*exit)(int num_clks, const struct clk_bulk_data *clks);
>  =7D;
>=20
>  static void devm_clk_bulk_release(struct device *dev, void *res) =40=40 =
-182,6
> +183,46 =40=40 int __must_check devm_clk_bulk_get_all(struct device *dev,=
  =7D
> EXPORT_SYMBOL_GPL(devm_clk_bulk_get_all);
>=20
> +static void devm_clk_bulk_release_all_enabled(struct device *dev, void
May be devm_clk_bulk_release_all_disable()

Also this is similar to already existing devm_clk_bulk_release_all(), may b=
e you can reuse this function
And add the exit() callback in devm_clk_bulk_release_all()

> +*res) =7B
> +	struct clk_bulk_devres *devres =3D res;
> +
> +	if (devres->exit)
> +		devres->exit(devres->num_clks, devres->clks);
> +
> +	clk_bulk_put_all(devres->num_clks, devres->clks); =7D
> +
> +int __must_check devm_clk_bulk_get_all_enabled(struct device *dev,

May be devm_clk_bulk_get_all_enable() is more suitable

> +				  struct clk_bulk_data **clks, int *num_clks) =7B
> +	struct clk_bulk_devres *devres;
> +	int ret;
> +
> +	devres =3D devres_alloc(devm_clk_bulk_release_all_enabled,
> +			      sizeof(*devres), GFP_KERNEL);
> +	if (=21devres)
> +		return -ENOMEM;
> +
> +	ret =3D clk_bulk_get_all(dev, &devres->clks);
> +	if (ret > 0) =7B
> +		*clks =3D devres->clks;
> +		devres->num_clks =3D ret;
> +		*num_clks =3D ret;
> +		devres_add(dev, devres);
> +	=7D else =7B
> +		devres_free(devres);
> +		return ret;
> +	=7D
> +
> +	ret =3D clk_bulk_prepare_enable(devres->num_clks, *clks);
> +	if (=21ret)
> +		devres->exit =3D clk_bulk_disable_unprepare;
> +
> +	return ret;
> +=7D
> +EXPORT_SYMBOL_GPL(devm_clk_bulk_get_all_enabled);
> +
>  static int devm_clk_match(struct device *dev, void *res, void *data)  =
=7B
>  	struct clk **c =3D res;
> diff --git a/include/linux/clk.h b/include/linux/clk.h index
> 1ef013324237..bf3e9bee5754 100644
> --- a/include/linux/clk.h
> +++ b/include/linux/clk.h
> =40=40 -438,6 +438,24 =40=40 int __must_check
> devm_clk_bulk_get_optional(struct device *dev, int num_clks,  int
> __must_check devm_clk_bulk_get_all(struct device *dev,
>  				       struct clk_bulk_data **clks);
>=20
> +/**
> + * devm_clk_bulk_get_all_enabled - managed get multiple clk consumers
> and
> + *					enable all clk
> + * =40dev: device for clock =22consumer=22
> + * =40clks: pointer to the clk_bulk_data table of consumer
> + * =40num_clks: out parameter to store the number of clk_bulk_data
> + *
> + * Returns success (0) or negative errno.
> + *
> + * This helper function allows drivers to get several clk
> + * consumers and enable all of them in one operation with management.
> + * The clks will automatically be disabled and freed when the device
> + * is unbound.
> + */
> +
> +int __must_check devm_clk_bulk_get_all_enabled(struct device *dev,
> +				struct clk_bulk_data **clks, int *num_clks);
> +
>  /**
>   * devm_clk_get - lookup and obtain a managed reference to a clock
> producer.
>   * =40dev: device for clock =22consumer=22
> =40=40 -960,6 +978,13 =40=40 static inline int __must_check
> devm_clk_bulk_get_all(struct device *dev,
>  	return 0;
>  =7D
>=20
> +static inline int __must_check devm_clk_bulk_get_all_enabled(struct
> device *dev,
> +				struct clk_bulk_data **clks, int *num_clks) =7B
> +
> +	return 0;
> +=7D
> +
>  static inline struct clk *devm_get_clk_from_child(struct device *dev,
>  				struct device_node *np, const char *con_id)
> =7B
> --
> 2.17.1