Received-SPF: pass (google.com: domain of linux-kernel+bounces-22176-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20231130234048.157509-1-lb@semihalf.com> <20231130234048.157509-11-lb@semihalf.com>
 <69bd53de-0948-469f-ae58-48098af1973c@akamai.com> <CAJfuBxxh7eF+DwMHvy_e6NsNEJ89R6Bqy8Mo5QF8qZwrMsSpgg@mail.gmail.com>
In-Reply-To: <CAJfuBxxh7eF+DwMHvy_e6NsNEJ89R6Bqy8Mo5QF8qZwrMsSpgg@mail.gmail.com>
From: =?UTF-8?Q?=C5=81ukasz_Bartosik?= <lb@semihalf.com>
Date: Wed, 10 Jan 2024 13:40:38 +0100
Message-ID: <CAK8ByeLg7UYA3=bMYyVHQks6RP8FbkuCJ6+q94hk0ZgdQknB7g@mail.gmail.com>
Subject: Re: [PATCH v2 10/15] dyndbg: add open and close commands for trace
To: jim.cromie@gmail.com, Jason Baron <jbaron@akamai.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, Kees Cook <keescook@chromium.org>, 
	Douglas Anderson <dianders@chromium.org>, Guenter Roeck <groeck@google.com>, 
	Yaniv Tzoreff <yanivt@google.com>, Benson Leung <bleung@google.com>, 
	Steven Rostedt <rostedt@goodmis.org>, Vincent Whitchurch <vincent.whitchurch@axis.com>, 
	Pekka Paalanen <ppaalanen@gmail.com>, Sean Paul <seanpaul@chromium.org>, 
	Daniel Vetter <daniel@ffwll.ch>, linux-kernel@vger.kernel.org, upstream@semihalf.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

wt., 9 sty 2024 o 16:20 <jim.cromie@gmail.com> napisa=C5=82(a):
>
> On Fri, Jan 5, 2024 at 3:46=E2=80=AFPM Jason Baron <jbaron@akamai.com> wr=
ote:
> >
> > On 11/30/23 6:40 PM, =C5=81ukasz Bartosik wrote:
> > > Add open and close commands for opening and closing trace instances.
> > > The open command has to be mandatory followed by a trace instance nam=
e.
> > > If a trace instance already exists in <debugfs>/tracing/instances
> > > directory then the open command will reuse it otherwise a new trace
> > > instance with a name provided to the open will be created. Close
> > > command closes previously opened trace instance. The close will
> > > fail if a user tries to close non-existent trace instances or an
> > > instance which was not previously opened.
> > >
> > > For example the following command will open (create or reuse existing=
)
> > > trace instance located in <debugfs>/tracing/instances/usbcore:
> > >
> > >      echo "open usbcore" > <debugfs>/dynamic_debug/control
> >
> > Hi,
> >
> > I'm wondering why this needs to be part of dynamic debug? Can't we make
> > trace instances via 'mkdir' and then use those from the dynamic debug s=
ide?
> >
>
> I believe thats what happens now -
>
> open foo on already opened foo is not an error.
> so if the instance is already created, it just gets used, without
> clearing the buffer.

Yes, I confirm this behavior.

> So it can integrate with externally admin'd tracebufs.
>
> the open foo requirement means that we can validate foo,
> and error properly if it is mis-spelled
>
>
>
> > Thanks,
> >
> > -Jason
> >
> >