Received-SPF: pass (google.com: domain of linux-kernel+bounces-22195-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 10 Jan 2024 12:53:55 +0000
From: Lee Jones <lee@kernel.org>
To: chenxb <chenxb_99091@126.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Fw:[PATCH] mfd: Clean up errors in lm3533.h
Message-ID: <20240110125355.GH7948@google.com>
References: <6415c2b.7f89.18cf3465704.Coremail.chenxb_99091@126.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6415c2b.7f89.18cf3465704.Coremail.chenxb_99091@126.com>

On Wed, 10 Jan 2024, chenxb wrote:

Subject should be:

  "mfd: lm3533: Remove superfluous whitespace in DEVICE_ATTR()

> Fix the following errors reported by checkpatch:
> 
> 

No double line spaces required.

> ERROR: space prohibited before that ',' (ctx:WxW)
> 
> Signed-off-by: GuoHua Chen <XueBing Chen@jari.cn>

That does not look like a correct email address.

> ---
>  include/linux/mfd/lm3533.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/mfd/lm3533.h b/include/linux/mfd/lm3533.h
> index 77092f6363ad..14fde840af67 100644
> --- a/include/linux/mfd/lm3533.h
> +++ b/include/linux/mfd/lm3533.h
> @@ -13,7 +13,7 @@
>  #define LM3533_ATTR_RO(_name) \
>  	DEVICE_ATTR(_name, S_IRUGO, show_##_name, NULL)
>  #define LM3533_ATTR_RW(_name) \
> -	DEVICE_ATTR(_name, S_IRUGO | S_IWUSR , show_##_name, store_##_name)
> +	DEVICE_ATTR(_name, S_IRUGO | S_IWUSR, show_##_name, store_##_name)
>  
>  struct device;
>  struct regmap;
> -- 
> 2.17.1

-- 
Lee Jones [李琼斯]