Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp974509rdd; Wed, 10 Jan 2024 05:15:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IEZzs8spZDZYMm9EnuC4s8/EFkZves6XXGiQkFGPbstfh2MunIPyLTwZ7nnXYRywPfO2KWf X-Received: by 2002:a17:906:4958:b0:a1f:aca1:6bc with SMTP id f24-20020a170906495800b00a1faca106bcmr565721ejt.100.1704892516658; Wed, 10 Jan 2024 05:15:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704892516; cv=none; d=google.com; s=arc-20160816; b=LI04/9J/oV5CTNzdDe0raVF/H4CDJjYt7HkwN75QBafZqA867VOIQ1DYLe842Vplxq gW59JfAJQzU68XG3oqEwtTv86pFNtqn8y0VNRX+3B2XzbRzlYnzx4Glo36XrF9W2iXcA TnZNXFaVrTyd97vcQmBShQSGzYmy8g9kshEWkydFVhfhPXCfRYRwLUSQtTW02QYWeImP fUSZhL7G+jQdjkpjZDnN4S/Eskgwnqd18fTB4IxcVxV2E27dMmRYXPepBTpkQU9IZosJ uOuCtr7xV4OXvFM/LeTKkHcKC30Hnih+MLqYLdvLZ/y5c4rLHmGFmBfijOPYHb5BaC+t ijRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=SnWxIIZoT2+9NwtCVXP3nMqr5IrKTVI4AnhzowzhThg=; fh=+lp0lfSSGH2I/0ZvRCDpDuWUCzMNNEhwJkYtKjinO/M=; b=tV3/Cnd8mQah7eqXa6CnPZI8k/Aa3HKjKNKX8UsL/05dEadzMpAnf83F7G/2x8NRPs 3rV2N+DDa4OJZsjEqTOOfOg6t3dtOrzbMyzQwF085q3GiYA/EfgFYUQZ9iNqZU2ricfH yab2/HX40Y/X7t8myrx/Ol6jtREKhdjC6FsH5/xeN48rkgkM6PG6FKCP7fVzIvOWfBWK +3LBDM09nQHnEsavIF70LBHPJbTISMnKBicA8JH/aQ0HUi5ShBSQxTcodzsalJg4QQCh Z8ZxbNsuobIB1JExXKZK3sTzC3H6vEf1vDYgWjbWA31WLTtM/vI5aiBkjPxfpgv7KvpI ygUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=oSjWTJ2M; spf=pass (google.com: domain of linux-kernel+bounces-22218-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-22218-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id k25-20020a17090646d900b00a26e29353bdsi1781895ejs.734.2024.01.10.05.15.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 05:15:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-22218-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=oSjWTJ2M; spf=pass (google.com: domain of linux-kernel+bounces-22218-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-22218-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6B7AE1F2538C for ; Wed, 10 Jan 2024 13:15:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 22EAD48CCA; Wed, 10 Jan 2024 13:15:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="oSjWTJ2M" Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.4]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 184E848CC0 for ; Wed, 10 Jan 2024 13:15:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=SnWxI IZoT2+9NwtCVXP3nMqr5IrKTVI4AnhzowzhThg=; b=oSjWTJ2MWRA8ilepHlsrK EM+qxn8N2dujb3rUqu21ybEU8k3XcUJDXupOlGvu2nNvfa5gsFi+oqXbYzG37tiM QqacMYDE0iuJ+1sZDWaGrgP8NFnkpX5B9KnUYsVFaD6+sjlObv5ra1Lgt2JYylqj Hc8npjbg+0MzqYdsZ6atW4= Received: from ubuntu.lan (unknown [120.229.70.208]) by gzga-smtp-mta-g0-2 (Coremail) with SMTP id _____wDHD60ujZ5lR2ZVAA--.7604S2; Wed, 10 Jan 2024 20:27:28 +0800 (CST) From: Junwen Wu To: bristot@redhat.com Cc: bsegall@google.com, dietmar.eggemann@arm.com, juri.lelli@redhat.com, laoar.shao@gmail.com, linux-kernel@vger.kernel.org, mgorman@suse.de, mingo@redhat.com, peterz@infradead.org, rostedt@goodmis.org, vincent.guittot@linaro.org, vschneid@redhat.com, wudaemon@163.com Subject: Re: [PATCH v3] sched/stats: Fix rt/dl task's sched latency statistics error in sched_stat_wait trace_point Date: Wed, 10 Jan 2024 12:27:26 +0000 Message-Id: <20240110122726.4309-1-wudaemon@163.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <87d33909-ef8c-43a6-a556-d01fe692d5cd@redhat.com> References: <87d33909-ef8c-43a6-a556-d01fe692d5cd@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:_____wDHD60ujZ5lR2ZVAA--.7604S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjTRMFALUUUUU X-CM-SenderInfo: 5zxgtvxprqqiywtou0bp/xtbBzRRhbWVOBWrIugAAsj >This error happens when the rt task balances off the source CPU because >the dequeue operation is not updating the sched_statistics. So, follow >update_stats_wait_end_fair() and update the stats. Do the same for >SCHED_DEADLINE. >[ feel free to change ] ok >> + /* >> + * Mark the end of the wait period >> + * if dequeueing a waiting task. >> + */ >make this a single line comment. ok -- Best regards