Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp986512rdd; Wed, 10 Jan 2024 05:35:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IFmD4K7R6BEA58/I1jAof5uHwLEdnTkrtc8htqpsVNw9l+dN/eg0sDG5YEx2dtJzeErzT4u X-Received: by 2002:a17:906:2642:b0:a2b:d1be:936b with SMTP id i2-20020a170906264200b00a2bd1be936bmr63676ejc.34.1704893741448; Wed, 10 Jan 2024 05:35:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704893741; cv=none; d=google.com; s=arc-20160816; b=MRA2LwJz0eA+Fi5bdoBkWWVz4q2vMgQ/D/u2chZ9YuZSbSr10DvSMTG8ToxM9dAjCe yKtPSNWWOw93X6lCYjDVX5Ts0Y1DEi6fkQEVG9Es+0aOdsPEkhnNYaQVMs6sUZW+5Gxx W3C2dU98u7tkh6P8i+GOmgcpshIbOwylz2ByC/+i5D1dL9TdzKAVuqaojGt6DqAQGhyz kBNPgfP7h0nFswh7c1p5yriPZ1GPhryGxHCDF1bK7Y5eIQpDhMTyI5v5lCHn062xkpbF aavvvDl9HWn/0LxVsiZb5vST1vbQFTUfYse6mr7mZcDmfeKRTchqCbLhyVsoatrcLzGE Pbiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ofpk5Lj5mHQoPfTRHvBkU96soQ/Y/F6U4QFkFDZzxXQ=; fh=oUQXlm9N18NE8BciMxTG8yakJePvyLDL7KOQwgHv8WI=; b=OZ3+HJdEA5N7C9V5dMyr/LFmRSTV+b7M7DExnlKHqO168Tz89T0oFhf4cne/Nk+aTA uuJVvbhkOtj/BV9bvabOCTbZmrh3/Ueww/IN1Zb7vVNnPPxEEu1GrWKbQYz7bujWF9X4 HNUIHjAW5ZAr/1X7YHUAKTnpt9mODjE4om+dhVn0ZNlGW3JnS0Q8lNt8Sdzwc9Cw0gPh 28Gh82HpszvnBWlF2O/N/urBJnb9vVcKb+3wBdryDIBsbCiMXO8G5PpcluHzVXTXyw8L B/e8EijQ+rvXdsuskwwQruuTSkG+PVBA/agpaZzxyA/WtjFwMwF0OjcF8ArA2ugsSlgJ U6fQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rRuYHojv; spf=pass (google.com: domain of linux-kernel+bounces-22247-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-22247-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id hg13-20020a170906f34d00b00a28fbf42caesi1784079ejb.633.2024.01.10.05.35.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 05:35:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-22247-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rRuYHojv; spf=pass (google.com: domain of linux-kernel+bounces-22247-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-22247-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 392B91F22E75 for ; Wed, 10 Jan 2024 13:35:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 742064C615; Wed, 10 Jan 2024 13:33:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rRuYHojv" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 964734C3D7; Wed, 10 Jan 2024 13:33:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C86F2C43390; Wed, 10 Jan 2024 13:33:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704893599; bh=80gsdR23OIMDUmaGo86P6z0jlYyc+cs3tLIj2ceqAEY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rRuYHojvCugPDSpoU3P//lFkFdXY7opAArZFaL3Zr9788k4aYSZsFPf2j58BZ6NVB 8kfOX5BlyQhSGyb0Ex3PCsjO7JNNPISfURp+Q/m90qMQLtREQsOJ4zFs9NU9vN9RXm Ps5dHXUm6XVlmQPKIfHqKlV1UCO2BN1sJQ7za+TZ0CD44Gyl+naHv5UNjowsr+m24Q t3ElTGyl2alBm0DQrO9a6o5YuUIonf+a7ZUCikcqj8tp1tf7bJZDDY4QixVJ8JLUsh 2MHHbAiZC5kU4HiGyvKKxjVeRk99e/rooBTJ07I9SHRLvyjjYP03++6fIyDJuZPsDz trHs22lyGlWDw== Date: Wed, 10 Jan 2024 13:33:13 +0000 From: Simon Horman To: Sneh Shah Cc: Vinod Koul , Bhupesh Sharma , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@quicinc.com, Andrew Halaney Subject: Re: [PATCH net v3] net: stmmac: Fix ethool link settings ops for integrated PCS Message-ID: <20240110133313.GA9296@kernel.org> References: <20240109144729.26102-1-quic_snehshah@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240109144729.26102-1-quic_snehshah@quicinc.com> On Tue, Jan 09, 2024 at 08:17:29PM +0530, Sneh Shah wrote: > Currently get/set_link_ksettings ethtool ops are dependent on PCS. > When PCS is integrated, it will not have separate link config. > Bypass configuring and checking PCS for integrated PCS. > > Fixes: aa571b6275fb ("net: stmmac: add new switch to struct plat_stmmacenet_data") > Tested-by: Andrew Halaney # sa8775p-ride > Signed-off-by: Sneh Shah Reviewed-by: Simon Horman