Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp997623rdd; Wed, 10 Jan 2024 05:56:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IFwlrvy95SSRWktzQB5o4cGJHAvTLjaE6L3AavjtTibeITelE/2joOHeu0UJlTNnzmvmdse X-Received: by 2002:a17:907:501:b0:a2c:180b:a650 with SMTP id wj1-20020a170907050100b00a2c180ba650mr59698ejb.123.1704894989335; Wed, 10 Jan 2024 05:56:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704894989; cv=none; d=google.com; s=arc-20160816; b=rSXdyb/DhgL4zNnL15BnejMzwund9GBM6QWbUa09NtO8Nft7u7cvYWaNqblPA7gBpY H/yb2POjgGtZWfwupoPgsStKWqh41n48QjZnblp1AQZ1MGTI3anhbAU8x/MHTkj1iTuF yFggdSBfxzhNwnCWvgIAAIpeAHd7fLzOweRr0y1KU9FS1l25iyxBp60HUzcvQ5kzfWgs EoQIGg0Q6NWp/RmANahDFAtiGIhN2XBePR1NlUYAR+4x+k5xK6+CzchCxqs0wv3/KpSq HU066LoHJ00LrcXV6xoAV+cu4QhBpR9As8jTWwbf1Pn2Jo50LueXIOsd40y4LHjcm+j9 g89Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=YwLyu0iJrpBH9/g3qo8RoPNcO8d5ZEo6Ti3en+W2D+k=; fh=Sntd+G0CthFoKfHeh5KAtcEJMuc35jsG6LFomUCRudQ=; b=jRPVor09lCTMabteqn1S7ifsA7yGCTTkQktctWrW7tz8PWTjSfzk8mIk9tMkIBjylv yMs3367BW8uLTZg+f+WzJQO9qkgbro5cdpW7RwEDe7HHwtdruUUA29p6RVV4SPc7g3BA Sc6yEoiY6T/QmgeatV5BEIYINTo6Ij0DcNA6LlPT5gddLPaPVgYh73pg4OUM4qXQMLnO IjngIXyWbqTBXl7VSBQhGoZLg+1M97jrjRhKmBaTANMWLWeA/DTH3FG2E1LZRD3J8A+u EoUSyKJaCdRZlZ0MgQr9pQcl1z4tP/WCFMZjeqANyAKwQ0IWvMnfwv2VDka2EvuW8R8H qcew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-22287-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-22287-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a11-20020a17090640cb00b00a28d20872a4si1745257ejk.802.2024.01.10.05.56.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 05:56:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-22287-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-22287-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-22287-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 15B731F22663 for ; Wed, 10 Jan 2024 13:56:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EE5A1495F9; Wed, 10 Jan 2024 13:56:04 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BE4D34A984; Wed, 10 Jan 2024 13:56:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DFE5E2F4; Wed, 10 Jan 2024 05:56:47 -0800 (PST) Received: from [10.57.87.179] (unknown [10.57.87.179]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D7D053F5A1; Wed, 10 Jan 2024 05:55:59 -0800 (PST) Message-ID: <43f2fdd1-7153-4061-810e-f84bc9df40b8@arm.com> Date: Wed, 10 Jan 2024 13:57:23 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 05/23] PM: EM: Refactor a new function em_compute_costs() Content-Language: en-US To: "Rafael J. Wysocki" Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dietmar.eggemann@arm.com, rui.zhang@intel.com, amit.kucheria@verdurent.com, amit.kachhap@gmail.com, daniel.lezcano@linaro.org, viresh.kumar@linaro.org, len.brown@intel.com, pavel@ucw.cz, mhiramat@kernel.org, qyousef@layalina.io, wvw@google.com References: <20240104171553.2080674-1-lukasz.luba@arm.com> <20240104171553.2080674-6-lukasz.luba@arm.com> From: Lukasz Luba In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/4/24 19:15, Rafael J. Wysocki wrote: > Here, I would say "Introduce em_compute_costs()" in the subject and then -> OK > > On Thu, Jan 4, 2024 at 6:15 PM Lukasz Luba wrote: >> >> Refactor a dedicated function which will be easier to maintain and re-use > > -> "Move the EM costs computation code into a new dedicated function, > em_compute_costs(), that can be reused in other places in the future." > OK