Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp1011386rdd; Wed, 10 Jan 2024 06:15:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IFKoXmBBaClya0czKfcj+Rt9wgXTlNDqUSHSG1cZ3la2RMnyd89SPhR5Zr+8Abi6sdhHKNd X-Received: by 2002:a17:90a:d30f:b0:28b:bbc0:c555 with SMTP id p15-20020a17090ad30f00b0028bbbc0c555mr199018pju.8.1704896105076; Wed, 10 Jan 2024 06:15:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704896105; cv=none; d=google.com; s=arc-20160816; b=B2Zrl+LeV/pDrra4lHl1784dO/2khts5rJcjPfD8Snek/96wjt0TyLndIdrLgw5N4x QYkYnUQUvAi90mHqzjSjRdk1QZ2cjliBtDXfQyBGaMYkFZNTr8nRlR0N7QGIU0/MMW43 aw3GDwf2Dr9W4r2u7GMg/9ouWmQomZxMJj7QwF51aSAQd07Mkp60VA80TzJ8b+is4qm/ V/Q4yi4W0i4G0oYXhIiSTLyY0F1tQgoaDliTOtosIT3oPpk39b8A6lvcphgMQ2y5nvn2 28CE8yUUazFsKZEegW2imReZk08Lj3hHBITMYNYS74FLN1lxCvApqHj3iz73tsnyfVbY cJoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=y1xCn2jrvNc+JGnvHYCGChXL5BM3ayTbxR63XVjv0yw=; fh=MJQCTdB8THRk+guOUrF1wskzA1EM4GctDO8V9jw7GIs=; b=E+ql0SJQPNxvlXULMWXVWephTSQhmqgTnGZgTL0lCXPjB26ovq89ApstXhsZgJKu9v vEH1IxfZvYLe1G3+s3J0qH7jJL1e8o2svP7cAhyzg+CTsaIwQWVkZgnUOxe50HzOAuqe aUfleToazbdI+SGTUQxn2MJPtXGhRZuWZMaVuy0jxXE14bLK1TAARkOMZjPykq5mDt70 c1oE3N3xWLfl0AjDnMfg94JZzMzixKecjXJVr0+C8QFim8GirI8dFNfSn364ec9f0FV4 FQtF9bYAaXkQ8S6EHGMWLcBVBBtE/coqbzTD2Od+Jqa5F6cpuWyJFiJ5d+1X9v5LCTCB 9fhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LL5u0QqL; spf=pass (google.com: domain of linux-kernel+bounces-22326-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-22326-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id m6-20020a17090a668600b0028c9f74f6f6si1501772pjj.0.2024.01.10.06.15.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 06:15:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-22326-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LL5u0QqL; spf=pass (google.com: domain of linux-kernel+bounces-22326-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-22326-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A084A283ABB for ; Wed, 10 Jan 2024 14:14:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6F8874CB3E; Wed, 10 Jan 2024 14:12:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LL5u0QqL" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A20F44CB31 for ; Wed, 10 Jan 2024 14:12:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB08DC433C7; Wed, 10 Jan 2024 14:12:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704895948; bh=BgMHosMhdx0/coJE/dTNo3tadzvMNfGKQ6ctFHbmJYM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LL5u0QqLTfOpd34wrzgSzAZii3KoaXfIpbwuBpO1dDoSYtMC3fyPAozP0cgBrpRkw 3VN+kONAuhXwZ2qTRLTg81ORtxEZAGrN6vzwkAyJuN3GhJf8i5DSWfKF0LhvbFzvY8 6CzNVWdzPVUon8hISxvRPNs4yxy5InGt9njxQ+Q5+rdvjcB21H5YFZNtXZzkHMvjga 07s6QJ8+ajTKuluPDDSo06zAPJRO6CJ6FV2rdIY10O2abybApIWbuUVgo3NQa2YBD2 NPtY4N5kYPw5ikHLjbBaV8tqlLa29jgWXfTFgtJl113XdjLcz7FDueJAAucBqKmq3S wlpaZhK8Fg9QQ== Date: Wed, 10 Jan 2024 15:12:25 +0100 From: Frederic Weisbecker To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira Subject: Re: [PATCH] sched/isolation: Warn about missing isolcpus mask Message-ID: References: <20240110114610.1941474-1-vschneid@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240110114610.1941474-1-vschneid@redhat.com> Le Wed, Jan 10, 2024 at 12:46:10PM +0100, Valentin Schneider a ?crit : > Since an empty string is a valid cpulist, this cmdline option does not > trigger any warnings: > > isolcpus=domain, > > housekeeping_setup() just carries on and we end up with the housekeeping > mask being all CPUs in the system. > > Check that there *is* a cpulist and that it isn't empty. > > Signed-off-by: Valentin Schneider Acked-by: Frederic Weisbecker