Received-SPF: pass (google.com: domain of linux-kernel+bounces-22346-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240109175844.448006-1-e.velu@criteo.com>
In-Reply-To: <20240109175844.448006-1-e.velu@criteo.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Wed, 10 Jan 2024 15:21:20 +0100
Message-ID: <CAJZ5v0ipYQURmFGGwmS5oyOuAOFDbG7TaaaWg4Ze-7PpBnSwkQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] cpufreq/amd-pstate: Adding Zen4 support in introduction
To: Erwan Velu <erwanaliasr1@gmail.com>
Cc: Erwan Velu <e.velu@criteo.com>, Huang Rui <ray.huang@amd.com>, 
	"Rafael J. Wysocki" <rafael@kernel.org>, Viresh Kumar <viresh.kumar@linaro.org>, linux-pm@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 9, 2024 at 6:58=E2=80=AFPM Erwan Velu <erwanaliasr1@gmail.com> =
wrote:
>
> amd-pstate is implemented on Zen4, adding this architecture in the
> introduction.
>
> Signed-off-by: Erwan Velu <e.velu@criteo.com>
> ---
>  drivers/cpufreq/amd-pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 1f6186475715..9a8d083f6ba5 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -14,7 +14,7 @@
>   * communicate the performance hints to hardware.
>   *
>   * AMD P-State is supported on recent AMD Zen base CPU series include so=
me of
> - * Zen2 and Zen3 processors. _CPC needs to be present in the ACPI tables=
 of AMD
> + * Zen2, Zen3 and Zen4 processors. _CPC needs to be present in the ACPI =
tables of AMD

IMO, it would be really nice to avoid extending this line so much, but
this is up to the AMD people.

Also, while you are at it, "include" in the first sentence should be
"including" and a new paragraph after "processors." would make this
comment easier to follow from the logical standpoint, because the
first sentence is about the supported platforms and the second one is
about additional requirements (ie. something else).

>   * P-State supported system. And there are two types of hardware impleme=
ntations
>   * for AMD P-State: 1) Full MSR Solution and 2) Shared Memory Solution.
>   * X86_FEATURE_CPPC CPU feature flag is used to distinguish the differen=
t types.
> --