Received-SPF: pass (google.com: domain of linux-kernel+bounces-22358-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240109175844.448006-1-e.velu@criteo.com> <CAJZ5v0ipYQURmFGGwmS5oyOuAOFDbG7TaaaWg4Ze-7PpBnSwkQ@mail.gmail.com>
In-Reply-To: <CAJZ5v0ipYQURmFGGwmS5oyOuAOFDbG7TaaaWg4Ze-7PpBnSwkQ@mail.gmail.com>
From: Erwan Velu <erwanaliasr1@gmail.com>
Date: Wed, 10 Jan 2024 15:30:41 +0100
Message-ID: <CAL2Jzuz5OMiU6g+dYu+SU0E=ydBmpZzbQ5XpEfRtheWYkfB6=w@mail.gmail.com>
Subject: Re: [PATCH 2/2] cpufreq/amd-pstate: Adding Zen4 support in introduction
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Erwan Velu <e.velu@criteo.com>, Huang Rui <ray.huang@amd.com>, 
	Viresh Kumar <viresh.kumar@linaro.org>, linux-pm@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

So it's probably better to let AMD people fixing this part.
Thx for the feedback.

Le mer. 10 janv. 2024 =C3=A0 15:21, Rafael J. Wysocki <rafael@kernel.org> a=
 =C3=A9crit :
>
> On Tue, Jan 9, 2024 at 6:58=E2=80=AFPM Erwan Velu <erwanaliasr1@gmail.com=
> wrote:
> >
> > amd-pstate is implemented on Zen4, adding this architecture in the
> > introduction.
> >
> > Signed-off-by: Erwan Velu <e.velu@criteo.com>
> > ---
> >  drivers/cpufreq/amd-pstate.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.=
c
> > index 1f6186475715..9a8d083f6ba5 100644
> > --- a/drivers/cpufreq/amd-pstate.c
> > +++ b/drivers/cpufreq/amd-pstate.c
> > @@ -14,7 +14,7 @@
> >   * communicate the performance hints to hardware.
> >   *
> >   * AMD P-State is supported on recent AMD Zen base CPU series include =
some of
> > - * Zen2 and Zen3 processors. _CPC needs to be present in the ACPI tabl=
es of AMD
> > + * Zen2, Zen3 and Zen4 processors. _CPC needs to be present in the ACP=
I tables of AMD
>
> IMO, it would be really nice to avoid extending this line so much, but
> this is up to the AMD people.
>
> Also, while you are at it, "include" in the first sentence should be
> "including" and a new paragraph after "processors." would make this
> comment easier to follow from the logical standpoint, because the
> first sentence is about the supported platforms and the second one is
> about additional requirements (ie. something else).
>
> >   * P-State supported system. And there are two types of hardware imple=
mentations
> >   * for AMD P-State: 1) Full MSR Solution and 2) Shared Memory Solution=
.
> >   * X86_FEATURE_CPPC CPU feature flag is used to distinguish the differ=
ent types.
> > --