Received-SPF: pass (google.com: domain of linux-kernel+bounces-22362-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <2dd37d2b-28da-4e73-9047-61ec5d64bdb5@linux.ibm.com>
Date: Wed, 10 Jan 2024 08:31:05 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Conor Dooley <conor@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, joel@jms.id.au,
        andrew@codeconstruct.com.au, peterhuewe@gmx.de, jarkko@kernel.org,
        jgg@ziepe.ca, keescook@chromium.org, tony.luck@intel.com,
        gpiccoli@igalia.com, johannes.holland@infineon.com, broonie@kernel.org,
        patrick.rudolph@9elements.com, vincent@vtremblay.dev,
        peteryin.openbmc@gmail.com, lakshmiy@us.ibm.com, bhelgaas@google.com,
        naresh.solanki@9elements.com, alexander.stein@ew.tq-group.com,
        festevam@denx.de, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org,
        linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
        linux-hardening@vger.kernel.org, geissonator@yahoo.com
References: <20231212164004.1683589-1-ninad@linux.ibm.com>
 <20231212164004.1683589-8-ninad@linux.ibm.com>
 <20231212-avid-grill-dbead068fac8@spud>
 <73381bb0-7fa7-4a9e-88df-ab0063058e26@roeck-us.net>
 <20231212-mouth-choice-40a83caa34ec@spud>
 <2946fbb1-2a47-4d21-83dc-8e45bf6ba5a9@roeck-us.net>
 <60c8bbdb-4e08-44f0-88d4-ab164d4843b5@linux.ibm.com>
 <20240109-pep-coerce-2a86ae88753d@spud>
 <01974929-dfbf-4989-ba39-369e521827d0@linux.ibm.com>
 <3d194e84-bf1a-48e4-a376-e5c327c6508d@linaro.org>
Content-Language: en-US
From: Ninad Palsule <ninad@linux.ibm.com>
In-Reply-To: <3d194e84-bf1a-48e4-a376-e5c327c6508d@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0

Hello Krzysztof,


>>>> I have send it as a separate commit. https://lore.kernel.org/linux-kernel/20231214144954.3833998-1-ninad@linux.ibm.com/
>>> Why did you do that? It now just adds undocumented compatibles to the
>>> driver. Please, as Rob requested, work with Lukas on his series to make
>>> sure that these devices are documented.
>> I think krzysztof kozlowski suggested to send these patches separately:
>> https://lore.kernel.org/linux-kernel/1c5ace65-2fd8-4503-b22f-e0f564d1c83f@linaro.org/
>>
>> Did I misunderstood it? Do you guys want me to include that commit again?
> My comment was in DTS thread under specific DTS patch. How did you
> figure out it applies to driver and bindings? This does not make sense.

Sorry for the misunderstanding. Where do you want me to add driver 
patch? Before all DTS patches or after all DTS patches?

tpm: tis-i2c: Add more compatible strings
ARM: dts: aspeed: System1: IBM system1 BMC board
dt-bindings: Add DPS310 as trivial device
dt-bindings: arm: aspeed: add IBM system1-bmc

OR

ARM: dts: aspeed: System1: IBM system1 BMC board
dt-bindings: Add DPS310 as trivial device
dt-bindings: arm: aspeed: add IBM system1-bmc

tpm: tis-i2c: Add more compatible strings

Thanks & Regards,

Ninad Palsule